You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-13] [$1000] workspace picture not update in report screen #19550
should show updated workspace picture in report screen
Actual Result:
does not show updated workspace picture in report screen
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.17-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Since the icons doesn't exist in this.props.report this will make this condition always return false. That's why when we updated the avatar, the avatar of ReportActionItemCreated isn't updated.
What changes do you think we should make in order to solve the problem?
Add the icons props to ReportActionsView and change the condition of shouldComponentUpdate:
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-13. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
This isn't a regression. But a miss from the original implementation and we didn't get to know of this issue until now.
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Very minor case only present in large screen devices. So I don't think regression test is beneficial in this case.
@twisterdotcom I'm not sure if this issue can get bonus, it can be merged within 3 days I believe, but then we found a similar issue and we decided to fix half of that issue as well 😂 (This one: #19847)
Activity
melvin-bot commentedon May 24, 2023
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 24, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)hungvu193 commentedon May 25, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace picture not update in report screen
What is the root cause of that problem?
Problem came from here:
App/src/pages/home/report/ReportActionsView.js
Line 172 in 7a42755
Since the
iconsdoesn't exist inthis.props.reportthis will make this condition always return false. That's why when we updated the avatar, the avatar ofReportActionItemCreatedisn't updated.What changes do you think we should make in order to solve the problem?
Add the icons props to
ReportActionsViewand change the condition ofshouldComponentUpdate:and the condition of shouldComponentUpdate inside
ReportActionsView:We can keep the old condition above the new condition if we want but we need to change it to
ifcondition:What alternative solutions did you explore? (Optional)
In case we don't wanna pass a new props, we can also calculate the icons inside shouldComponentUpdate of
ReportActionsView:Result
Screen.Recording.2023-05-25.at.10.50.34.mov
[-]workspace picture not update in report screen[/-][+][$1000] workspace picture not update in report screen[/+]melvin-bot commentedon May 26, 2023
Job added to Upwork: https://www.upwork.com/jobs/~018c5cb09414a1b64c
melvin-bot commentedon May 26, 2023
Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon May 26, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (
External)melvin-bot commentedon May 26, 2023
Triggered auto assignment to @iwiznia (
External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.18 remaining items
melvin-bot commentedon Jun 6, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 6, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-13. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jun 6, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
abdulrahuman5196 commentedon Jun 7, 2023
Bugzero checklist:
This isn't a regression. But a miss from the original implementation and we didn't get to know of this issue until now.
Very minor case only present in large screen devices. So I don't think regression test is beneficial in this case.
twisterdotcom commentedon Jun 14, 2023
Okay, all offers sent. Sorry for the delay.
gadhiyamanan commentedon Jun 14, 2023
@twisterdotcom accepted, Thanks!
abdulrahuman5196 commentedon Jun 14, 2023
@twisterdotcom accepted
hungvu193 commentedon Jun 14, 2023
I've just accepted! Thanks @twisterdotcom
twisterdotcom commentedon Jun 14, 2023
Wow, you're all online! Great. Okay, we didn't get the "bonus" issue comment, but just double checking, there isn't one due.
Assigned: #19550 (comment) - May 29th, 2023 @ 4:38 PM GMT +1
Merged: #19750 (comment) - June 5, 2023 @ 6.12 PM GMT +1
hungvu193 commentedon Jun 14, 2023
@twisterdotcom I'm not sure if this issue can get bonus, it can be merged within 3 days I believe, but then we found a similar issue and we decided to fix half of that issue as well 😂 (This one: #19847)
twisterdotcom commentedon Jun 14, 2023
I think if this solved another issue too, your "bonus" is the payment for that issue as well.