Skip to content

[HOLD for payment 2023-06-13] [$1000] workspace picture not update in report screen #19550

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. go to Settings > Workspaces
  2. create new workspace
  3. close the modal
  4. click on workspace chat in LHN
  5. go to Settings > Workspaces
  6. change the workspace picture
  7. check the workspace picture in report screen

Expected Result:

should show updated workspace picture in report screen

Actual Result:

does not show updated workspace picture in report screen

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.17-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-16.at.7.13.42.PM.mov
Recording.207.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684772113159839?thread_ts=1684126449.749049&cid=C049HHMV9SM

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018c5cb09414a1b64c
  • Upwork Job ID: 1662132297655844864
  • Last Price Increase: 2023-05-26

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 24, 2023
  2. melvin-bot commented on May 24, 2023

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 24, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. hungvu193 commented on May 25, 2023

    @hungvu193
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Workspace picture not update in report screen

    What is the root cause of that problem?

    Problem came from here:

    return !_.isEqual(lodashGet(this.props.report, 'icons', []), lodashGet(nextProps.report, 'icons', []));

    Since the icons doesn't exist in this.props.report this will make this condition always return false. That's why when we updated the avatar, the avatar of ReportActionItemCreated isn't updated.

    What changes do you think we should make in order to solve the problem?

    Add the icons props to ReportActionsView and change the condition of shouldComponentUpdate:

    const currentReportData = (isTaskReport || !isThread) && props.report.parentReportID ? props.parentReport : props.report;
    const icons = ReportUtils.getIcons(this.props.report, this.props.personalDetails);
    
                                    <ReportActionsView
                                        reportActions={this.props.reportActions}
                                        report={this.props.report}
                                        isComposerFullSize={this.props.isComposerFullSize}
                                        isDrawerOpen={this.props.isDrawerOpen}
                                        parentViewHeight={this.state.skeletonViewContainerHeight}
                                        personalDetails={this.props.personalDetails}
                                        icons={icons}
                                    />

    and the condition of shouldComponentUpdate inside ReportActionsView:

    return !_.isEqual(lodashGet(this.props, 'icons', []), lodashGet(nextProps, 'icons', []));

    We can keep the old condition above the new condition if we want but we need to change it toif condition:

    if (!isEqual(lodashGet(this.props.report, 'icons', []), lodashGet(nextProps.report, 'icons', [])) {
    return true;
    }

    What alternative solutions did you explore? (Optional)

    In case we don't wanna pass a new props, we can also calculate the icons inside shouldComponentUpdate of ReportActionsView:

      const icons = ReportUtils.getIcons(this.props.report, this.props.personalDetails);
      const nextIcons = ReportUtils.getIcons(nextProps, this.props.personalDetails);
    
    
    
    return !_.isEqual(icons, nextIcons);

    Result

    Screen.Recording.2023-05-25.at.10.50.34.mov
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 26, 2023
  6. changed the title [-]workspace picture not update in report screen[/-] [+][$1000] workspace picture not update in report screen[/+] on May 26, 2023
  7. melvin-bot commented on May 26, 2023

    @melvin-bot
  8. melvin-bot commented on May 26, 2023

    @melvin-bot

    Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

  9. melvin-bot commented on May 26, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 26, 2023
  11. melvin-bot commented on May 26, 2023

    @melvin-bot

    Triggered auto assignment to @iwiznia (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  12. 18 remaining items

  13. melvin-bot commented on Jun 6, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jun 6, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-06-13. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  15. melvin-bot commented on Jun 6, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
    • [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@abdulrahuman5196] Determine if we should create a regression test for this bug.
    • [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. abdulrahuman5196 commented on Jun 7, 2023

    @abdulrahuman5196
    Contributor

    Bugzero checklist:

    The PR that introduced the bug has been identified. Link to the PR:
    The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    This isn't a regression. But a miss from the original implementation and we didn't get to know of this issue until now.

    A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    [@abdulrahuman5196] Determine if we should create a regression test for this bug.
    [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Very minor case only present in large screen devices. So I don't think regression test is beneficial in this case.

  17. twisterdotcom commented on Jun 14, 2023

    @twisterdotcom
    Contributor

    Okay, all offers sent. Sorry for the delay.

  18. gadhiyamanan commented on Jun 14, 2023

    @gadhiyamanan
    Contributor

    @twisterdotcom accepted, Thanks!

  19. abdulrahuman5196 commented on Jun 14, 2023

    @abdulrahuman5196
    Contributor
  20. hungvu193 commented on Jun 14, 2023

    @hungvu193
    Contributor

    I've just accepted! Thanks @twisterdotcom

  21. twisterdotcom commented on Jun 14, 2023

    @twisterdotcom
    Contributor

    Wow, you're all online! Great. Okay, we didn't get the "bonus" issue comment, but just double checking, there isn't one due.

    Assigned: #19550 (comment) - May 29th, 2023 @ 4:38 PM GMT +1
    Merged: #19750 (comment) - June 5, 2023 @ 6.12 PM GMT +1

  22. hungvu193 commented on Jun 14, 2023

    @hungvu193
    Contributor

    @twisterdotcom I'm not sure if this issue can get bonus, it can be merged within 3 days I believe, but then we found a similar issue and we decided to fix half of that issue as well 😂 (This one: #19847)

  23. twisterdotcom commented on Jun 14, 2023

    @twisterdotcom
    Contributor

    I think if this solved another issue too, your "bonus" is the payment for that issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions