You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-12] [$1000] Unnecessary space between the TopBar and profile image, and profile image and share code button too. #19627
Take note of the spacing between TopBar and profile image/profile image and share code button
Reply to a message in a thread
Click on the thread profile icon in the TopBar
Note that spacing is now greater between TopBar and profile image/profile image and share code button
Expected Result:
There should be same space and alignment compare to other profile information page have.
Actual Result:
There is too much Unnecessary space compare to other profile information page have.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.18-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Please re-state the problem that we are trying to solve in this issue.
Unnecessary space between the TopBar and profile image, and profile image and share code button too.
What is the root cause of that problem?
The root cause is we have not followed exact same pattern (style) as we did on other pages like settings,profile page mostly this will be cleaned up to match across all other pages
What changes do you think we should make in order to solve the problem?
We need to apply all the below changes to ReportDetailsPage.js in order to make consistency with all other pages
Firstly we need to remove and additional <View> with margin m5 which present right after <ScrollView>
Then after we need to cleanup reportDetailsTitleContainer style to match with other by removing spacing.mt4 and height and we need to add some paddingHorizontal: 20 and paddingBottom: 20 which is found on other pages
After that, we need to change RoomHeaderAvatars which has the wrong marginBottom<view>styles.mb4 to styles.mb3
After that we need to add styles.mt1 to <View> which is wrapped by <DisplayNames>
Also we need to remove styles.mb2 from textStyles which is prop in <DisplayNames>
From chatRoomSubtitleText we need to remove extra styles.mb2
Lastly, we need to make chatRoomSubtitleText render only if there is a name otherwise we need to remove the component that occupies extra space
The margin between <DispalyName> and <Menuitem> we can change as per needed all the minor adjustment and cleanup can be done on PR
changed the title [-]Unnecessary space between the TopBar and profile image, and profile image and share code button too.[/-][+][$1000] Unnecessary space between the TopBar and profile image, and profile image and share code button too.[/+]on May 26, 2023
changed the title [-][$1000] Unnecessary space between the TopBar and profile image, and profile image and share code button too.[/-][+][HOLD for payment 2023-06-12] [$1000] Unnecessary space between the TopBar and profile image, and profile image and share code button too.[/+]on Jun 5, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon May 25, 2023
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 25, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)dhairyasenjaliya commentedon May 25, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
We need to apply all the below changes to
ReportDetailsPage.jsin order to make consistency with all other pagesFirstly we need to remove and additional
<View>withmargin m5which present right after<ScrollView>Then after we need to cleanup
reportDetailsTitleContainerstyle to match with other by removingspacing.mt4andheightand we need to add somepaddingHorizontal: 20andpaddingBottom: 20which is found on other pagesAfter that, we need to change
RoomHeaderAvatarswhich has the wrong marginBottom<view>styles.mb4tostyles.mb3After that we need to add
styles.mt1to<View>which is wrapped by<DisplayNames>Also we need to remove
styles.mb2fromtextStyleswhich is prop in<DisplayNames>From
chatRoomSubtitleTextwe need to remove extrastyles.mb2Lastly, we need to make
chatRoomSubtitleTextrender only if there is a name otherwise we need to remove the component that occupies extra spaceThe margin between
<DispalyName>and<Menuitem>we can change as per needed all the minor adjustment and cleanup can be done on PRResult
greg-schroeder commentedon May 26, 2023
Reviewing. Hmm. Yeah, this spacing does look really weird:
I cleaned up the reproduction steps to be a little clearer
[-]Unnecessary space between the TopBar and profile image, and profile image and share code button too.[/-][+][$1000] Unnecessary space between the TopBar and profile image, and profile image and share code button too.[/+]melvin-bot commentedon May 26, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0128a63176752fccad
melvin-bot commentedon May 26, 2023
Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon May 26, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (
External)melvin-bot commentedon May 26, 2023
Triggered auto assignment to @bondydaa (
External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.13 remaining items
[-][$1000] Unnecessary space between the TopBar and profile image, and profile image and share code button too.[/-][+][HOLD for payment 2023-06-12] [$1000] Unnecessary space between the TopBar and profile image, and profile image and share code button too.[/+]melvin-bot commentedon Jun 5, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 5, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
https://www.upwork.com/jobs/~0128a63176752fccad
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jun 5, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
greg-schroeder commentedon Jun 12, 2023
Offers sent to @aimane-chnaif @dhairyasenjaliya @niravkakadiya25
niravkakadiya25 commentedon Jun 12, 2023
Accepted
aimane-chnaif commentedon Jun 12, 2023
This is inconsistency issue between pages and more like polish than bug. I don't think regression test is needed here.
dhairyasenjaliya commentedon Jun 12, 2023
Accepted & also this is eligible for urgency bonus @greg-schroeder
greg-schroeder commentedon Jun 12, 2023
Yes I'm aware of the bonus, thanks all for accepting
greg-schroeder commentedon Jun 12, 2023
Payments complete. Job closed. No regression test required. Closing.