Skip to content

[HOLD for payment 2023-06-12] [$1000] Unnecessary space between the TopBar and profile image, and profile image and share code button too. #19627

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open any chat
  2. Click on profile icon in the TopBar
  3. Take note of the spacing between TopBar and profile image/profile image and share code button
  4. Reply to a message in a thread
  5. Click on the thread profile icon in the TopBar
  6. Note that spacing is now greater between TopBar and profile image/profile image and share code button

Expected Result:

There should be same space and alignment compare to other profile information page have.

Actual Result:

There is too much Unnecessary space compare to other profile information page have.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.18-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-23.at.4.46.21.PM.mov
Untitled

Expensify/Expensify Issue URL:
Issue reported by: @niravkakadiya25
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684841019052619

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0128a63176752fccad
  • Upwork Job ID: 1661999436656521216
  • Last Price Increase: 2023-05-26

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 25, 2023
  2. melvin-bot commented on May 25, 2023

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 25, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. dhairyasenjaliya commented on May 25, 2023

    @dhairyasenjaliya
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    • Unnecessary space between the TopBar and profile image, and profile image and share code button too.

    What is the root cause of that problem?

    • The root cause is we have not followed exact same pattern (style) as we did on other pages like settings,profile page mostly this will be cleaned up to match across all other pages

    What changes do you think we should make in order to solve the problem?

    • We need to apply all the below changes to ReportDetailsPage.js in order to make consistency with all other pages

    • Firstly we need to remove and additional <View> with margin m5 which present right after <ScrollView>


    • Then after we need to cleanup reportDetailsTitleContainer style to match with other by removing spacing.mt4 and height and we need to add some paddingHorizontal: 20 and paddingBottom: 20 which is found on other pages

    • After that, we need to change RoomHeaderAvatars which has the wrong marginBottom<view> styles.mb4 to styles.mb3

    • After that we need to add styles.mt1 to <View> which is wrapped by <DisplayNames>

    • Also we need to remove styles.mb2 from textStyles which is prop in <DisplayNames>

    • From chatRoomSubtitleText we need to remove extra styles.mb2

    • Lastly, we need to make chatRoomSubtitleText render only if there is a name otherwise we need to remove the component that occupies extra space 


    • The margin between <DispalyName> and <Menuitem> we can change as per needed all the minor adjustment and cleanup can be done on PR

    Result


    Screenshot 2023-05-26 at 2 49 47 AM Screenshot 2023-05-26 at 2 52 46 AM
  5. greg-schroeder commented on May 26, 2023

    @greg-schroeder
    Contributor

    Reviewing. Hmm. Yeah, this spacing does look really weird:

    image

    I cleaned up the reproduction steps to be a little clearer

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 26, 2023
  7. changed the title [-]Unnecessary space between the TopBar and profile image, and profile image and share code button too.[/-] [+][$1000] Unnecessary space between the TopBar and profile image, and profile image and share code button too.[/+] on May 26, 2023
  8. melvin-bot commented on May 26, 2023

    @melvin-bot
  9. melvin-bot commented on May 26, 2023

    @melvin-bot

    Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

  10. melvin-bot commented on May 26, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 26, 2023
  12. melvin-bot commented on May 26, 2023

    @melvin-bot

    Triggered auto assignment to @bondydaa (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  13. 13 remaining items

  14. changed the title [-][$1000] Unnecessary space between the TopBar and profile image, and profile image and share code button too.[/-] [+][HOLD for payment 2023-06-12] [$1000] Unnecessary space between the TopBar and profile image, and profile image and share code button too.[/+] on Jun 5, 2023
  15. melvin-bot commented on Jun 5, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Jun 5, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-06-12. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    https://www.upwork.com/jobs/~0128a63176752fccad

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  17. melvin-bot commented on Jun 5, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
    • [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@aimane-chnaif] Determine if we should create a regression test for this bug.
    • [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  18. greg-schroeder commented on Jun 12, 2023

    @greg-schroeder
    Contributor
  19. niravkakadiya25 commented on Jun 12, 2023

    @niravkakadiya25

    Accepted

  20. aimane-chnaif commented on Jun 12, 2023

    @aimane-chnaif
    Contributor

    This is inconsistency issue between pages and more like polish than bug. I don't think regression test is needed here.

  21. dhairyasenjaliya commented on Jun 12, 2023

    @dhairyasenjaliya
    Contributor

    Accepted & also this is eligible for urgency bonus @greg-schroeder

  22. greg-schroeder commented on Jun 12, 2023

    @greg-schroeder
    Contributor

    Yes I'm aware of the bonus, thanks all for accepting

  23. greg-schroeder commented on Jun 12, 2023

    @greg-schroeder
    Contributor

    Payments complete. Job closed. No regression test required. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions