Skip to content

[HOLD for payment 2023-07-03] [$1000] New Chat - Recents list option for a new chat shows incorrect username and avatar after avatar update #19684

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Login
  2. Click FAB > New Chat, observe the list of Recents
  3. Create a money request with one of recents accounts
  4. Change avatar
  5. Click on chat from step 3 - > then thread - > then IOU preview
  6. Click FAB - > New chat

Expected Result:

Recent options should be correctly displayed

Actual Result:

Incorrect account name (IOU hat instead of account) and incorrect avatar (Your account avatar instead another user)
Repro rate 4/5

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.19.2

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/01f4f080cb32f535f3067b29ba1bc19ae61a3de975bf5efdb867461b6c43820d

https://platform.applause.com/services/links/v1/external/7e6b0c2b2d2fb95e02014ca913465e9d17dc05868c0899d631013161dbf3bf6c

https://platform.applause.com/services/links/v1/external/e5b82e0ad05530e5bfc7eeb0e12b1c879da07f855846014a703571c85cc1f53f

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team, and @Nathan-Mulugeta via Slack (#19370)

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012ca2c9c058213c2a
  • Upwork Job ID: 1669361161957789696
  • Last Price Increase: 2023-06-15

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 26, 2023
  2. melvin-bot commented on May 26, 2023

    @melvin-bot

    Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 26, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. StevenKKC commented on May 29, 2023

    @StevenKKC
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Recent list option for a new chat shows incorrect username and avatar after avatar update

    What is the root cause of that problem?

    Recent list options for a new chat are retrieved using getOptions function in OptionsListUtils.js.

    const {recentReports, personalDetails, userToInvite} = OptionsListUtils.getNewChatOptions(
    props.reports,
    props.personalDetails,
    props.betas,
    '',
    [],
    this.props.isGroupChat ? this.excludedGroupEmails : [],
    );

    function getNewChatOptions(reports, personalDetails, betas = [], searchValue = '', selectedOptions = [], excludeLogins = [], includeOwnedWorkspaceChats = false) {
    return getOptions(reports, personalDetails, {
    betas,
    searchInputValue: searchValue.trim(),
    selectedOptions,
    includeRecentReports: true,
    includePersonalDetails: true,
    maxRecentReportsToShow: 5,
    excludeLogins,
    includeOwnedWorkspaceChats,
    });
    }

    And getOptions call createOption function to get list options information, and createOption function returns the report name and icon for the report.

    When getting recent list options for a new chat, money request threads are included by default, so the report name and icon for the money request threads are included in recent list options, and these are not username and avatar.

    What changes do you think we should make in order to solve the problem?

    We should filter out money request threads in recent option list for new chat, new group.

    function getNewChatOptions(reports, personalDetails, betas = [], searchValue = '', selectedOptions = [], excludeLogins = [], includeOwnedWorkspaceChats = false) {
        const filteredReports = _.filter(reports, (report) => !ReportUtils.isMoneyRequestReport(report));
        return getOptions(filteredReports, personalDetails, {
            ...
        }
    }
    

    What alternative solutions did you explore? (Optional)

    None.

  5. melvin-bot commented on May 29, 2023

    @melvin-bot

    @conorpendergrast Whoops! This issue is 2 days overdue. Let's get this updated quick!

  6. conorpendergrast commented on May 30, 2023

    @conorpendergrast

    @kbecciv I haven't been able to reproduce this; is there a more specific set of steps that you can add to help here?

  7. conorpendergrast commented on May 31, 2023

    @conorpendergrast

    Bump on those reproduction step here!

  8. kbecciv commented on Jun 1, 2023

    @kbecciv
    Author

    This issue is inconsistent, that's why you haven't been able to reproduce this.

  9. melvin-bot commented on Jun 5, 2023

    @melvin-bot

    @conorpendergrast Huh... This is 4 days overdue. Who can take care of this?

  10. conorpendergrast commented on Jun 6, 2023

    @conorpendergrast

    I'm really sorry, I've tried about seven times to reproduce this and still haven't been able to do this!

  11. 61 remaining items

  12. melvin-bot commented on Jun 26, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jun 26, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.32-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-07-03. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  14. melvin-bot commented on Jun 26, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
    • [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@fedirjh] Determine if we should create a regression test for this bug.
    • [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. conorpendergrast commented on Jul 6, 2023

    @conorpendergrast

    Looks like I missed hiring people for this, so I'll do that so we can get everyone paid

  16. conorpendergrast commented on Jul 6, 2023

    @conorpendergrast

    All offers sent, and I'll pay them as they are accepted (plus the 50% urgency bonus for @fedirjh and @bernhardoj)

  17. conorpendergrast commented on Jul 6, 2023

    @conorpendergrast

    Everyone paid, just the C+ checklist now @fedirjh please and thank you

  18. fedirjh commented on Jul 6, 2023

    @fedirjh
    Contributor

    @conorpendergrast This issue is related to the money requests project, It seems like a missed case that should’ve been implemented with that project. I am not sure if there is a specific PR that should’ve handled this case.

  19. fedirjh commented on Jul 6, 2023

    @fedirjh
    Contributor

    Regression Test Proposal

    1. Open App
    2. Create a money request with one of recents accounts
    3. Verify that the money request report is only visible inside search page
    4. Verify that the money request report is not visible in other places New Chat, New Group and Split Bill
    • Do we agree 👍 or 👎
  20. conorpendergrast commented on Jul 6, 2023

    @conorpendergrast

    Sounds solid to me, I agree. I've created this regression test request: https://github.com/Expensify/Expensify/issues/297694

    All done, thanks everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions