You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-03] [$1000] New Chat - Recents list option for a new chat shows incorrect username and avatar after avatar update #19684
And getOptions call createOption function to get list options information, and createOption function returns the report name and icon for the report.
When getting recent list options for a new chat, money request threads are included by default, so the report name and icon for the money request threads are included in recent list options, and these are not username and avatar.
What changes do you think we should make in order to solve the problem?
We should filter out money request threads in recent option list for new chat, new group.
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.32-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-03. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@conorpendergrast This issue is related to the money requests project, It seems like a missed case that should’ve been implemented with that project. I am not sure if there is a specific PR that should’ve handled this case.
Activity
melvin-bot commentedon May 26, 2023
Triggered auto assignment to @conorpendergrast (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 26, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)StevenKKC commentedon May 29, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Recent list option for a new chat shows incorrect username and avatar after avatar update
What is the root cause of that problem?
Recent list options for a new chat are retrieved using
getOptionsfunction inOptionsListUtils.js.App/src/pages/NewChatPage.js
Lines 56 to 63 in edf529e
App/src/libs/OptionsListUtils.js
Lines 877 to 888 in edf529e
And
getOptionscallcreateOptionfunction to get list options information, andcreateOptionfunction returns the report name and icon for the report.When getting recent list options for a new chat, money request threads are included by default, so the report name and icon for the money request threads are included in recent list options, and these are not username and avatar.
What changes do you think we should make in order to solve the problem?
We should filter out money request threads in recent option list for new chat, new group.
What alternative solutions did you explore? (Optional)
None.
melvin-bot commentedon May 29, 2023
@conorpendergrast Whoops! This issue is 2 days overdue. Let's get this updated quick!
conorpendergrast commentedon May 30, 2023
@kbecciv I haven't been able to reproduce this; is there a more specific set of steps that you can add to help here?
conorpendergrast commentedon May 31, 2023
Bump on those reproduction step here!
kbecciv commentedon Jun 1, 2023
This issue is inconsistent, that's why you haven't been able to reproduce this.
melvin-bot commentedon Jun 5, 2023
@conorpendergrast Huh... This is 4 days overdue. Who can take care of this?
conorpendergrast commentedon Jun 6, 2023
I'm really sorry, I've tried about seven times to reproduce this and still haven't been able to do this!
61 remaining items
melvin-bot commentedon Jun 26, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 26, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.32-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-03. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jun 26, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
conorpendergrast commentedon Jul 6, 2023
Looks like I missed hiring people for this, so I'll do that so we can get everyone paid
conorpendergrast commentedon Jul 6, 2023
All offers sent, and I'll pay them as they are accepted (plus the 50% urgency bonus for @fedirjh and @bernhardoj)
conorpendergrast commentedon Jul 6, 2023
Everyone paid, just the C+ checklist now @fedirjh please and thank you
fedirjh commentedon Jul 6, 2023
@conorpendergrast This issue is related to the money requests project, It seems like a missed case that should’ve been implemented with that project. I am not sure if there is a specific PR that should’ve handled this case.
fedirjh commentedon Jul 6, 2023
Regression Test Proposal
New Chat,New GroupandSplit Billconorpendergrast commentedon Jul 6, 2023
Sounds solid to me, I agree. I've created this regression test request: https://github.com/Expensify/Expensify/issues/297694
All done, thanks everyone