Skip to content

[HOLD for payment 2023-06-13] [$1000] Android - Room details - Welcome message can be inputted only from the middle of Welcome message section #19698

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #18662

Action Performed:

  1. Login to NewDot
  2. Create new room
  3. Go to room settings
  4. Tap Welcome message
  5. Start typing

Expected Result:

Typed text of welcome message should appear from the top of corresponding section

Actual Result:

Typed text of welcome message appears from the middle of corresponding section

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.19.2

Reproducible in staging?: yes

Reproducible in production?: no

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/87f6f9931f00f24607b5541cf30f2be5e2f0389d45870a7fba372af2c5abc45a

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017d6b7a4c0773819c
  • Upwork Job ID: 1663614088285298688
  • Last Price Increase: 2023-05-30

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 26, 2023
  2. melvin-bot commented on May 26, 2023

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 26, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. hungvu193 commented on May 29, 2023

    @hungvu193
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Android - Room details - Welcome message can be inputted only from the middle of Welcome message section

    What is the root cause of that problem?

    We are using multilines TextInput for welcome message, but we didn't set the textAlignVertical for it yet, so when we clicked the input on Android, the cursor will be displayed at the center.

    <TextInput
    inputID="welcomeMessage"
    label={props.translate('welcomeMessagePage.welcomeMessage')}
    multiline
    numberOfLines={10}

    What changes do you think we should make in order to solve the problem?

    We should add the textAlignVertical: top props to the TextInput to make sure the cursor will be at the top.

                            <TextInput
                                inputID="welcomeMessage"
                                label={props.translate('welcomeMessagePage.welcomeMessage')}
                                multiline
                                numberOfLines={10}
                                maxLength={CONST.MAX_COMMENT_LENGTH}
                                ref={welcomeMessageInputRef}
                                value={welcomeMessage}
                                onChangeText={handleWelcomeMessageChange}
                                autoCapitalize="none"
                                textAlignVertical="top"
                            />

    What alternative solutions did you explore? (Optional)

    N/A

    Result

    Screen.Recording.2023-05-29.at.15.55.00.mov
  5. trjExpensify commented on May 30, 2023

    @trjExpensify
    Contributor

    Yup, I can reproduce this on the Android simulator: https://github.com/Expensify/App/assets/16232057/109cc03f-709e-4b4f-929b-57b280fd4c7d

    Going to move this along external.

    CC: @pecanoro

  6. changed the title [-]Android - Room details - Welcome message can be inputted only from the middle of Welcome message section[/-] [+][$1000] Android - Room details - Welcome message can be inputted only from the middle of Welcome message section[/+] on May 30, 2023
  7. melvin-bot commented on May 30, 2023

    @melvin-bot
  8. melvin-bot commented on May 30, 2023

    @melvin-bot

    Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

  9. 14 remaining items

  10. changed the title [-][$1000] Android - Room details - Welcome message can be inputted only from the middle of Welcome message section[/-] [+][HOLD for payment 2023-06-13] [$1000] Android - Room details - Welcome message can be inputted only from the middle of Welcome message section[/+] on Jun 6, 2023
  11. melvin-bot commented on Jun 6, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jun 6, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-06-13. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  13. melvin-bot commented on Jun 6, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
    • [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@fedirjh] Determine if we should create a regression test for this bug.
    • [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. fedirjh commented on Jun 13, 2023

    @fedirjh
    Contributor

    This bug was introduced while implementing a new feature. I believe this issue should have been identified earlier with the current checklist in place. Additionally, conducting tests with different scenarios would have been beneficial for catching such issues. There is no need for further regression testing at this point.

  15. trjExpensify commented on Jun 15, 2023

    @trjExpensify
    Contributor

    Sounds good! Offers here.

    $1,500 - @fedirjh for C+
    $1,500 - @hungvu193 for the bug fix

  16. trjExpensify commented on Jun 15, 2023

    @trjExpensify
    Contributor

    @fedirjh - paid!

  17. hungvu193 commented on Jun 16, 2023

    @hungvu193
    Contributor

    I've accpeted the offer, Thank you @trjExpensify

  18. trjExpensify commented on Jun 16, 2023

    @trjExpensify
    Contributor

    @hungvu193 paid! All done here, closing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions