You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-13] [$1000] Android - Room details - Welcome message can be inputted only from the middle of Welcome message section #19698
Please re-state the problem that we are trying to solve in this issue.
Android - Room details - Welcome message can be inputted only from the middle of Welcome message section
What is the root cause of that problem?
We are using multilines TextInput for welcome message, but we didn't set the textAlignVertical for it yet, so when we clicked the input on Android, the cursor will be displayed at the center.
changed the title [-]Android - Room details - Welcome message can be inputted only from the middle of Welcome message section[/-][+][$1000] Android - Room details - Welcome message can be inputted only from the middle of Welcome message section[/+]on May 30, 2023
changed the title [-][$1000] Android - Room details - Welcome message can be inputted only from the middle of Welcome message section[/-][+][HOLD for payment 2023-06-13] [$1000] Android - Room details - Welcome message can be inputted only from the middle of Welcome message section[/+]on Jun 6, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-13. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Link to discussion: N/A , I think there is nothing we can add to the current checklist. @trjExpensify Let me know if we should start a discussion for that.
Determine if we should create a regression test for this bug. ❌
This bug was introduced while implementing a new feature. I believe this issue should have been identified earlier with the current checklist in place. Additionally, conducting tests with different scenarios would have been beneficial for catching such issues. There is no need for further regression testing at this point.
Activity
melvin-bot commentedon May 26, 2023
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 26, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)hungvu193 commentedon May 29, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Android - Room details - Welcome message can be inputted only from the middle of Welcome message section
What is the root cause of that problem?
We are using multilines TextInput for welcome message, but we didn't set the textAlignVertical for it yet, so when we clicked the input on Android, the cursor will be displayed at the center.
App/src/pages/ReportWelcomeMessagePage.js
Lines 75 to 79 in eaf3146
What changes do you think we should make in order to solve the problem?
We should add the
textAlignVertical: topprops to the TextInput to make sure the cursor will be at the top.What alternative solutions did you explore? (Optional)
N/A
Result
Screen.Recording.2023-05-29.at.15.55.00.mov
trjExpensify commentedon May 30, 2023
Yup, I can reproduce this on the Android simulator: https://github.com/Expensify/App/assets/16232057/109cc03f-709e-4b4f-929b-57b280fd4c7d
Going to move this along
external.CC: @pecanoro
[-]Android - Room details - Welcome message can be inputted only from the middle of Welcome message section[/-][+][$1000] Android - Room details - Welcome message can be inputted only from the middle of Welcome message section[/+]melvin-bot commentedon May 30, 2023
Job added to Upwork: https://www.upwork.com/jobs/~017d6b7a4c0773819c
melvin-bot commentedon May 30, 2023
Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.
14 remaining items
[-][$1000] Android - Room details - Welcome message can be inputted only from the middle of Welcome message section[/-][+][HOLD for payment 2023-06-13] [$1000] Android - Room details - Welcome message can be inputted only from the middle of Welcome message section[/+]melvin-bot commentedon Jun 6, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 6, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-13. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jun 6, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
fedirjh commentedon Jun 13, 2023
This bug was introduced while implementing a new feature. I believe this issue should have been identified earlier with the current checklist in place. Additionally, conducting tests with different scenarios would have been beneficial for catching such issues. There is no need for further regression testing at this point.
trjExpensify commentedon Jun 15, 2023
Sounds good! Offers here.
$1,500 - @fedirjh for C+
$1,500 - @hungvu193 for the bug fix
trjExpensify commentedon Jun 15, 2023
@fedirjh - paid!
hungvu193 commentedon Jun 16, 2023
I've accpeted the offer, Thank you @trjExpensify
trjExpensify commentedon Jun 16, 2023
@hungvu193 paid! All done here, closing. Thanks!