Skip to content

[HOLD for payment 2023-06-08][$1000] Dev: Console error on reload page in Connect bank account page #19757

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to Settings > Workspaces > Connect bank account
  2. Click on connect manually
  3. Reload the page

Expected Result:

It should not show any console error

Actual Result:

Shows console error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.18-1

Reproducible in staging?: No

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-25.at.3.19.24.PM.mov

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

**Slack conversation:**https://expensify.slack.com/archives/C049HHMV9SM/p1685008322770599

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0164470c9b3ebb6fd2
  • Upwork Job ID: 1664363385558638592
  • Last Price Increase: 2023-06-01

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 29, 2023
  2. melvin-bot commented on May 29, 2023

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 29, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. dhairyasenjaliya commented on May 29, 2023

    @dhairyasenjaliya
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    • Dev: Console error on reload page in Connect bank account page

    What is the root cause of that problem?

    • The root cause is we recently migrated CheckboxWithLabel component to use PressableWithFeedback on PressableWithFeedback we have not provided accessibilityLabel that’s causes the error as this should be mandatory as focusable is always true that required accessibilityLabel this error can be visible wherever we used CheckboxWithLabel

    What changes do you think we should make in order to solve the problem?

    • We need to add accessibilityLabel in order to remove the error log this is mandatory because by default focusable is true so we do need to provide accessibilityLabel

    • We can also add the optional accessibilityRole

    • We need to define a new accessibilityHints for CheckboxWithLabel which will be passed to accessibilityLabel message in both language 


    • If we don’t need accessibilityLabel inside CheckboxWithLabel then we can just pass accessible to false this will also remove the error

         <PressableWithFeedback
    +       accessibilityRole="button" // can be decide later 
    +       accessibilityLabel={'Custom message here'}
    

    Result

    Screenshot 2023-05-30 at 12 34 14 AM

    Without fix

    Screenshot 2023-05-30 at 12 34 49 AM
  5. sonialiap commented on Jun 1, 2023

    @sonialiap
    Contributor

    Has been reproduced, adding External

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on Jun 1, 2023
  7. changed the title [-]Dev: Console error on reload page in Connect bank account page[/-] [+][$1000] Dev: Console error on reload page in Connect bank account page[/+] on Jun 1, 2023
  8. melvin-bot commented on Jun 1, 2023

    @melvin-bot
  9. 9 remaining items

  10. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 2, 2023
  11. melvin-bot commented on Jun 2, 2023

    @melvin-bot

    📣 @dhairyasenjaliya You have been assigned to this job by @srikarparsi!
    Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  12. dhairyasenjaliya commented on Jun 5, 2023

    @dhairyasenjaliya
    Contributor

    @aimane-chnaif @srikarparsi PR ready for review

  13. aimane-chnaif commented on Jun 5, 2023

    @aimane-chnaif
    Contributor

    I just confirmed that this bug was recently fixed by #18792 where refactored CheckboxWithLabel component and deployed last Thursday.

  14. srikarparsi commented on Jun 5, 2023

    @srikarparsi
    Contributor

    Thanks for looking @aimane-chnaif! We'll close out the issue later today or tomorrow.

  15. aimane-chnaif commented on Jun 5, 2023

    @aimane-chnaif
    Contributor

    Btw it was valid bug, though fixed by another PR later.
    According to process doc 19-a, are we eligible for compensation or not? Fine either way, but just to confirm before closing.

  16. dhairyasenjaliya commented on Jun 5, 2023

    @dhairyasenjaliya
    Contributor

    agreed this was valid and unresolved at the time once it goes external

  17. sonialiap commented on Jun 7, 2023

    @sonialiap
    Contributor

    Hi all! Sorry about the delay. Since the proposal was selected, PR written, and was in the process of being reviewed - you should receive compensation for the work done. I'm off for the night but I will set up payments tomorrow

  18. changed the title [-][$1000] Dev: Console error on reload page in Connect bank account page[/-] [+][HOLD for payment 2023-06-08][$1000] Dev: Console error on reload page in Connect bank account page[/+] on Jun 7, 2023
  19. sonialiap commented on Jun 8, 2023

    @sonialiap
    Contributor

    @gadhiyamanan offer sent for reporting issue - paid
    @dhairyasenjaliya offer sent for the fix - paid
    @aimane-chnaif offer sent for the review - paid

  20. melvin-bot commented on Jun 15, 2023

    @melvin-bot

    @sonialiap, @dhairyasenjaliya, @srikarparsi, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

  21. sonialiap commented on Jun 16, 2023

    @sonialiap
    Contributor

    All paid, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions