You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-08][$1000] Dev: Console error on reload page in Connect bank account page #19757
Please re-state the problem that we are trying to solve in this issue.
Dev: Console error on reload page in Connect bank account page
What is the root cause of that problem?
The root cause is we recently migrated CheckboxWithLabel component to use PressableWithFeedback on PressableWithFeedback we have not provided accessibilityLabel that’s causes the error as this should be mandatory as focusable is always true that required accessibilityLabel this error can be visible wherever we used CheckboxWithLabel
What changes do you think we should make in order to solve the problem?
We need to add accessibilityLabel in order to remove the error log this is mandatory because by default focusable is true so we do need to provide accessibilityLabel
We can also add the optional accessibilityRole
We need to define a new accessibilityHints for CheckboxWithLabel which will be passed to accessibilityLabel message in both language
If we don’t need accessibilityLabel inside CheckboxWithLabel then we can just pass accessible to false this will also remove the error
<PressableWithFeedback
+ accessibilityRole="button" // can be decide later + accessibilityLabel={'Custom message here'}
changed the title [-]Dev: Console error on reload page in Connect bank account page[/-][+][$1000] Dev: Console error on reload page in Connect bank account page[/+]on Jun 1, 2023
📣 @dhairyasenjaliya You have been assigned to this job by @srikarparsi!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
Btw it was valid bug, though fixed by another PR later.
According to process doc 19-a, are we eligible for compensation or not? Fine either way, but just to confirm before closing.
Hi all! Sorry about the delay. Since the proposal was selected, PR written, and was in the process of being reviewed - you should receive compensation for the work done. I'm off for the night but I will set up payments tomorrow
changed the title [-][$1000] Dev: Console error on reload page in Connect bank account page[/-][+][HOLD for payment 2023-06-08][$1000] Dev: Console error on reload page in Connect bank account page[/+]on Jun 7, 2023
Activity
melvin-bot commentedon May 29, 2023
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 29, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)dhairyasenjaliya commentedon May 29, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
CheckboxWithLabelcomponent to usePressableWithFeedbackonPressableWithFeedbackwe have not providedaccessibilityLabelthat’s causes the error as this should be mandatory as focusable is always true that required accessibilityLabel this error can be visible wherever we usedCheckboxWithLabelWhat changes do you think we should make in order to solve the problem?
We need to add
accessibilityLabelin order to remove the error log this is mandatory because by default focusable is true so we do need to provideaccessibilityLabelWe can also add the optional
accessibilityRoleWe need to define a new
accessibilityHintsforCheckboxWithLabelwhich will be passed toaccessibilityLabelmessage in both languageIf we don’t need
accessibilityLabelinsideCheckboxWithLabelthen we can just passaccessibletofalsethis will also remove the errorResult
Without fix
sonialiap commentedon Jun 1, 2023
Has been reproduced, adding External
[-]Dev: Console error on reload page in Connect bank account page[/-][+][$1000] Dev: Console error on reload page in Connect bank account page[/+]melvin-bot commentedon Jun 1, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0164470c9b3ebb6fd2
9 remaining items
melvin-bot commentedon Jun 2, 2023
📣 @dhairyasenjaliya You have been assigned to this job by @srikarparsi!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
dhairyasenjaliya commentedon Jun 5, 2023
@aimane-chnaif @srikarparsi PR ready for review
aimane-chnaif commentedon Jun 5, 2023
I just confirmed that this bug was recently fixed by #18792 where refactored
CheckboxWithLabelcomponent and deployed last Thursday.srikarparsi commentedon Jun 5, 2023
Thanks for looking @aimane-chnaif! We'll close out the issue later today or tomorrow.
aimane-chnaif commentedon Jun 5, 2023
Btw it was valid bug, though fixed by another PR later.
According to process doc 19-a, are we eligible for compensation or not? Fine either way, but just to confirm before closing.
dhairyasenjaliya commentedon Jun 5, 2023
agreed this was valid and unresolved at the time once it goes external
sonialiap commentedon Jun 7, 2023
Hi all! Sorry about the delay. Since the proposal was selected, PR written, and was in the process of being reviewed - you should receive compensation for the work done. I'm off for the night but I will set up payments tomorrow
[-][$1000] Dev: Console error on reload page in Connect bank account page[/-][+][HOLD for payment 2023-06-08][$1000] Dev: Console error on reload page in Connect bank account page[/+]sonialiap commentedon Jun 8, 2023
@gadhiyamanan offer sent for reporting issue - paid
@dhairyasenjaliya offer sent for the fix - paid
@aimane-chnaif offer sent for the review - paid
melvin-bot commentedon Jun 15, 2023
@sonialiap, @dhairyasenjaliya, @srikarparsi, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!
sonialiap commentedon Jun 16, 2023
All paid, closing