You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-13] [$1000] Dev: Not able to run storybook #19777
Please re-state the problem that we are trying to solve in this issue.
Storybook not running on dev
What is the root cause of that problem?
The root cause of the issue is that this function returns undefined because the envFile parameter as supplied here, gets converted to '' when split by . as seen here.
What changes do you think we should make in order to solve the problem?
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-13. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@allroundexperts / @fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts / @fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts / @fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts / @fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger / @jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@sakluger I think the BZ is not required for this bug , we added CI check for storybook in this PR #19998 , so this issue won't pass the PR review. Let me know if we should fill the checklist.
Yeah, since we added automated tests, I agree we don't need to add other regression tests.
Maybe let's at least identify the PR that added the regression and make sure that it was tested properly? So basically do the first two checkboxes of the checklist.
Activity
melvin-bot commentedon May 29, 2023
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 29, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)allroundexperts commentedon May 29, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Storybook not running on dev
What is the root cause of that problem?
The root cause of the issue is that this function returns
undefinedbecause theenvFileparameter as supplied here, gets converted to''when split by.as seen here.What changes do you think we should make in order to solve the problem?
We just need to change this to:
What alternative solutions did you explore? (Optional)
None
sakluger commentedon May 30, 2023
I don't have a dev environment, but @neil-marcellini was able to reproduce. Marking as external.
sakluger commentedon May 30, 2023
Oh wait, this is a duplicate of #15042. Closing.
allroundexperts commentedon May 30, 2023
@sakluger I don't think that the two are related.
neil-marcellini commentedon May 31, 2023
Oh yeah this is different from #15042, where the problem is opening storybook on staging.
s77rt commentedon Jun 1, 2023
37 remaining items
melvin-bot commentedon Jun 6, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 6, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-13. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jun 6, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
fedirjh commentedon Jun 13, 2023
@sakluger I think the BZ is not required for this bug , we added CI check for storybook in this PR #19998 , so this issue won't pass the PR review. Let me know if we should fill the checklist.
jliexpensify commentedon Jun 14, 2023
Hi, I can pay this if Sasha is OOO. Looks like it was merged within a day so there's a bonus applicable.
@francoisl - is there any need to fill out the checklist?
francoisl commentedon Jun 14, 2023
Yeah, since we added automated tests, I agree we don't need to add other regression tests.
Maybe let's at least identify the PR that added the regression and make sure that it was tested properly? So basically do the first two checkboxes of the checklist.
fedirjh commentedon Jun 14, 2023
jliexpensify commentedon Jun 14, 2023
@robertKozik I can't seem to find you on Upworks, can you apply here for the $250 reporting bonus?
https://www.upwork.com/jobs/~01ba9220f901f5a917
jliexpensify commentedon Jun 14, 2023
@fedirjh and @allroundexperts - have paid you with bonus. Waiting on @robertKozik
robertKozik commentedon Jun 14, 2023
Hi! Im contributor from Software Mansion agency so I'm not eligible to payment 😄
jliexpensify commentedon Jun 14, 2023
Yeah that'd explain it, thanks Robert!
jliexpensify commentedon Jun 14, 2023
Job removed, closing!