Skip to content

[HOLD for payment 2023-06-21] [$1000] Avatar has no tooltip in thread report header #19825

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Create new room from any workspace (if not exist)
  2. Send any message in room chat
  3. Thread that message
  4. Hover avatar on thread report header or on LHN

Expected Result:

Tooltip shows with thread creator's avatar title

Actual Result:

No tooltip and Tooltip shows "fake" text in workspace chat thread header

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.20-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

241282990-6e9b9545-d5de-4093-9ef3-43d109d07f4c.mov
Recording.816.mp4

Expensify/Expensify Issue URL:
Issue reported by: @0xmiroslav
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685268118865469

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013f86178576b081ad
  • Upwork Job ID: 1665777714293276672
  • Last Price Increase: 2023-06-05

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 30, 2023
  2. melvin-bot commented on May 30, 2023

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 30, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. hoangzinh commented on May 30, 2023

    @hoangzinh
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Avatar has no tooltip in thread report header

    What is the root cause of that problem?

    There are 3 bugs:

    • Bug 1: Currently, we don't show tooltip when hover on top-left avatar when we're in a chatRoom.

      shouldShowTooltip={!isChatRoom}

      Unluckily, if we open a thread from a chatRoom, the threadReport also a chatRoom.

    • Bug 2: Tooltip shows "fake" text in WS Thread LHN
      When we create a thread from a WS chat, its chatRoom type will also a PolicyExpenseChat => leads to condition to show report subscript is true here => it will shows SubscriptAvatar instead of MultipleAvatars like other Threads. In SubscriptAvatar it will show report.ownerEmail in tooltip but for Thread it's always __fake__

    • Bug 3: Tooltip shows "fake" text in WS Thread report header
      Same root cause with 2nd bug above, in Report header view, we will render subscript avatar if it's a PolicyExpenseChat

    What changes do you think we should make in order to solve the problem?

    • Bug 1:
      We need to update condition here so that it still show tooltip if it's isChatRoom and isThread too.
    shouldShowTooltip={!(isChatRoom  && !isThread)}

    We need update this line with above logic too. So it will show tooltip when hover on avatar in LHN

    Result:
    Screenshot 2023-05-30 at 22 56 28

    • Bug 2:
      We should update condition here to also check it's not a Thread report

    • Bug 3:
      We should update condition here to include it's not a Thread report

    Result:
    Screenshot 2023-06-08 at 22 59 27

  5. 0xmiroslav commented on May 30, 2023

    @0xmiroslav
    Contributor

    This is a follow-up of #19551 and I am happy to take this as C+ since I already have full context while reviewing that PR.
    cc: @sakluger

  6. sakluger commented on Jun 1, 2023

    @sakluger
    Contributor

    I can't get fake to show up on hover, but it does just show nothing. We also show nothing though when hovering over the avatar for an #admins room. Asking in Slack to confirm that this is the intended behavior: https://expensify.slack.com/archives/C04QEB4MJEQ/p1685639994048869?thread_ts=1684920485.401849&cid=C04QEB4MJEQ

  7. sakluger commented on Jun 2, 2023

    @sakluger
    Contributor

    Reassigning BZ label since I'm OOO next week.

  8. removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 2, 2023
  9. removed their assignment
    on Jun 2, 2023
  10. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 2, 2023
  11. melvin-bot commented on Jun 2, 2023

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  12. deleted a comment from melvin-bot on Jun 4, 2023
  13. 36 remaining items

  14. puneetlath commented on Jun 12, 2023

    @puneetlath
    Contributor

    PR has been merged. Just waiting for deploy.

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 14, 2023
  16. changed the title [-][$1000] Avatar has no tooltip in thread report header[/-] [+][HOLD for payment 2023-06-21] [$1000] Avatar has no tooltip in thread report header[/+] on Jun 14, 2023
  17. melvin-bot commented on Jun 14, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  18. melvin-bot commented on Jun 14, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-06-21. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  19. melvin-bot commented on Jun 14, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
    • [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@0xmiroslav] Determine if we should create a regression test for this bug.
    • [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  20. puneetlath commented on Jun 22, 2023

    @puneetlath
    Contributor

    @hoangzinh @0xmiroslav sorry for the delay, I've sent offers.

    @0xmiroslav friendly bump on the checklist. I'll pay your contract once that's been completed. Thanks!

  21. 0xmiroslav commented on Jun 22, 2023

    @0xmiroslav
    Contributor

    No regressions. Tooltip in LHN & header of thread report was not considered when implement new thread feature in #18522.
    Full regression test will be added in #19264 (I am also C+ there) which refactors avatar and tooltip for all types of reports.

  22. puneetlath commented on Jun 23, 2023

    @puneetlath
    Contributor

    All paid. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions