You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-21] [$1000] Avatar has no tooltip in thread report header #19825
No tooltip and Tooltip shows "fake" text in workspace chat thread header
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.20-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Unluckily, if we open a thread from a chatRoom, the threadReport also a chatRoom.
Bug 2: Tooltip shows "fake" text in WS Thread LHN
When we create a thread from a WS chat, its chatRoom type will also a PolicyExpenseChat => leads to condition to show report subscript is true here => it will shows SubscriptAvatar instead of MultipleAvatars like other Threads. In SubscriptAvatar it will show report.ownerEmail in tooltip but for Thread it's always __fake__
Bug 3: Tooltip shows "fake" text in WS Thread report header
Same root cause with 2nd bug above, in Report header view, we will render subscript avatar if it's a PolicyExpenseChat
What changes do you think we should make in order to solve the problem?
Bug 1:
We need to update condition here so that it still show tooltip if it's isChatRoom and isThread too.
shouldShowTooltip={!(isChatRoom&&!isThread)}
We need update this line with above logic too. So it will show tooltip when hover on avatar in LHN
Result:
Bug 2:
We should update condition here to also check it's not a Thread report
Bug 3:
We should update condition here to include it's not a Thread report
changed the title [-][$1000] Avatar has no tooltip in thread report header[/-][+][HOLD for payment 2023-06-21] [$1000] Avatar has no tooltip in thread report header[/+]on Jun 14, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-21. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
[@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@0xmiroslav] Determine if we should create a regression test for this bug.
[@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
No regressions. Tooltip in LHN & header of thread report was not considered when implement new thread feature in #18522.
Full regression test will be added in #19264 (I am also C+ there) which refactors avatar and tooltip for all types of reports.
Activity
melvin-bot commentedon May 30, 2023
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 30, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)hoangzinh commentedon May 30, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Avatar has no tooltip in thread report header
What is the root cause of that problem?
There are 3 bugs:
Bug 1: Currently, we don't show tooltip when hover on top-left avatar when we're in a chatRoom.
App/src/pages/home/HeaderView.js
Line 162 in 16776ec
Unluckily, if we open a thread from a chatRoom, the threadReport also a chatRoom.
Bug 2: Tooltip shows "fake" text in WS Thread LHN
When we create a thread from a WS chat, its chatRoom type will also a PolicyExpenseChat => leads to condition to show report subscript is true here => it will shows SubscriptAvatar instead of MultipleAvatars like other Threads. In
SubscriptAvatarit will showreport.ownerEmailin tooltip but for Thread it's always__fake__Bug 3: Tooltip shows "fake" text in WS Thread report header
Same root cause with 2nd bug above, in Report header view, we will render subscript avatar if it's a PolicyExpenseChat
What changes do you think we should make in order to solve the problem?
We need to update condition here so that it still show tooltip if it's
isChatRoomandisThreadtoo.We need update this line with above logic too. So it will show tooltip when hover on avatar in LHN
Result:

Bug 2:
We should update condition here to also check it's not a Thread report
Bug 3:
We should update condition here to include it's not a Thread report
Result:

0xmiroslav commentedon May 30, 2023
This is a follow-up of #19551 and I am happy to take this as C+ since I already have full context while reviewing that PR.
cc: @sakluger
sakluger commentedon Jun 1, 2023
I can't get
faketo show up on hover, but it does just show nothing. We also show nothing though when hovering over the avatar for an#adminsroom. Asking in Slack to confirm that this is the intended behavior: https://expensify.slack.com/archives/C04QEB4MJEQ/p1685639994048869?thread_ts=1684920485.401849&cid=C04QEB4MJEQsakluger commentedon Jun 2, 2023
Reassigning BZ label since I'm OOO next week.
melvin-bot commentedon Jun 2, 2023
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.36 remaining items
puneetlath commentedon Jun 12, 2023
PR has been merged. Just waiting for deploy.
[-][$1000] Avatar has no tooltip in thread report header[/-][+][HOLD for payment 2023-06-21] [$1000] Avatar has no tooltip in thread report header[/+]melvin-bot commentedon Jun 14, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 14, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-21. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jun 14, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
puneetlath commentedon Jun 22, 2023
@hoangzinh @0xmiroslav sorry for the delay, I've sent offers.
@0xmiroslav friendly bump on the checklist. I'll pay your contract once that's been completed. Thanks!
0xmiroslav commentedon Jun 22, 2023
No regressions. Tooltip in LHN & header of thread report was not considered when implement new thread feature in #18522.
Full regression test will be added in #19264 (I am also C+ there) which refactors avatar and tooltip for all types of reports.
puneetlath commentedon Jun 23, 2023
All paid. Thanks everyone!