You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Login - Infinity loading is displayed for open deep link on Desktop App #19860
In older versions, when we render the redirection screen, isRootMounted is true, and the splash screen can be automatically removed by the setInterval.
However, this logic has been deleted in the PR #17477. The splash screen can only deleted by NavigationRoot. If we still render the redirection screen (PR #19125), NavigationRoot does not exist, then users will get stuck on the splash screen.
FYI: Because PR #19819 will fundamentally fix the issue #17724 (the root causes of #19214 and #17724 are the same), I don't think we need to render the redirection screen for the verification route, then this issue will naturally go away. : )
Looks like something related to react-navigation may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.
Activity
melvin-bot commentedon May 30, 2023
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 30, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)ntdiary commentedon May 31, 2023
This seems similar to what I reported in Slack, and I also gave the RCA of this issue in its thread and another comment.
RCA:
App/web/splash/splash.js
Lines 27 to 38 in eb9df25
In older versions, when we render the redirection screen,
isRootMountedis true, and the splash screen can be automatically removed by thesetInterval.However, this logic has been deleted in the PR #17477. The splash screen can only deleted by
NavigationRoot. If we still render the redirection screen (PR #19125),NavigationRootdoes not exist, then users will get stuck on the splash screen.FYI: Because PR #19819 will fundamentally fix the issue #17724 (the root causes of #19214 and #17724 are the same), I don't think we need to render the redirection screen for the verification route, then this issue will naturally go away. : )
melvin-bot commentedon May 31, 2023
Looks like something related to
react-navigationmay have been mentioned in this issue discussion.As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our
DeprecatedCustomActions.jsfiles should not be accepted.Feel free to drop a note in #expensify-open-source with any questions.
Christinadobrzyn commentedon May 31, 2023
Might be related to - #19047 - asking
roryabraham commentedon Jun 1, 2023
@Christinadobrzyn this appears unrelated to #19047
Christinadobrzyn commentedon Jun 1, 2023
Hey @kbecciv I'm not able to reproduce this. Can you doublecheck this is still happening and update the steps in the Op so I can reproduce?
After I do the following steps at https://staging.new.expensify.com/
I get this password screen in the Desktop app
Christinadobrzyn commentedon Jun 1, 2023
This is fixed - https://expensify.slack.com/archives/C9YU7BX5M/p1685642660059359
Closing