Skip to content

[HOLD for payment 2023-06-21] [$1000] Login - "Magic code sent" below email field after go back from code input page offline #19867

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open https://staging.new.expensify.com/
  2. Input email into email field
  3. Tap "Continue"
  4. Disable the internet connection
  5. Click "Didn't receive a magic code?"
  6. Click "Go back"
  7. Enable the internet connection

Expected Result:

No messages appear in email input screen after going back online

Actual Result:

A message "Magic code sent!" appears below the email input field after going back online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Safari
  • MacOS / Desktop

Version Number: 1.3.20-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/3d4252eff76baa6e91d6bee9290541864472ccb83d454db8509a2e5b6d7b07a8

https://platform.applause.com/services/links/v1/external/fc6da469ebfd90d76b6b239a7f2a9b7c235e9e50e2d12c1a85ecaa3245110f37

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a43ea4a6751f6484
  • Upwork Job ID: 1664315741336629248
  • Last Price Increase: 2023-06-01

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 30, 2023
  2. melvin-bot commented on May 30, 2023

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 30, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. hungvu193 commented on May 31, 2023

    @hungvu193
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Login - "Magic code sent" below email field after go back from code input page offline

    What is the root cause of that problem?

    We allowed to resend the magic code when it was offline, so after user pressed resend magic code and pressed back, later when user was back online, the data from server will fill the account data, which has the message inside.

    {!_.isEmpty(this.props.closeAccount.success || this.props.account.message) && (
    // DotIndicatorMessage mostly expects onyxData errors, so we need to mock an object so that the messages looks similar to prop.account.errors
    <DotIndicatorMessage
    style={[styles.mv2]}
    type="success"
    messages={{0: this.props.closeAccount.success || this.props.account.message}}
    />

    What changes do you think we should make in order to solve the problem?

    Since we disabled the Signin button when it's offline, it'd better to disable the Didn't receive a magic code? button when it's offline. We should also update its opacity to 50% to match the design.

     const disableStyles = this.props.network.isOffline ? styles.opacity50 : {}
        <PressableWithFeedback
            style={[styles.mt2, disableStyles]}
            onPress={this.resendValidateCode}
            underlayColor={themeColors.componentBG}
            hoverDimmingValue={1}
            pressDimmingValue={0.2}
       
            disabled={this.props.network.isOffline}
            accessibilityRole="button"
            accessibilityLabel={this.props.translate('validateCodeForm.magicCodeNotReceived')}
        >
            <Text style={[styles.link]}>{this.props.translate('validateCodeForm.magicCodeNotReceived')}</Text>
        </PressableWithFeedback>

    What alternative solutions did you explore? (Optional)

    N/A

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 1, 2023
  6. changed the title [-]Login - "Magic code sent" below email field after go back from code input page offline[/-] [+][$1000] Login - "Magic code sent" below email field after go back from code input page offline[/+] on Jun 1, 2023
  7. melvin-bot commented on Jun 1, 2023

    @melvin-bot
  8. melvin-bot commented on Jun 1, 2023

    @melvin-bot

    Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

  9. melvin-bot commented on Jun 1, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 1, 2023
  11. melvin-bot commented on Jun 1, 2023

    @melvin-bot

    Triggered auto assignment to @pecanoro (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  12. 30 remaining items

  13. melvin-bot commented on Jun 14, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jun 14, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-06-21. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue - sent to @hungvu193
    • Contributor+ that helped on the issue and/or PR - sent to @sobitneupane

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  15. melvin-bot commented on Jun 14, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
    • [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@sobitneupane] Determine if we should create a regression test for this bug.
    • [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sakluger / @trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. deleted a comment from melvin-bot on Jun 16, 2023
  17. sakluger commented on Jun 16, 2023

    @sakluger
    Contributor

    Thanks for the fast work! This one qualifies for the efficiency bonus. As soon as the 7-day hold is over and the BZ checklist is complete, I can pay out and close.

  18. sakluger commented on Jun 21, 2023

    @sakluger
    Contributor

    Hey @sobitneupane mind finishing the BZ checklist so I can complete payment? Thanks!

  19. added and removed on Jun 21, 2023
  20. sakluger commented on Jun 23, 2023

    @sakluger
    Contributor
  21. sobitneupane commented on Jun 23, 2023

    @sobitneupane
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

    #13655

    • [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    #13655 (comment)

    • [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    https://expensify.slack.com/archives/C049HHMV9SM/p1687539235356429

    • [@sobitneupane] Determine if we should create a regression test for this bug.

    I don't think we need a separate regression test here.

  22. sakluger commented on Jun 23, 2023

    @sakluger
    Contributor

    Thanks! We're all good here 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions