You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-21] [$1000] Login - "Magic code sent" below email field after go back from code input page offline #19867
Please re-state the problem that we are trying to solve in this issue.
Login - "Magic code sent" below email field after go back from code input page offline
What is the root cause of that problem?
We allowed to resend the magic code when it was offline, so after user pressed resend magic code and pressed back, later when user was back online, the data from server will fill the account data, which has the message inside.
What changes do you think we should make in order to solve the problem?
Since we disabled the Signin button when it's offline, it'd better to disable the Didn't receive a magic code? button when it's offline. We should also update its opacity to 50% to match the design.
changed the title [-]Login - "Magic code sent" below email field after go back from code input page offline[/-][+][$1000] Login - "Magic code sent" below email field after go back from code input page offline[/+]on Jun 1, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-21. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue - sent to @hungvu193
Contributor+ that helped on the issue and/or PR - sent to @sobitneupane
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sobitneupane] Determine if we should create a regression test for this bug.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger / @trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Thanks for the fast work! This one qualifies for the efficiency bonus. As soon as the 7-day hold is over and the BZ checklist is complete, I can pay out and close.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Activity
melvin-bot commentedon May 30, 2023
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 30, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)hungvu193 commentedon May 31, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Login - "Magic code sent" below email field after go back from code input page offline
What is the root cause of that problem?
We allowed to resend the magic code when it was offline, so after user pressed resend magic code and pressed back, later when user was back online, the data from server will fill the account data, which has the message inside.
App/src/pages/signin/LoginForm.js
Lines 196 to 202 in 31740a1
What changes do you think we should make in order to solve the problem?
Since we disabled the Signin button when it's offline, it'd better to disable the
Didn't receive a magic code?button when it's offline. We should also update its opacity to 50% to match the design.What alternative solutions did you explore? (Optional)
N/A
[-]Login - "Magic code sent" below email field after go back from code input page offline[/-][+][$1000] Login - "Magic code sent" below email field after go back from code input page offline[/+]melvin-bot commentedon Jun 1, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01a43ea4a6751f6484
melvin-bot commentedon Jun 1, 2023
Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Jun 1, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)melvin-bot commentedon Jun 1, 2023
Triggered auto assignment to @pecanoro (
External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.30 remaining items
melvin-bot commentedon Jun 14, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 14, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-21. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporterAs a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jun 14, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
sakluger commentedon Jun 16, 2023
Thanks for the fast work! This one qualifies for the efficiency bonus. As soon as the 7-day hold is over and the BZ checklist is complete, I can pay out and close.
sakluger commentedon Jun 21, 2023
Hey @sobitneupane mind finishing the BZ checklist so I can complete payment? Thanks!
sakluger commentedon Jun 23, 2023
Bump @sobitneupane
sobitneupane commentedon Jun 23, 2023
#13655
#13655 (comment)
https://expensify.slack.com/archives/C049HHMV9SM/p1687539235356429
I don't think we need a separate regression test here.
sakluger commentedon Jun 23, 2023
Thanks! We're all good here 👍