You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-07] [$1000] Line does not break in 'Description' of Request money #19872
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.20-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
📣 @easeplan! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
I guess it the line didn't break because the individual didn't add whitespace between the text. HTML just took it as one. Add a proper description with whitespace, it should work.
📣 @Oluwaniphise! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
I guess it the line didn't break because the individual didn't add whitespace between the text. HTML just took it as one. Add a proper description with whitespace, it should work.
I don't think that is the case. You can add as many whitespaces as you want but the line is not breaking.
BZ Checklist:
This is new feature rather than bug. Multiline description was not supported initially.
ah... I missed that. We def need new regression tests for new features, otherwise we'll never be able to check/test them going forward. Can you propose steps so I can create a TestRail GH @aimane-chnaif ? Thx
Activity
melvin-bot commentedon May 31, 2023
Triggered auto assignment to @tjferriss (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 31, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)therealsujitk commentedon May 31, 2023
@akinwale if I'm not mistaken you're working on a similar issue?
ahmedGaber93 commentedon May 31, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Line does not break in 'Description' of Request money.
What is the root cause of that problem?
The description input is not multiline input.
App/src/pages/iou/MoneyRequestDescriptionPage.js
Lines 80 to 86 in 2157057
What changes do you think we should make in order to solve the problem?
Make the description input multiline by add the following props
Result
Screen.Recording.2023-06-05.at.9.59.46.PM.mov
Support multiline in
MenuItemprop types and default props.
use styles.pre in
titleTextStyleonly if numberOfLines 1props.numberOfLines === 1 && styles.preApp/src/components/MenuItem.js
Line 83 in 9ed4a16
change title
numberOfLinesto benumberOfLines={props.numberOfLines}App/src/components/MenuItem.js
Line 193 in 9ed4a16
What alternative solutions did you explore? (Optional)
we can instead use
autoGrowHeightprop with style maxHeight.Result
Screen.Recording.2023-06-05.at.10.12.34.PM.mov
Alternative support multiline in
MenuItemprop types and default props.
use styles.pre in
titleTextStyleonly if multiline false!props.multiline && styles.preApp/src/components/MenuItem.js
Line 83 in 9ed4a16
change title
numberOfLinesto benumberOfLines={props.multiline ? undefined : 1}App/src/components/MenuItem.js
Line 193 in 9ed4a16
akinwale commentedon May 31, 2023
@therealsujitk Yes, that is correct, but it's for a different area of the app, task descriptions.
melvin-bot commentedon May 31, 2023
📣 @easeplan! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
habasefa commentedon May 31, 2023
Contributor details
Your Expensify account email: nazrihabtish@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0130c45e8d1f512bf8
melvin-bot commentedon May 31, 2023
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
Oluwaniphise commentedon May 31, 2023
I guess it the line didn't break because the individual didn't add whitespace between the text. HTML just took it as one. Add a proper description with whitespace, it should work.
melvin-bot commentedon May 31, 2023
📣 @Oluwaniphise! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
Oluwaniphise commentedon May 31, 2023
Your Expensify account email: oduyaleenoch@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0170f6bd3ff8e0835d
habasefa commentedon May 31, 2023
I don't think that is the case. You can add as many whitespaces as you want but the line is not breaking.
79 remaining items
habasefa commentedon Sep 7, 2023
@tjferriss a kind reminder for payment
aimane-chnaif commentedon Sep 7, 2023
BZ Checklist:
This is new feature rather than bug. Multiline description was not supported initially.
Timeline analysis:
habasefa commentedon Sep 7, 2023
@aimane-chnaif I don't understand. What do you mean it is a new feature? Does that mean there is no bonus for the reporter?
habasefa commentedon Sep 11, 2023
@kavimuru @tjferriss It has been 4 days since the deadline for payment.
tjferriss commentedon Sep 12, 2023
@Habtamu-Asefa sorry for the delay. Can you please apply to the job on Upworks? Job posting: https://www.upwork.com/jobs/~011291928fb10896b6
habasefa commentedon Sep 13, 2023
@tjferriss Thanks for the response. I have sent a proposal to the link you gave.
habasefa commentedon Sep 15, 2023
@tjferriss checking on the status of my payment
habasefa commentedon Sep 18, 2023
@tjferriss Nine days since the payment deadline. I look forward to no further delay.
mallenexpensify commentedon Sep 19, 2023
Hired! @Habtamu-Asefa , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~011291928fb10896b6
mallenexpensify commentedon Sep 19, 2023
I applied the 50% bonus based on @aimane-chnaif 's timeline above
Issue reporter: @Habtamu-Asefa paid $250 via Upwork
Contributor: @ahmedGaber93 paid $1500 via Upwork
Contributor+: @aimane-chnaif paid $1500 via Upwork
@aimane-chnaif can you please complete the BZ checklist above?
aimane-chnaif commentedon Sep 19, 2023
@mallenexpensify I also mentioned BZ checklist in #19872 (comment). So I think all items can be checked off.
mallenexpensify commentedon Sep 19, 2023
ah... I missed that. We def need new regression tests for new features, otherwise we'll never be able to check/test them going forward. Can you propose steps so I can create a TestRail GH @aimane-chnaif ? Thx
aimane-chnaif commentedon Sep 19, 2023
Regression Test Proposal
mallenexpensify commentedon Sep 21, 2023
Thanks @aimane-chnaif , closing!