Skip to content

[HOLD for payment 2023-09-07] [$1000] Line does not break in 'Description' of Request money #19872

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any chat
  2. Go to request money
  3. On description write something long

Expected Result:

The line should break to a new line at some point

Actual Result:

There is no line break

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.20-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.5.webm
Recording.820.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Habtamu-Asefa
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685338853319439

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010bfd86b76bb12ca6
  • Upwork Job ID: 1665796276188585984
  • Last Price Increase: 2023-06-19

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 31, 2023
  2. melvin-bot commented on May 31, 2023

    @melvin-bot

    Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 31, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. therealsujitk commented on May 31, 2023

    @therealsujitk
    Contributor

    @akinwale if I'm not mistaken you're working on a similar issue?

  5. ahmedGaber93 commented on May 31, 2023

    @ahmedGaber93
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Line does not break in 'Description' of Request money.

    What is the root cause of that problem?

    The description input is not multiline input.

    <TextInput
    inputID="moneyRequestComment"
    name="moneyRequestComment"
    defaultValue={this.props.iou.comment}
    label={this.props.translate('moneyRequestConfirmationList.whatsItFor')}
    ref={(el) => (this.descriptionInputRef = el)}
    />

    What changes do you think we should make in order to solve the problem?

    Make the description input multiline by add the following props

        multiline
        textAlignVertical="top"
        numberOfLines={6} // or 10
    Result
    Screen.Recording.2023-06-05.at.9.59.46.PM.mov

    Support multiline in MenuItem

    prop types and default props.

    /** Number of lines for the title */
    numberOfLines: PropTypes.number,
    
    // defaultProps
    numberOfLines: 1,

    use styles.pre in titleTextStyle only if numberOfLines 1 props.numberOfLines === 1 && styles.pre

    styles.pre,

    change title numberOfLines to be numberOfLines={props.numberOfLines}

    numberOfLines={1}

    What alternative solutions did you explore? (Optional)

    we can instead use autoGrowHeight prop with style maxHeight.

       autoGrowHeight
       containerStyles={[styles.moneyRequestDescriptionInput]} 
       // styles.moneyRequestDescriptionInput = {maxHeight: 115} 
    Result
    Screen.Recording.2023-06-05.at.10.12.34.PM.mov

    Alternative support multiline in MenuItem

    prop types and default props.

    /** Boolean whether to display the title in multiline */
    multiline: PropTypes.bool,
    
    // defaultProps
    multiline: false,

    use styles.pre in titleTextStyle only if multiline false !props.multiline && styles.pre

    styles.pre,

    change title numberOfLines to be numberOfLines={props.multiline ? undefined : 1}

    numberOfLines={1}

  6. akinwale commented on May 31, 2023

    @akinwale
    Contributor

    @akinwale if I'm not mistaken you're working on a similar issue?

    @therealsujitk Yes, that is correct, but it's for a different area of the app, task descriptions.

  7. melvin-bot commented on May 31, 2023

    @melvin-bot

    📣 @easeplan! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  8. habasefa commented on May 31, 2023

    @habasefa

    Contributor details
    Your Expensify account email: nazrihabtish@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~0130c45e8d1f512bf8

  9. melvin-bot commented on May 31, 2023

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  10. Oluwaniphise commented on May 31, 2023

    @Oluwaniphise

    I guess it the line didn't break because the individual didn't add whitespace between the text. HTML just took it as one. Add a proper description with whitespace, it should work.

  11. melvin-bot commented on May 31, 2023

    @melvin-bot

    📣 @Oluwaniphise! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  12. Oluwaniphise commented on May 31, 2023

    @Oluwaniphise

    Your Expensify account email: oduyaleenoch@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~0170f6bd3ff8e0835d

  13. habasefa commented on May 31, 2023

    @habasefa

    I guess it the line didn't break because the individual didn't add whitespace between the text. HTML just took it as one. Add a proper description with whitespace, it should work.

    I don't think that is the case. You can add as many whitespaces as you want but the line is not breaking.

  14. 79 remaining items

  15. habasefa commented on Sep 7, 2023

    @habasefa

    @tjferriss a kind reminder for payment

  16. aimane-chnaif commented on Sep 7, 2023

    @aimane-chnaif
    Contributor

    BZ Checklist:
    This is new feature rather than bug. Multiline description was not supported initially.

    Timeline analysis:

    • Contributor assigned: 2023-06-27 12:42, but hold for other related PRs
    • Hold was removed: 2023-08-24 16:25 (I think this can be actual start time to clock)
    • PR merged: 2023-08-28 17:38
    • Aug 26, 27: weekend
  17. habasefa commented on Sep 7, 2023

    @habasefa

    @aimane-chnaif I don't understand. What do you mean it is a new feature? Does that mean there is no bonus for the reporter?

  18. habasefa commented on Sep 11, 2023

    @habasefa

    @kavimuru @tjferriss It has been 4 days since the deadline for payment.

  19. tjferriss commented on Sep 12, 2023

    @tjferriss
    Contributor

    @Habtamu-Asefa sorry for the delay. Can you please apply to the job on Upworks? Job posting: https://www.upwork.com/jobs/~011291928fb10896b6

  20. habasefa commented on Sep 13, 2023

    @habasefa

    @tjferriss Thanks for the response. I have sent a proposal to the link you gave.

  21. habasefa commented on Sep 15, 2023

    @habasefa

    @tjferriss checking on the status of my payment

  22. habasefa commented on Sep 18, 2023

    @habasefa

    @tjferriss Nine days since the payment deadline. I look forward to no further delay.

  23. mallenexpensify commented on Sep 19, 2023

    @mallenexpensify
    Contributor

    Hired! @Habtamu-Asefa , can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~011291928fb10896b6

  24. mallenexpensify commented on Sep 19, 2023

    @mallenexpensify
    Contributor

    I applied the 50% bonus based on @aimane-chnaif 's timeline above

    Issue reporter: @Habtamu-Asefa paid $250 via Upwork
    Contributor: @ahmedGaber93 paid $1500 via Upwork
    Contributor+: @aimane-chnaif paid $1500 via Upwork

    @aimane-chnaif can you please complete the BZ checklist above?

  25. aimane-chnaif commented on Sep 19, 2023

    @aimane-chnaif
    Contributor

    @mallenexpensify I also mentioned BZ checklist in #19872 (comment). So I think all items can be checked off.

  26. mallenexpensify commented on Sep 19, 2023

    @mallenexpensify
    Contributor

    BZ Checklist:
    This is new feature rather than bug. Multiline description was not supported initially.

    ah... I missed that. We def need new regression tests for new features, otherwise we'll never be able to check/test them going forward. Can you propose steps so I can create a TestRail GH @aimane-chnaif ? Thx

  27. aimane-chnaif commented on Sep 19, 2023

    @aimane-chnaif
    Contributor

    Regression Test Proposal

    1. Open FAB > Request money
    2. Select Manual tab, enter any amount and click Next
    3. Select any participant
    4. Click on Description field
    5. Type any words
    6. Press Shift + Enter
    7. Verify that cursor is moved to next line
    8. Type any words
    9. Verify that input text is now multiline
  28. mallenexpensify commented on Sep 21, 2023

    @mallenexpensify
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions