[$1000] Welcome message modal doest not have back button

@ayazhussain79

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

1.Go to the chat
2.Send a message to user
3.Click on "Reply in thread"
4.Click on thread header > Settings > Welcome message

Expected Result:

Welcome message modal/popup should have back button

Actual Result:

Welcome message modal doest not have back button

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.21-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

20230529010305.mp4

az_recorder_20230531_142218.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685304337659739

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01dabd1979b66a6a86
Upwork Job ID: 1664671847386869760
Last Price Increase: 2023-06-02

@adelekennedy

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

In this issue, we can notice that on the Set a welcome message page, the back button is not present in the header.

What is the root cause of that problem?

To display the back button, we use the shouldShowBackButton prop in HeaderWithCloseButton. In the ReportWelcomeMessagePage, this prop is not used, causing the back button to not show up.

What changes do you think we should make in order to solve the problem?

To fix this issue, we need to pass the prop shouldShowBackButton to the HeaderWithCloseButton in ReportWelcomeMessagePage.

What alternative solutions did you explore? (Optional)

None

Proposal

Please re-state the problem that we are trying to solve in this issue.

Welcome message modal doest not have back button.

What is the root cause of that problem?

The HeaderWithCloseButton in ReportWelcomeMessagePage.js doesn't have prop shouldShowBackButton to show the back button.

App/src/pages/ReportWelcomeMessagePage.js

Lines 60 to 64 in 12d2f3c

    
           <HeaderWithCloseButton 
        
               title={props.translate('welcomeMessagePage.welcomeMessage')} 
        
               onBackButtonPress={() => Navigation.goBack()} 
        
               onCloseButtonPress={() => Navigation.dismissModal()} 
        
           />

What changes do you think we should make in order to solve the problem?

add prop shouldShowBackButton to HeaderWithCloseButton here

What alternative solutions did you explore? (Optional)

Is this up for grabs?

@GItGudRatio

📣 @GItGudRatio! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Proposal

Please re-state the problem that we are trying to solve in this issue.

Welcome message modal doest not have back button

What is the root cause of that problem?

App/src/pages/ReportWelcomeMessagePage.js

Lines 60 to 64 in 414dc10

    
           <HeaderWithCloseButton 
        
               title={props.translate('welcomeMessagePage.welcomeMessage')} 
        
               onBackButtonPress={() => Navigation.goBack()} 
        
               onCloseButtonPress={() => Navigation.dismissModal()} 
        
           />

in ReportWelcomeMessagePage we don't add shouldShowBackButton props to display Back button

What changes do you think we should make in order to solve the problem?

Adding shouldShowBackButton props in ReportWelcomeMessagePage

<HeaderWithCloseButton
                    title={props.translate('welcomeMessagePage.welcomeMessage')}
                    onBackButtonPress={() => Navigation.goBack()}
                    onCloseButtonPress={() => Navigation.dismissModal()}
                    shouldShowBackButton
  />

Result

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

can reproduce! this is a clear bug

@roryabraham

@roryabraham @parasharrajat This PR was just merged yesterday, which ended up fixing this issue. How should we proceed now?

@adelekennedy

I see. @adelekennedy What is the next step here? There is no PR required now.

@Prince-Mendiratta

I think we should pay out @Prince-Mendiratta for their time and then close this out since it's not going to be needed anymore.

@parasharrajat

@parasharrajat, @roryabraham, @Prince-Mendiratta, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Prince-Mendiratta

@Prince-Mendiratta just sent you an offer on Upwork!

@adelekennedy

@adelekennedy am i eligible for reporting bonus?

@ayazhussain79

@ayazhussain79 Sorry, the reporting bonus is only paid out when an issue is fixed, and this isn't fixed quite yet.

Payment requested as per https://expensify.slack.com/archives/C02NK2DQWUX/p1686903062857739

@adelekennedy

@adelekennedy Can you please summarize the appropriate individual payments for all parties involved in this issue? This is holding up @parasharrajat NewDot payments. More information on this compliance process in Slack.

@ayazhussain79

Here is the payment summary:

External issue reporter: @ayazhussain79 $250
Contributor that fixed the issue: @Prince-Mendiratta $1000
Contributor+ that helped on the issue and/or PR: @parasharrajat $1000
Upwork Job: https://www.upwork.com/jobs/~01dabd1979b66a6a86

Extra Notes regarding payment:
done! @JmillsExpensify

@adelekennedy

@adelekennedy offer accepted, Thank you

@adelekennedy

Quoting a comment @adelekennedy from #19903 (comment) for visibility.

Sorry, the reporting bonus is only paid out when an issue is fixed, and this isn't fixed quite yet.

what if a PR fixed this issue after i reported so why reporter is not eligible for reporting bonus

@parasharrajat

Reviewed details for @parasharrajat. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.

Navigation Menu

Repository navigation

[$1000] Welcome message modal doest not have back button #19903

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

15 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<HeaderWithCloseButton
	title={props.translate('welcomeMessagePage.welcomeMessage')}
	onBackButtonPress={() => Navigation.goBack()}
	onCloseButtonPress={() => Navigation.dismissModal()}
	/>

[$1000] Welcome message modal doest not have back button #19903

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on May 31, 2023

melvin-bot commented on May 31, 2023

Bug0 Triage Checklist (Main S/O)

Prince-Mendiratta commented on May 31, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

ahmedGaber93 commented on May 31, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

GItGudRatio commented on May 31, 2023

melvin-bot commented on May 31, 2023

melvin-bot commented on May 31, 2023

dukenv0307 commented on May 31, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

melvin-bot commented on May 31, 2023

adelekennedy commented on Jun 2, 2023

15 remaining items

Prince-Mendiratta commented on Jun 8, 2023

parasharrajat commented on Jun 8, 2023

roryabraham commented on Jun 8, 2023

melvin-bot commented on Jun 15, 2023

adelekennedy commented on Jun 16, 2023

ayazhussain79 commented on Jun 16, 2023

roryabraham commented on Jun 17, 2023

parasharrajat commented on Jul 24, 2023

JmillsExpensify commented on Jul 27, 2023

adelekennedy commented on Jul 28, 2023

ayazhussain79 commented on Jul 28, 2023

parasharrajat commented on Jul 28, 2023

ayazhussain79 commented on Jul 28, 2023

JmillsExpensify commented on Jul 29, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions