Repository navigation
[HOLD for payment 2023-07-14] [$1000] The workspace logo disappears if changed the workspace picture on combined user/workspace chat #19905
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to dev on web chrome
- Create a new workspace and invite a user
- Notice that on LHN, a combined workspace and user chat is created with both the user picture and the workspace picture
- Now try to change the workspace picture and notice that as soon as you change the workspace picture, the logo of the workspace that was present below in the LHN chat disappears. And if you remove the workspace picture, it reappears again
- Thus, it should have shown the updated picture on the LHN , instead of making it disappear
Expected Result:
The workspace logo should have been updated to the picture set on the LHN in the combined user/workspace chat instead of making it go disappear
Actual Result:
The workspace logo disappears if changed the workspace picture on combined user/workspace chat
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.21-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
chat-2023-05-29_11.26.13.mp4
Recording.825.mp4
Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685339400060349
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~018e5f5da305633aff
- Upwork Job ID: 1669420216317644800
- Last Price Increase: 2023-06-15
Activity
melvin-bot commentedon May 31, 2023
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 31, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)allroundexperts commentedon May 31, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace icon does not update in the workspace chat
What is the root cause of that problem?
The root cause of the issue is that we're not re-rendering the component once the
avatarproperty gets updated in thePolicyobject in theReportActionItemCreatedcomponent.What changes do you think we should make in order to solve the problem?
Firstly, we need to pass
policyIDprop intoReportActionItemCreatedcomponent here.Next, we'll need to load the
policyinto theReportActionItemCreatedcomponent as aprop. We need to add following here.This will re-render the component and call
const icons = ReportUtils.getIcons(props.report, props.personalDetails)function whenever the attachedpolicychanges ie any avatar is added / removed from it.We can optimise this approach further by just re-rendering when the avatar property of the attached policy changes.
What alternative solutions did you explore? (Optional)
None
strepanier03 commentedon Jun 1, 2023
This should be fixed with #19750 so I'm going to put it on hold until that is merged so we can test again to be sure.
[-]The workspace logo disappears if changed the workspace picture on combined user/workspace chat[/-][+][HOLD] The workspace logo disappears if changed the workspace picture on combined user/workspace chat[/+]strepanier03 commentedon Jun 13, 2023
PR has been deployed to Prod so I'm going to ask for someone to test again and then I'll action as necessary.
strepanier03 commentedon Jun 13, 2023
I don't have a dev environment so I asked here if someone could test for me.
strepanier03 commentedon Jun 13, 2023
Switching to Daily for now so I can remember to revisit this tomorrow.
75 remaining items
rushatgabhane commentedon Jul 23, 2023
Made a manual request on new dot https://staging.new.expensify.com/r/4385861037826843
tjferriss commentedon Jul 25, 2023
Easy, Melvin. We're just wrapping up payment.
parasharrajat commentedon Jul 26, 2023
Found a regression from this issue's PR #22467 (comment). I need some assistance determine the correct solution. https://github.com/Expensify/App/pull/21657/files#r1275373499
JmillsExpensify commentedon Jul 27, 2023
@tjferriss Can you please summarize the appropriate individual payments for all parties involved in this issue? This is holding up @rushatgabhane's NewDot payments. More information on this compliance process in Slack. This may also be affected based on the possible regression above.
tjferriss commentedon Jul 27, 2023
The payment comment has been updated: #19905 (comment)
parasharrajat commentedon Jul 27, 2023
@rushatgabhane Please respond to #19905 (comment) when you have time. Thanks.
JmillsExpensify commentedon Jul 27, 2023
Reviewed details for @rushatgabhane. This is accurate based on summary from Business Reviewer and approved for payment in NewDot.
melvin-bot commentedon Aug 1, 2023
@tjferriss, @NikkiWines, @rushatgabhane, @developerdavi Eep! 4 days overdue now. Issues have feelings too...
tjferriss commentedon Aug 1, 2023
@rushatgabhane bumping this comment once more #19905 (comment)
rushatgabhane commentedon Aug 1, 2023
@tjferriss i had responded to the in the PR https://github.com/Expensify/App/pull/21657/files#r1277398010
sorry for no updates on issue. we can close this i think