[HOLD for payment 2023-06-19] [$1000] IOS - Chat - Top of the emoji inside the inline block is cut off

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Start iOS App and login with any account
Open any chat
Post inline block with text and some emoji like ⁦Text Block Emoji-1 Emoji-2 Emoji-3 ...

Expected Result:

The content of the inline block is fully visible

Actual Result:

Top of the emoji inside the inline block is cut off

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1,3,21.1

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6075918_inline-block-emoji-cut-off.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b27ea19fc8522167
Upwork Job ID: 1664657301634904064
Last Price Increase: 2023-06-02

@flaviadefaria

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOS - Chat - Top of the emoji inside the inline block is cut off

What is the root cause of that problem?

Heights are small for inline code block elements

App/src/styles/codeStyles/index.ios.js

Lines 1 to 13 in fe67d69

    
           const codeWordWrapper = { 
        
               height: 20, 
        
               justifyContent: 'center', 
        
           }; 
        
           const codeWordStyle = { 
        
               height: 16, 
        
               top: 4, 
        
           }; 
        
           const codeTextStyle = { 
        
               lineHeight: 15, 
        
           };

What changes do you think we should make in order to solve the problem?

Adjust height, lineHeight properly

const codeWordWrapper = {
    height: 30,
};

const codeWordStyle = {
    height: 30,
    top: 4,
};

const codeTextStyle = {
    lineHeight: 30,
};

Result

What alternative solutions did you explore? (Optional)

N/A

Job added to Upwork: https://www.upwork.com/jobs/~01b27ea19fc8522167

@flaviadefaria

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

@s77rt

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@flodnv

Triggered auto assignment to @flodnv (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.26-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix cutoff emojis inside code blocks #20287

If no regressions arise, payment will be issued on 2023-06-19. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@s77rt

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

The PR that introduced the bug has been identified: fix inline code blocks #2527
The offending PR has been commented on: fix inline code blocks #2527 (comment) and fix inline code blocks #2527 (comment)
A discussion in #expensify-bugs has been started: https://expensify.slack.com/archives/C049HHMV9SM/p1686685325052589
Determine if we should create a regression test for this bug: No

@s77rt

@s77rt @s-alves10 Issuing payment for you both now for $1000 + $500 (bonus) each.

Offers sent!

Payment has been issued so closing this.

Navigation Menu

Repository navigation

[HOLD for payment 2023-06-19] [$1000] IOS - Chat - Top of the emoji inside the inline block is cut off #19922

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

What alternative solutions did you explore? (Optional)

29 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const codeWordWrapper = {
	height: 20,
	justifyContent: 'center',
	};

	const codeWordStyle = {
	height: 16,
	top: 4,
	};

	const codeTextStyle = {
	lineHeight: 15,
	};

[HOLD for payment 2023-06-19] [$1000] IOS - Chat - Top of the emoji inside the inline block is cut off #19922

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on May 31, 2023

melvin-bot commented on May 31, 2023

Bug0 Triage Checklist (Main S/O)

AlexanderDmitriev commented on Jun 1, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jun 2, 2023

melvin-bot commented on Jun 2, 2023

melvin-bot commented on Jun 2, 2023

melvin-bot commented on Jun 2, 2023

29 remaining items

melvin-bot commented on Jun 12, 2023

melvin-bot commented on Jun 12, 2023

melvin-bot commented on Jun 12, 2023

s77rt commented on Jun 13, 2023

flaviadefaria commented on Jun 21, 2023

flaviadefaria commented on Jun 21, 2023

flaviadefaria commented on Jun 21, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions