[HOLD for payment 2023-06-13] Assign Task - Task name disappears on logout and login again #19959

Activity

1. kbecciv

   added

   DailyKSv2KSv2

   BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.

   on Jun 1, 2023
2. melvin-bot

   assigned

   stephanieelliott

   on Jun 1, 2023
3. melvin-bot commented on Jun 1, 2023

   

   melvin-botBot

   on Jun 1, 2023

   More actions

   Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
4. melvin-bot commented on Jun 1, 2023

   

   melvin-botBot

   on Jun 1, 2023

   More actions

   Bug0 Triage Checklist (Main S/O)

   • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
   • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
     • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
   • This bug is reproducible using the reproduction steps in the OP. S/O
     • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
     • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
   • This issue is filled out as thoroughly and clearly as possible
     • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
   • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
5. c3024 commented on Jun 1, 2023

   

   c3024

   on Jun 1, 2023

   Contributor

   More actions

   Proposal

   Please restate the problem you are trying to solve

   Task title is not visible after assigning a task and signing in and signing out.

   What is the root cause of the problem?

   Correct property is not displayed for task title.
   Here,
   

   App/src/components/ReportActionItem/TaskPreview.js

   Line 59 in f4f89a0

   const taskTitle = props.action.taskTitle || props.taskReport.reportName;

   action.taskTitle does not contain the task title, instead action.childReportName has the actual task title.

   What changes do you think we should make in order to solve the problem?

   Change the line to

   const taskTitle = props.action.taskTitle ||  props.action.childReportName || props.taskReport.reportName;
   

   What alternative solutions did you explore?

   None.
6. thienlnam commented on Jun 1, 2023

   

   thienlnam

   on Jun 1, 2023

   Last edited by thienlnam

   Contributor

   More actions

   This is expected right now (due to some recent BE changes that were made), we're fixing this in #19089

   cc @kbecciv Just an FYI for any task name bugs like this
7. thienlnam

   closed this as completedon Jun 1, 2023
8. melvin-bot

   added

   WeeklyKSv2KSv2

   Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to production

   and removed

   DailyKSv2KSv2

   on Jun 6, 2023
9. melvin-bot

   changed the title [-]Assign Task - Task name disappears on logout and login again[/-] [+][HOLD for payment 2023-06-13] Assign Task - Task name disappears on logout and login again[/+] on Jun 6, 2023
10. melvin-bot commented on Jun 6, 2023

    

    melvin-botBot

    on Jun 6, 2023

    More actions

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    • Show assigned user as mention in the task preview #19990

    If no regressions arise, payment will be issued on 2023-06-13. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
11. melvin-bot commented on Jun 6, 2023

    

    melvin-botBot

    on Jun 6, 2023

    More actions

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [] The PR that introduced the bug has been identified. Link to the PR:
    • [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [] Determine if we should create a regression test for this bug.
    • [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
12. melvin-bot

    added

    ReviewingHas a PR in reviewHas a PR in review

    on Jun 28, 2023