[HOLD for payment 2023-06-21] [$1000] Message to change the primary login to email is not appearing if the 2/5 steps of bank account set up is completed

@dhanashree-sawant

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
Login with phone number user
Open any workspace
Open connect bank account and observe that it displays the message to change the primary login as a valid email
If not already added, add secondary email account
Make email account as default
Open workspace opened in step 3
Open connect bank account
Click on connect manually and fill in details in first 2 steps and quit in the step 3 (personal information page)
Again change default contact to phone number
Open connect bank account

Expected Result:

When primary login is phone number, app should display message to change the primary login on click of connect bank account

Actual Result:

When primary login is phone number and app has previous setup for connect bank account, app does not display the message to change the primary login

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.22
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.791.mp4

streamline.payment.page.is.displayed.when.contact.no.is.primary.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684855894250829

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01dbdf57ee5b67dd8a
Upwork Job ID: 1665807914510938112
Last Price Increase: 2023-06-05

@greg-schroeder

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error message to switch to email is shown at incorrect step when connecting a workspace bank account

What is the root cause of that problem?

The root cause of the issue is that we're rendering the error component AFTER the draft bank account state component. This can be seen here.

What changes do you think we should make in order to solve the problem?

We just need to move this to here.

What alternative solutions did you explore? (Optional)

None

Reviewing

This is a bit difficult to follow, confirming bug behavior in Slack

Okay so essentially what we're saying here is if your primary login is a phone number you shouldn’t be able to enter the connect bank account flow at all before adjusting to an email primary login, sure.

Job added to Upwork: https://www.upwork.com/jobs/~01dbdf57ee5b67dd8a

@greg-schroeder

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

Reviewing label has been removed, please complete the "BugZero Checklist".

@dhanashree-sawant

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: render error before continue bank account setup button #20406

If no regressions arise, payment will be issued on 2023-06-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter - @dhanashree-sawant
Contributor that fixed the issue - @allroundexperts
Contributor+ that helped on the issue and/or PR - @abdulrahuman5196

https://www.upwork.com/ab/applicants/1665807914510938112/job-details

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@allroundexperts

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@allroundexperts / @abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts / @abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts / @abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts / @abdulrahuman5196] Determine if we should create a regression test for this bug.
[@allroundexperts / @abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

BZ checklist

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression. This issue seems to present during the original ContinueStep implementation itself. We wouldn't have noticed it before secondary method implementation and it is also a very corner case.

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No. I don't think it would be beneficial to add regression test for this corner case.

@allroundexperts

Offers sent @allroundexperts @abdulrahuman5196 @dhanashree-sawant

@greg-schroeder

@greg-schroeder Accepted the offer.

Paid, checklist complete. Closing.

Navigation Menu

Repository navigation

[HOLD for payment 2023-06-21] [$1000] Message to change the primary login to email is not appearing if the 2/5 steps of bank account set up is completed #20072

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

14 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-06-21] [$1000] Message to change the primary login to email is not appearing if the 2/5 steps of bank account set up is completed #20072

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jun 2, 2023

melvin-bot commented on Jun 2, 2023

Bug0 Triage Checklist (Main S/O)

allroundexperts commented on Jun 3, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

greg-schroeder commented on Jun 5, 2023

greg-schroeder commented on Jun 5, 2023

greg-schroeder commented on Jun 5, 2023

melvin-bot commented on Jun 5, 2023

melvin-bot commented on Jun 5, 2023

14 remaining items

melvin-bot commented on Jun 14, 2023

melvin-bot commented on Jun 14, 2023

melvin-bot commented on Jun 14, 2023

abdulrahuman5196 commented on Jun 21, 2023

greg-schroeder commented on Jun 21, 2023

abdulrahuman5196 commented on Jun 21, 2023

greg-schroeder commented on Jun 22, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions