You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[CLOSED FOR PROPOSALS] Removes assignee on Edit task title #20234
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.24-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Please re-state the problem that we are trying to solve in this issue.
removes assignee on Edit task title
What is the root cause of that problem?
The root cause is when we edit task title we are passing title on editTaskAndNavigate and assignee parameter will remain empty at that time we should alway fallback on previous assign mail which on current code we are setting by report.assignee which is wrong as per this comment Complete Task Front End #18806 (comment) we should alway use report.managerEmail to get previous assignee as we use same for other flows as well
Currently we are setting from report.assignee which will never had any values that makes assignee empty
What changes do you think we should make in order to solve the problem?
On EditTask API we should usereport.managerEmail as fallBack for assignee data rather than report.assignee which I believe we removed that’s the reason it will never have any values
Now that #19990 has been deployed to prod, let's test this behavior again. @gadhiyamanan, would you mind testing the behavior to see if it persists in the new build?
Activity
melvin-bot commentedon Jun 6, 2023
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 6, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)dhairyasenjaliya commentedon Jun 6, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
The root cause is when we edit task title we are passing title on
editTaskAndNavigateandassigneeparameter will remain empty at that time we should alway fallback on previous assign mail which on current code we are setting byreport.assigneewhich is wrong as per this comment Complete Task Front End #18806 (comment) we should alway usereport.managerEmailto get previous assignee as we use same for other flows as wellCurrently we are setting from
report.assigneewhich will never had any values that makes assignee emptyWhat changes do you think we should make in order to solve the problem?
EditTaskAPI we should usereport.managerEmailas fallBack for assignee data rather thanreport.assigneewhich I believe we removed that’s the reason it will never have any values// Task.js API.write( 'EditTask', { taskReportID: report.reportID, title: reportName, description: description.trim(), - assignee: assignee || report.assignee, + assignee: assignee || report.managerEmail, editedTaskReportActionID: editTaskReportAction.reportActionID, assigneeChatReportActionID: optimisticAssigneeAddComment ? optimisticAssigneeAddComment.reportAction.reportActionID : 0, }, {optimisticData, successData, failureData}, );dukenv0307 commentedon Jun 6, 2023
This issue is fixed in this PR #19990
johncschuster commentedon Jun 8, 2023
I'm going to apply the
Externallabel so an Upwork job can be created for the Bug Report. No other proposals needed.[-]Removes assignee on Edit task title[/-][+][$1000] Removes assignee on Edit task title[/+]melvin-bot commentedon Jun 8, 2023
Job added to Upwork: https://www.upwork.com/jobs/~019ac6c7f678c21778
melvin-bot commentedon Jun 8, 2023
Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.
[-][$1000] Removes assignee on Edit task title[/-][+][CLOSED FOR PROPOSALS] Removes assignee on Edit task title[/+]melvin-bot commentedon Jun 8, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (
External)6 remaining items
johncschuster commentedon Jun 8, 2023
@gadhiyamanan I've sent you an invite for the bug report. Can you ping me when you've accepted that? Thanks!
gadhiyamanan commentedon Jun 9, 2023
@johncschuster accepted, thanks!
johncschuster commentedon Jun 9, 2023
Bug report payment has been issued! Thanks, @gadhiyamanan!
johncschuster commentedon Jun 10, 2023
Now that #19990 has been deployed to prod, let's test this behavior again. @gadhiyamanan, would you mind testing the behavior to see if it persists in the new build?
gadhiyamanan commentedon Jun 10, 2023
@johncschuster I think it's fixed.
Screen.Recording.2023-06-10.at.5.54.21.PM.mov
johncschuster commentedon Jun 12, 2023
Great! I'll keep an eye on the PR for a few more days and then close this manually. Thanks for checking, @gadhiyamanan!
johncschuster commentedon Jun 13, 2023
I'm gonna give this a couple more days (stay back, Melvin)
johncschuster commentedon Jun 14, 2023
Melvin likes bumps. bump.
johncschuster commentedon Jun 16, 2023
One more bump for Melvin. I think we'll be good to close this out on Monday.
melvin-bot commentedon Jun 19, 2023
@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!
johncschuster commentedon Jun 20, 2023
Ok! I think it's safe to close the issue. Thanks for your participation, everyone!