Skip to content

[CLOSED FOR PROPOSALS] Removes assignee on Edit task title #20234

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click + icon and select assign a task
  2. Enter title and assign it to a user
  3. Click Confirm Task
  4. edit task title

Expected Result:

should not remove assignee

Actual Result:

removes assignee on edit task title

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.24-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-02.at.3.53.13.PM.mov
Recording.890.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685701939045269

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019ac6c7f678c21778
  • Upwork Job ID: 1666888974330671104
  • Last Price Increase: 2023-06-08

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 6, 2023
  2. melvin-bot commented on Jun 6, 2023

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jun 6, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. dhairyasenjaliya commented on Jun 6, 2023

    @dhairyasenjaliya
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    • removes assignee on Edit task title

    What is the root cause of that problem?

    • The root cause is when we edit task title we are passing title on editTaskAndNavigate and assignee parameter will remain empty at that time we should alway fallback on previous assign mail which on current code we are setting by report.assignee which is wrong as per this comment Complete Task Front End  #18806 (comment) we should alway use report.managerEmail to get previous assignee as we use same for other flows as well

    • Currently we are setting from report.assignee which will never had any values that makes assignee empty

    What changes do you think we should make in order to solve the problem?

    • On EditTask API we should usereport.managerEmail as fallBack for assignee data rather than report.assignee which I believe we removed that’s the reason it will never have any values
    // Task.js
        API.write(
            'EditTask',
            {
                taskReportID: report.reportID,
                title: reportName,
                description: description.trim(),
    -            assignee: assignee || report.assignee,
    +            assignee: assignee || report.managerEmail,
                editedTaskReportActionID: editTaskReportAction.reportActionID,
                assigneeChatReportActionID: optimisticAssigneeAddComment ? optimisticAssigneeAddComment.reportAction.reportActionID : 0,
            },
            {optimisticData, successData, failureData},
        );
    
  5. dukenv0307 commented on Jun 6, 2023

    @dukenv0307
    Contributor

    This issue is fixed in this PR #19990

  6. johncschuster commented on Jun 8, 2023

    @johncschuster
    Contributor

    I'm going to apply the External label so an Upwork job can be created for the Bug Report. No other proposals needed.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 8, 2023
  8. changed the title [-]Removes assignee on Edit task title[/-] [+][$1000] Removes assignee on Edit task title[/+] on Jun 8, 2023
  9. melvin-bot commented on Jun 8, 2023

    @melvin-bot
  10. melvin-bot commented on Jun 8, 2023

    @melvin-bot

    Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

  11. changed the title [-][$1000] Removes assignee on Edit task title[/-] [+][CLOSED FOR PROPOSALS] Removes assignee on Edit task title[/+] on Jun 8, 2023
  12. melvin-bot commented on Jun 8, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

  13. 6 remaining items

  14. johncschuster commented on Jun 8, 2023

    @johncschuster
    Contributor

    @gadhiyamanan I've sent you an invite for the bug report. Can you ping me when you've accepted that? Thanks!

  15. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 8, 2023
  16. gadhiyamanan commented on Jun 9, 2023

    @gadhiyamanan
    Contributor

    @johncschuster accepted, thanks!

  17. johncschuster commented on Jun 9, 2023

    @johncschuster
    Contributor

    Bug report payment has been issued! Thanks, @gadhiyamanan!

  18. johncschuster commented on Jun 10, 2023

    @johncschuster
    Contributor

    Now that #19990 has been deployed to prod, let's test this behavior again. @gadhiyamanan, would you mind testing the behavior to see if it persists in the new build?

  19. gadhiyamanan commented on Jun 10, 2023

    @gadhiyamanan
    Contributor

    @johncschuster I think it's fixed.

    Screen.Recording.2023-06-10.at.5.54.21.PM.mov
  20. johncschuster commented on Jun 12, 2023

    @johncschuster
    Contributor

    Great! I'll keep an eye on the PR for a few more days and then close this manually. Thanks for checking, @gadhiyamanan!

  21. johncschuster commented on Jun 13, 2023

    @johncschuster
    Contributor

    I'm gonna give this a couple more days (stay back, Melvin)

  22. johncschuster commented on Jun 14, 2023

    @johncschuster
    Contributor

    Melvin likes bumps. bump.

  23. johncschuster commented on Jun 16, 2023

    @johncschuster
    Contributor

    One more bump for Melvin. I think we'll be good to close this out on Monday.

  24. melvin-bot commented on Jun 19, 2023

    @melvin-bot

    @johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

  25. johncschuster commented on Jun 20, 2023

    @johncschuster
    Contributor

    Ok! I think it's safe to close the issue. Thanks for your participation, everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions