You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1000] Closed accounts aren't removed from workspace members list #20264
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
but as this would notify all accounts within a workspace/room and because close account is such a rare action I'm not even sure we should fix this.
I disagree. Just because something is rare, does not mean we shouldn't fix it. Ideally, every case is polished, edge or not. If we think this does need to be Internal then we should make it that, and prioritise it accordingly. That sounds like what we'll do.
If you agree @Julesssss, let's just leave you assigned and make it a Monthly?
Activity
OSBotify commentedon Jun 6, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jun 6, 2023
Triggered auto assignment to @Julesssss (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Beamanator commentedon Jun 6, 2023
Hopinggggg this isn't due to my PR: https://github.com/Expensify/Web-Expensify/pull/37723
@Julesssss let me know if you want help investigating
Julesssss commentedon Jun 6, 2023
Regardless it doesn't seem like a blocker. Testing locally now.
Julesssss commentedon Jun 6, 2023
It seems very weird that this only occurs on Desktop staging:
@Beamanator I doubt your changes would lead to this Desktop only issue, right?
Beamanator commentedon Jun 6, 2023
Ooh ya I have no idea how mu changes would only cause this on desktop....
roryabraham commentedon Jun 6, 2023
I think the problem is that desktop deploys are broke
60 remaining items
melvin-bot commentedon Jul 4, 2023
@twisterdotcom @Julesssss @muttmuure @aimane-chnaif this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:
Thanks!
melvin-bot commentedon Jul 4, 2023
Current assignee @aimane-chnaif is eligible for the Internal assigner, not assigning anyone new.
twisterdotcom commentedon Jul 4, 2023
I disagree. Just because something is rare, does not mean we shouldn't fix it. Ideally, every case is polished, edge or not. If we think this does need to be
Internalthen we should make it that, and prioritise it accordingly. That sounds like what we'll do.If you agree @Julesssss, let's just leave you assigned and make it a
Monthly?Julesssss commentedon Jul 5, 2023
Sure, but it's probably going to just sit in my backlog for the rest of the year tbh.
mvtglobally commentedon Jul 6, 2023
Issue not reproducible during KI retests. (First week)
twisterdotcom commentedon Aug 7, 2023
If this is not reproducible, can we close?