Skip to content

[$1000] Closed accounts aren't removed from workspace members list #20264

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Invite new user (that doesn't have a NewDot account)
  2. Valifdate this user, then login with this new user account in ND in private mode
  3. Close this new user account
  4. Switch to Desktop App with admin account and check members list

Expected Result:

  1. Closed account was removed from the members list

Actual Result:

  1. Closed accounts are still displayed in the members list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.24.4

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Closed account

Bug6081613_ws-member-closed-account.mp4

Member's list

Bug6081613_ws-members-list.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0190db70a7a3eb2f5b
  • Upwork Job ID: 1672152459568193536
  • Last Price Increase: 2023-06-30

Activity

  1. OSBotify commented on Jun 6, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Jun 6, 2023

    @melvin-bot

    Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. Beamanator commented on Jun 6, 2023

    @Beamanator
    Contributor

    Hopinggggg this isn't due to my PR: https://github.com/Expensify/Web-Expensify/pull/37723

    @Julesssss let me know if you want help investigating

  4. Julesssss commented on Jun 6, 2023

    @Julesssss
    Contributor

    Regardless it doesn't seem like a blocker. Testing locally now.

  5. Julesssss commented on Jun 6, 2023

    @Julesssss
    Contributor

    It seems very weird that this only occurs on Desktop staging:

    • Desktop prod: ✅
    • Desktop staging: ❌ -- I can reproduce
    • Web staging: ✅
    • Web prod: ✅

    @Beamanator I doubt your changes would lead to this Desktop only issue, right?

  6. Beamanator commented on Jun 6, 2023

    @Beamanator
    Contributor

    Ooh ya I have no idea how mu changes would only cause this on desktop....

  7. roryabraham commented on Jun 6, 2023

    @roryabraham
    Contributor

    I think the problem is that desktop deploys are broke

  8. added
    ImprovementItem broken or needs improvement.
    and removed on Jun 6, 2023
  9. 60 remaining items

  10. melvin-bot commented on Jul 4, 2023

    @melvin-bot

    @twisterdotcom @Julesssss @muttmuure @aimane-chnaif this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

    • Decide whether any proposals currently meet our guidelines and can be approved as-is today
    • If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
    • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

    Thanks!

  11. added
    InternalRequires API changes or must be handled by Expensify staff
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 4, 2023
  12. melvin-bot commented on Jul 4, 2023

    @melvin-bot

    Current assignee @aimane-chnaif is eligible for the Internal assigner, not assigning anyone new.

  13. twisterdotcom commented on Jul 4, 2023

    @twisterdotcom
    Contributor

    but as this would notify all accounts within a workspace/room and because close account is such a rare action I'm not even sure we should fix this.

    I disagree. Just because something is rare, does not mean we shouldn't fix it. Ideally, every case is polished, edge or not. If we think this does need to be Internal then we should make it that, and prioritise it accordingly. That sounds like what we'll do.

    If you agree @Julesssss, let's just leave you assigned and make it a Monthly?

  14. Julesssss commented on Jul 5, 2023

    @Julesssss
    Contributor

    Sure, but it's probably going to just sit in my backlog for the rest of the year tbh.

  15. mvtglobally commented on Jul 6, 2023

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  16. twisterdotcom commented on Aug 7, 2023

    @twisterdotcom
    Contributor

    If this is not reproducible, can we close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffMonthlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions