Repository navigation
[HOLD for payment 2023-09-04] Selection List Refactor: Checkbox List #20353
Description
This issue keeps track of Phase 2 of the Selection List Refactor, in which we are refactoring all different list component variations into 3 new, clean components:
- Phase 1: Radio Button List
- Phase 2: Checkbox List (this phase)
- Phase 3: Simple Selection List
Thoroughly discussed in the parent issue: #11795 (comment)
Activity
cristipaval commentedon Jun 19, 2023
I guess @thiagobrez has not started on this one yet.
thiagobrez commentedon Jun 19, 2023
Correct @cristipaval. I'll send the PR for the first refactor tomorrow. Then I'll start on this one.
thiagobrez commentedon Jun 21, 2023
Starting to investigate this.
thiagobrez commentedon Jun 21, 2023
Hey @shawnborton! I need your input here. Regarding multiple selection lists: most of them use radio buttons, but there are also cases of checkboxes. I was planning to standardise and leave only the checkbox version, as I feel like it's more intuitive for multiple selection. Do you agree, or do you have new designs/thoughts here?
shawnborton commentedon Jun 21, 2023
Can you show me what you are referring to? I agree that we need to do a better job of making multiple selections look like checkboxes and single selections (though they don't really exist in the app yet) look like radios.
thiagobrez commentedon Jun 22, 2023
@shawnborton My bad, forgot to attach screenshots 🤦🏻♂️
This is what I was referring to:
shawnborton commentedon Jun 22, 2023
Got it. I think we should just leave those untouched for now and focus only on existing checkboxes. I think we will examine the overall pattern and relationship between checkboxes and list views at some point in the future.
thiagobrez commentedon Jun 23, 2023
Weekly update: got the base structure working alongside Manage Workspace Members List. Iterated on top of the new component introduced in Phase 1 changes (PR still being reviewed here), so that needs to be merged before raising a PR for this one.
Next week will work on the remaining multiple selection lists, which should be quicker now that the base is ready.
thiagobrez commentedon Jun 23, 2023
Hey @cristipaval! I noticed that I'm not assigned to this issue. Just pointing out because I know you guys use it for internal processes :)
36 remaining items
Santhosh-Sellavel commentedon Aug 30, 2023
@cristipaval This is a huge PR and there were 4 follow-ups till two got merged & two were in review two more PRs to come can we increase the bounty to $3k or at least $2K thanks!
slafortune commentedon Sep 5, 2023
Sorry for the delay on this @Santhosh-Sellavel. While the PR was big, it appears to have been more fragmented rather than causing a huge time suck and blocking you on other things.
slafortune commentedon Sep 5, 2023
Payment summary -
Bug reporter - NA
@thiagobrez does not require payment (Contractor)
@Santhosh-Sellavel is Eligible for Manual Requests and owed $1000
Santhosh-Sellavel commentedon Sep 5, 2023
I disagree it might look like but that's not the case here. It directly affects certain areas covered in this phase, as well affects the changes done in this first phase. So a lot of time of invested in the Review & testing.
cc: @cristipaval Let me know your thoughts, thanks!
slafortune commentedon Sep 6, 2023
@Santhosh-Sellavel We want to clarify that the advertised price for the job is non-negotiable. We do not review or adjust the payment for smaller PRs either. This decision is final, and we will proceed accordingly. If you have any further questions or concerns unrelated to the price, please feel free to discuss them.
Santhosh-Sellavel commentedon Sep 6, 2023
@slafortune
Fine I'll settle for the $1K here if it's final decision.
But we do change the price based on complexity or it's time consuming. There is no advertised price for the job. We had a fixed price a $1000 C+ per internal/agency PR review at that point.
Only certain PR qualifies for price revisions if it's approved by CME/BZ.
Thanks!
slafortune commentedon Sep 8, 2023
Payment Summary -
Bug reporter - NA
@thiagobrez does not require payment (Contractor)
@Santhosh-Sellavel is Eligible for Manual Requests and owed $1000
cc @anmurali @JmillsExpensify
JmillsExpensify commentedon Sep 28, 2023
$1,000 payment approved for @Santhosh-Sellavel based on BZ summary.