You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Web - #room-Red dot with message "A room with this name already exists"very close to the border #20420
@isabelastisser I think we're supposed to keep ourselves assigned as well when re-assigning issues for OOO now, per this update. So going to add you back as an additional assignee for when you're back from OOO!
I don't really think this is a bug/that we need to do anything here. The error message is correct, and while the red dot is near the border, it doesn't quite touch it. Going to close this one for now. But LMK if anyone else feels differently about this!
Activity
melvin-bot commentedon Jun 7, 2023
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 7, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)ahmedGaber93 commentedon Jun 7, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - #room-Red dot with message "A room with this name already exists"very close to the border
What is the root cause of that problem?
There is no
errorRowStyleswith margin toOfflineWithFeedbackhereApp/src/pages/settings/Report/ReportSettingsPage.js
Lines 118 to 122 in 5157478
What changes do you think we should make in order to solve the problem?
add
errorRowStyles={styles.ph5}toOfflineWithFeedbackto be the same with the above view.App/src/pages/settings/Report/ReportSettingsPage.js
Line 124 in 5157478
Before
After
What alternative solutions did you explore? (Optional)
isabelastisser commentedon Jun 8, 2023
I'm OOO, reassigning!
melvin-bot commentedon Jun 8, 2023
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 8, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)joekaufmanexpensify commentedon Jun 8, 2023
@isabelastisser I think we're supposed to keep ourselves assigned as well when re-assigning issues for OOO now, per this update. So going to add you back as an additional assignee for when you're back from OOO!
joekaufmanexpensify commentedon Jun 8, 2023
I will triage this today!
joekaufmanexpensify commentedon Jun 8, 2023
I don't really think this is a bug/that we need to do anything here. The error message is correct, and while the red dot is near the border, it doesn't quite touch it. Going to close this one for now. But LMK if anyone else feels differently about this!
ahmedGaber93 commentedon Jun 9, 2023
@joekaufmanexpensify
I think it will be more consistent if we apply the input same margin for both input view and error view.