Skip to content

Web - #room-Red dot with message "A room with this name already exists"very close to the border #20420

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open https://staging.new.expensify.com/
  2. Sign in with any account with a workspace room
  3. Disable the internet connection in the device
  4. Click the header of the workspace room to open the room details page
  5. Click "Settings"
  6. Rename the room and hit save
  7. Sign into the same account on another device or incognito window
  8. Create another workspace room on the same workspace with the same name
  9. In the main testing device - enable the internet connection

Expected Result:

Error message and red dot aligned with other room settings.

Actual Result:

Red dot very close to the border of settings

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.25.3

Reproducible in staging?: Yes

**Reproducible in production?:**Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6084132_Untitled (1)

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 7, 2023
  2. melvin-bot commented on Jun 7, 2023

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jun 7, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. ahmedGaber93 commented on Jun 7, 2023

    @ahmedGaber93
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Web - #room-Red dot with message "A room with this name already exists"very close to the border

    What is the root cause of that problem?

    There is no errorRowStyles with margin to OfflineWithFeedback here

    <OfflineWithFeedback
    pendingAction={lodashGet(this.props.report, 'pendingFields.reportName', null)}
    errors={lodashGet(this.props.report, 'errorFields.reportName', null)}
    onClose={() => Report.clearPolicyRoomNameErrors(this.props.report.reportID)}
    >

    What changes do you think we should make in order to solve the problem?

    add errorRowStyles={styles.ph5} to OfflineWithFeedback to be the same with the above view.

    <View style={[styles.ph5, styles.pv3]}>

    Before

    Screenshot 2023-06-08 at 1 48 21 AM

    After

    Screenshot 2023-06-08 at 1 46 48 AM

    What alternative solutions did you explore? (Optional)

  5. isabelastisser commented on Jun 8, 2023

    @isabelastisser
    Contributor

    I'm OOO, reassigning!

  6. removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 8, 2023
  7. removed their assignment
    on Jun 8, 2023
  8. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 8, 2023
  9. melvin-bot commented on Jun 8, 2023

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  10. melvin-bot commented on Jun 8, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  11. joekaufmanexpensify commented on Jun 8, 2023

    @joekaufmanexpensify
    Contributor

    @isabelastisser I think we're supposed to keep ourselves assigned as well when re-assigning issues for OOO now, per this update. So going to add you back as an additional assignee for when you're back from OOO!

  12. joekaufmanexpensify commented on Jun 8, 2023

    @joekaufmanexpensify
    Contributor

    I will triage this today!

  13. joekaufmanexpensify commented on Jun 8, 2023

    @joekaufmanexpensify
    Contributor

    I don't really think this is a bug/that we need to do anything here. The error message is correct, and while the red dot is near the border, it doesn't quite touch it. Going to close this one for now. But LMK if anyone else feels differently about this!

  14. ahmedGaber93 commented on Jun 9, 2023

    @ahmedGaber93
    Contributor

    @joekaufmanexpensify
    I think it will be more consistent if we apply the input same margin for both input view and error view.

    Screenshot 2023-06-09 at 8 52 27 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions