You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-21] Cache node_modules to speed up CI/CD #20433
Our setupNode action runs a lot and often takes 3-5 minutes, which is pretty slow.
Solution
While the actions/setup-node action caches npm / node itself, it doesn't cache the actual node_modules. This means that we're doing a clean install every time, on slow CI machines, and it takes a while. Instead, let's cache the node_modules directory and only run npm ci if needed.
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-21. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
Activity
melvin-bot commentedon Jun 8, 2023
Triggered auto assignment to @zanyrenney (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.roryabraham commentedon Jun 8, 2023
I'm going to handle this one myself @zanyrenney so I'm unassigning you.
roryabraham commentedon Jun 8, 2023
I've been testing this out over here
roryabraham commentedon Jun 8, 2023
Got PR ready for review: #20436
roryabraham commentedon Jun 13, 2023
This is live and seems to work well
[-]Cache node_modules to speed up CI/CD[/-][+][HOLD for payment 2023-06-21] Cache node_modules to speed up CI/CD[/+]melvin-bot commentedon Jun 14, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 14, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-21. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue: