Skip to content

[$1000] Share code - Light background does not appear below the avatar image (reported by @alitoshmatov) #20509

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #19883

Action Performed:

  1. Open the App and upload a profile picture that has a transparent background.
  2. Go to Settings -> Share code

Expected Result:

Verify that a light green background appears below the avatar image.

Actual Result:

A light green background does not appear below the avatar image.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.26.1

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6085932_Recording__267.mp4

Expensify/Expensify Issue URL:

Issue reported by: @alitoshmatov / Applause - Internal Team

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686247175943009

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013a3d4105d7772fca
  • Upwork Job ID: 1668408135973871616
  • Last Price Increase: 2023-06-13

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 9, 2023
  2. melvin-bot commented on Jun 9, 2023

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jun 9, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. Nikhil-Vats commented on Jun 9, 2023

    @Nikhil-Vats
  5. dummy-1111 commented on Jun 9, 2023

    @dummy-1111
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Light background doesn't appear below the avatar image

    What is the root cause of that problem?

    We don't pass logoBackgroundColor props here so the default value(defaultTheme.icon) is used.

    <QRCodeLibrary
    getRef={props.getRef}
    value={props.url}
    size={props.size}
    logo={props.logo}
    logoBackgroundColor={props.logoBackgroundColor}
    logoSize={props.size * props.logoRatio}
    logoMargin={props.size * props.logoMarginRatio}
    logoBorderRadius={props.size}
    backgroundColor={props.backgroundColor}
    color={props.color}
    />

    logoBackgroundColor: defaultTheme.icon,

    What changes do you think we should make in order to solve the problem?

    Set the default logoBackgroundColor to defaultTheme.highlightBG

        logoBackgroundColor: defaultTheme.highlightBG
    
    Result

    image

    image

    What alternative solutions did you explore? (Optional)

  6. alitoshmatov commented on Jun 9, 2023

    @alitoshmatov
    Contributor

    I have reported this here - https://expensify.slack.com/archives/C049HHMV9SM/p1686247175943009

    There are two problems

    1. When png uploaded, backend is converting it to jpeg and it is getting default dark background
    2. fix: add background to share code avatar #19883 produced the regression where every logo in qr code have grey background
  7. strepanier03 commented on Jun 9, 2023

    @strepanier03
    Contributor

    @alitoshmatov - Is this being fixed with the PR you mentioned? Do you recommend we put this GH on hold for now?

  8. alitoshmatov commented on Jun 10, 2023

    @alitoshmatov
    Contributor

    @strepanier03 No this PR is the one causing the regression, right now there is no PR to fix this yet. I think someone should confirm that this is indeed regression of #19883 and state next steps.

  9. melvin-bot commented on Jun 12, 2023

    @melvin-bot

    @strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  10. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 13, 2023
  11. changed the title [-]Share code - Light background does not appear below the avatar image[/-] [+][$1000] Share code - Light background does not appear below the avatar image[/+] on Jun 13, 2023
  12. melvin-bot commented on Jun 13, 2023

    @melvin-bot
  13. 27 remaining items

  14. alitoshmatov commented on Jun 17, 2023

    @alitoshmatov
    Contributor

    The issue was that QR codes with expensify logo and non-transparent avatars were not checked after the changes. These changes were only aimed at fixing transparent avatars.

  15. trjExpensify commented on Jun 20, 2023

    @trjExpensify
    Contributor

    Agreed, unless there is a payment for reporting for @alitoshmatov . @trjExpensify do you think reporting reward applies here?

    Was this the first time the bug was surfaced? If so, then I think payment for the bug report would be due.

  16. melvin-bot commented on Jun 23, 2023

    @melvin-bot

    @trjExpensify @mollfpr @aldo-expensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  17. melvin-bot commented on Jun 23, 2023

    @melvin-bot

    @trjExpensify, @mollfpr, @aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  18. aldo-expensify commented on Jun 23, 2023

    @aldo-expensify
    Contributor

    Was this the first time the bug was surfaced? If so, then I think payment for the bug report would be due.

    I think it is the first time, I couldn't find other mentions.

  19. trjExpensify commented on Jun 23, 2023

    @trjExpensify
    Contributor

    Offer sent for the bug report @alitoshmatov here.

  20. alitoshmatov commented on Jun 23, 2023

    @alitoshmatov
    Contributor

    Accepted offer

  21. trjExpensify commented on Jun 26, 2023

    @trjExpensify
    Contributor

    Cool, I've paid that out so going to close this issue now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions