You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1000] Share code - Light background does not appear below the avatar image (reported by @alitoshmatov) #20509
@strepanier03 No this PR is the one causing the regression, right now there is no PR to fix this yet. I think someone should confirm that this is indeed regression of #19883 and state next steps.
changed the title [-]Share code - Light background does not appear below the avatar image[/-][+][$1000] Share code - Light background does not appear below the avatar image[/+]on Jun 13, 2023
The issue was that QR codes with expensify logo and non-transparent avatars were not checked after the changes. These changes were only aimed at fixing transparent avatars.
@trjExpensify@mollfpr@aldo-expensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Activity
melvin-bot commentedon Jun 9, 2023
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 9, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)Nikhil-Vats commentedon Jun 9, 2023
dummy-1111 commentedon Jun 9, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Light background doesn't appear below the avatar image
What is the root cause of that problem?
We don't pass
logoBackgroundColorprops here so the default value(defaultTheme.icon) is used.App/src/components/QRCode/index.js
Lines 62 to 73 in 4dc58e7
App/src/components/QRCode/index.js
Line 53 in 4dc58e7
What changes do you think we should make in order to solve the problem?
Set the default
logoBackgroundColortodefaultTheme.highlightBGResult
What alternative solutions did you explore? (Optional)
alitoshmatov commentedon Jun 9, 2023
I have reported this here - https://expensify.slack.com/archives/C049HHMV9SM/p1686247175943009
There are two problems
strepanier03 commentedon Jun 9, 2023
@alitoshmatov - Is this being fixed with the PR you mentioned? Do you recommend we put this GH on hold for now?
alitoshmatov commentedon Jun 10, 2023
@strepanier03 No this PR is the one causing the regression, right now there is no PR to fix this yet. I think someone should confirm that this is indeed regression of #19883 and state next steps.
melvin-bot commentedon Jun 12, 2023
@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
[-]Share code - Light background does not appear below the avatar image[/-][+][$1000] Share code - Light background does not appear below the avatar image[/+]melvin-bot commentedon Jun 13, 2023
Job added to Upwork: https://www.upwork.com/jobs/~013a3d4105d7772fca
27 remaining items
alitoshmatov commentedon Jun 17, 2023
The issue was that QR codes with expensify logo and non-transparent avatars were not checked after the changes. These changes were only aimed at fixing transparent avatars.
trjExpensify commentedon Jun 20, 2023
Was this the first time the bug was surfaced? If so, then I think payment for the bug report would be due.
melvin-bot commentedon Jun 23, 2023
@trjExpensify @mollfpr @aldo-expensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
melvin-bot commentedon Jun 23, 2023
@trjExpensify, @mollfpr, @aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
aldo-expensify commentedon Jun 23, 2023
I think it is the first time, I couldn't find other mentions.
trjExpensify commentedon Jun 23, 2023
Offer sent for the bug report @alitoshmatov here.
alitoshmatov commentedon Jun 23, 2023
Accepted offer
trjExpensify commentedon Jun 26, 2023
Cool, I've paid that out so going to close this issue now. Thanks!