[$1000] [HOLD for payment 2023-06-21] [HOLD for payment 2023-06-19] Web - New Group - Wrong user details page opens on clicking at display names

@Puneet-here

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Click on fab icon
Create a new group
Refresh the page
Click on each display name and check if the user details are correct

Expected Result:

Correct user details should open

Actual Result:

The user details aren't of the clicked user

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.26.1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-12.at.2.21.12.PM.mov

Recording.3075.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Puneet-here

**Slack conversation:**https://expensify.slack.com/archives/C049HHMV9SM/p1686560410530529

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010a5aeee05bd7da3a
Upwork Job ID: 1671541422809731072
Last Price Increase: 2023-06-21

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@PauloGasparSv

Triggered auto assignment to @PauloGasparSv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong user details page opens on clicking at display names

What is the root cause of that problem?

The root cause of this problem is that, the accountIDs and the participant emails are not matched in correct order.
This is the screen shot of accountIDs and their emails in ReportScreen

And here are the details of those users -

If we pay close attention for first two users in the first picture IDs are interchanged, That's why opening the user details were taking on wrong page.
This is the issue video -

7.New.Expensify.Mozilla.Firefox.2023-06-12.19-00-08.mp4

Here we are using index to navigate -

App/src/components/ReportWelcomeText.js

Lines 94 to 112 in 297e5aa

    
           <Text> 
        
               <Text>{props.translate('reportActionsView.beginningOfChatHistory')}</Text> 
        
               {_.map(displayNamesWithTooltips, ({displayName, pronouns, tooltip}, index) => ( 
        
                   <Text key={`${displayName}${pronouns}${index}`}> 
        
                       <Tooltip text={tooltip}> 
        
                           <Text 
        
                               style={[styles.textStrong]} 
        
                               onPress={() => Navigation.navigate(ROUTES.getProfileRoute(participantAccountIDs[index]))} 
        
                           > 
        
                               {displayName} 
        
                           </Text> 
        
                       </Tooltip> 
        
                       {!_.isEmpty(pronouns) && <Text>{` (${pronouns})`}</Text>} 
        
                       {index === displayNamesWithTooltips.length - 1 && <Text>.</Text>} 
        
                       {index === displayNamesWithTooltips.length - 2 && <Text>{` ${props.translate('common.and')} `}</Text>} 
        
                       {index < displayNamesWithTooltips.length - 2 && <Text>, </Text>} 
        
                   </Text> 
        
               ))} 
        
           </Text>

What changes do you think we should make in order to solve the problem?

Instead of using index we can create the object, that will map the participant emails to their accountID
We can use personalDetails for that, this will ensure we are navigating with proper accountID each time.

What alternative solutions did you explore? (Optional)

None

@BhuvaneshPatil

I think I may use @BhuvaneshPatil solution but implement it myself!

I'm checking if personalDetails will always have the accountID, if that's not the case we can also search for the participant's actual index searching the email from displayNamesWithTooltips in participants. I like the proposed solution much better than doing this but it's an alternative : )

Note: Also test what happens if an account has a displayName and sms/phoneNumber accounts

Using personalDetails works fine when accounts have a Display Name but not so much for SMS based accounts, I'm thinking of a way to make that work : ) (it has to do with the login param and how each object/list is generating theirs)

Using the participants list has the same problem where the domain is stripped and we need that to find the account btw
I don't want to simply use an include() to check if the email matches so I'm still investigating

Edit: Oh I think I can just use addSMSDomainIfPhoneNumber with the tooltip content!

@aimane-chnaif

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

@BhuvaneshPatil

@BhuvaneshPatil and @aimane-chnaif, can you apply to the Upwork job I just created above?

Applied

@aimane-chnaif

Thanks! @aimane-chnaif, I've invited you on Upwork as well. Can you accept that invite when you get the chance?

@johncschuster

@johncschuster, I have also applied to the job. I am reporter on this.

@Puneet-here

Perfect! Thanks, @Puneet-here!

@aimane-chnaif

I've sent offers to you both, @aimane-chnaif and @Puneet-here. Please ping me when you've accepted!

@johncschuster

@johncschuster accepted, thanks!

@aimane-chnaif

This is not overdue but we still need to fill the bugzero checklist so bump @aimane-chnaif : )

@aimane-chnaif

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR: Add new Profile page #20144

[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/20144/files#r1242271160

[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

[@aimane-chnaif] Determine if we should create a regression test for this bug.

[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This bug was introduced while implementing feature of new profile page.
But actually I found that our solution was temporary. (original solution was right but only after migration completed)
The logic on this page (ReportWelcomeText) was refactored again in accountID migration PR.
As the issue caused during migration, no need regression test.

Payment has been issued to everyone 🎉

I think we can close this one out

Navigation Menu

Repository navigation

[$1000] [HOLD for payment 2023-06-21] [HOLD for payment 2023-06-19] Web - New Group - Wrong user details page opens on clicking at display names #20583

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

31 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<Text>
	<Text>{props.translate('reportActionsView.beginningOfChatHistory')}</Text>
	{_.map(displayNamesWithTooltips, ({displayName, pronouns, tooltip}, index) => (
	<Text key={`${displayName}${pronouns}${index}`}>
	<Tooltip text={tooltip}>
	<Text
	style={[styles.textStrong]}
	onPress={() => Navigation.navigate(ROUTES.getProfileRoute(participantAccountIDs[index]))}
	>
	{displayName}
	</Text>
	</Tooltip>
	{!_.isEmpty(pronouns) && <Text>{` (${pronouns})`}</Text>}
	{index === displayNamesWithTooltips.length - 1 && <Text>.</Text>}
	{index === displayNamesWithTooltips.length - 2 && <Text>{` ${props.translate('common.and')} `}</Text>}
	{index < displayNamesWithTooltips.length - 2 && <Text>, </Text>}
	</Text>
	))}
	</Text>

[$1000] [HOLD for payment 2023-06-21] [HOLD for payment 2023-06-19] Web - New Group - Wrong user details page opens on clicking at display names #20583

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

OSBotify commented on Jun 12, 2023

melvin-bot commented on Jun 12, 2023

BhuvaneshPatil commented on Jun 12, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

PauloGasparSv commented on Jun 12, 2023

PauloGasparSv commented on Jun 12, 2023

PauloGasparSv commented on Jun 12, 2023

31 remaining items

melvin-bot commented on Jun 21, 2023

johncschuster commented on Jun 21, 2023

BhuvaneshPatil commented on Jun 21, 2023

johncschuster commented on Jun 22, 2023

Puneet-here commented on Jun 22, 2023

johncschuster commented on Jun 23, 2023

johncschuster commented on Jun 23, 2023

Puneet-here commented on Jun 23, 2023

PauloGasparSv commented on Jun 26, 2023

aimane-chnaif commented on Jun 26, 2023

johncschuster commented on Jun 26, 2023

johncschuster commented on Jun 27, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions