Skip to content

[HOLD for payment 2023-06-23] [HOLD for payment 2023-06-21] [$2000] Sign up for public rooms does not work correctly when using Mobile Google Chrome #20586

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigated to a public room using a URL to enter on incognito (feel free to use this public room https://new.expensify.com/r/7012466542331406)
  2. I need incognito because I’m signed in otherwise.
  3. It showed the room correctly with the sign up option
  4. I clicked sign up using danrvidal+cpatest2@gmail.com, input my magic link

Expected Result:

Drop me back into the public room I signed up in.

Actual Result:

Then I was dropped into the LHN with no more public room, all I can see is my chat concierge and when I search, I cannot find it.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.26-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
image (1)
image

az_recorder_20230612_095840.mp4

Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686348829281759

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012f234df843f030f2
  • Upwork Job ID: 1668264099274833920
  • Last Price Increase: 2023-06-12

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 12, 2023
  2. melvin-bot commented on Jun 12, 2023

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jun 12, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. changed the title [-]Navigated to a public room using a URL to enter on incognito I need incognito because I’m signed in otherwise. It showed the room correctly with the sign up option I clicked sign up using danrvidal+cpatest2@gmail.com, input my magic link Then I was dropped into the LHN with no more public room, all I can see is my chat concierge and when I search, I cannot find it.[/-] [+] Sign up for public rooms does not work correctly when using Mobile Google Chrome[/+] on Jun 12, 2023
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 12, 2023
  6. changed the title [-] Sign up for public rooms does not work correctly when using Mobile Google Chrome[/-] [+][$1000] Sign up for public rooms does not work correctly when using Mobile Google Chrome[/+] on Jun 12, 2023
  7. melvin-bot commented on Jun 12, 2023

    @melvin-bot
  8. melvin-bot commented on Jun 12, 2023

    @melvin-bot

    Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

  9. mountiny commented on Jun 12, 2023

    @mountiny
    Contributor
  10. melvin-bot commented on Jun 12, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 12, 2023
  12. 53 remaining items

  13. changed the title [-][HOLD for payment 2023-06-21] [$2000] Sign up for public rooms does not work correctly when using Mobile Google Chrome[/-] [+][HOLD for payment 2023-06-23] [HOLD for payment 2023-06-21] [$2000] Sign up for public rooms does not work correctly when using Mobile Google Chrome[/+] on Jun 16, 2023
  14. melvin-bot commented on Jun 16, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.28-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-06-23. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  15. melvin-bot commented on Jun 16, 2023

    @melvin-bot
  16. trjExpensify commented on Jun 21, 2023

    @trjExpensify
    Contributor

    Okay, so this one is ready for payments. That said, I'm a little unclear. Did this PR introduce a regression? #20654 (comment)

  17. allroundexperts commented on Jun 21, 2023

    @allroundexperts
    Contributor

    Okay, so this one is ready for payments. That said, I'm a little unclear. Did this PR introduce a regression? #20654 (comment)

    @tjferriss I don't think this PR introduced any regression. The issue existed before our PR was created ref.

  18. tjferriss commented on Jun 23, 2023

    @tjferriss
    Contributor
  19. trjExpensify commented on Jun 23, 2023

    @trjExpensify
    Contributor

    lol, thanks TJ!

    @marcochavezf can you confirm?

  20. marcochavezf commented on Jun 24, 2023

    @marcochavezf
    Contributor

    @trjExpensify Yeah correct, this PR didn't introduce any regression. In fact it fixed an issues introduced by the navigation changes.

  21. trjExpensify commented on Jun 26, 2023

    @trjExpensify
    Contributor

    Okay, thanks for confirming. Going off this then, the payments due are:

    @hoangzinh - $3,000 for the fix & #urgency bonus
    @allroundexperts - $3,000 for C+ & #urgency bonus

    I've sent the offers here.

  22. hoangzinh commented on Jun 26, 2023

    @hoangzinh
    Contributor

    Accepted. Thanks @trjExpensify

  23. trjExpensify commented on Jun 26, 2023

    @trjExpensify
    Contributor

    Thanks, settled up with you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions