Skip to content

[HOLD for payment 2023-06-29] [$1000] Dev: Android/iOS - Invalid prop console error #20589

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open any chat

Expected Result:

No console error

Actual Result:

Console error appears (invalid props.style key cursor)

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.25-4
Reproducible in staging?: Dev
Reproducible in production?: Dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686120988945439

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0151ecf2b81452ae95
  • Upwork Job ID: 1669423474662707200
  • Last Price Increase: 2023-06-15

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 12, 2023
  2. melvin-bot commented on Jun 12, 2023

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jun 12, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. dukenv0307 commented on Jun 12, 2023

    @dukenv0307
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Console error appears (invalid props.style key cursor) in native

    What is the root cause of that problem?

    Some page use styles.cursorPointer which is always cursor: 'pointer' styles in all platforms. And it is invalid when we pass this style to Text component in native. So warning appears in console.

    App/src/styles/styles.js

    Lines 2679 to 2681 in 035783a

    cursorPointer: {
    cursor: 'pointer',
    },

    What changes do you think we should make in order to solve the problem?

    We should replace all styles styles.cursorPointer with cursor.cursorPointer to get the current style for each platform.

    All places are using styles.cursorPointer

    <Text style={[styles.chatItemMessage, styles.cursorPointer, styles.colorMuted]}>

    <Text style={[styles.chatItemMessage, styles.cursorPointer, styles.colorMuted]}>

    <View style={[styles.textInputIconContainer, isEditable ? styles.cursorPointer : styles.pointerEventsNone]}>

    <View style={[styles.flexRow, styles.cursorPointer]}>

    containerStyles={[styles.cursorPointer, props.isHovered ? styles.iouPreviewBoxHover : undefined, ...props.style]}

    What alternative solutions did you explore? (Optional)

  5. hungvu193 commented on Jun 12, 2023

    @hungvu193
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Dev: Android/iOS - Invalid prop console error

    What is the root cause of that problem?

    We're using styles.cursorPointer for the Text inside ReportPreview.
    Screen Shot 2023-06-12 at 21 59 23

    What changes do you think we should make in order to solve the problem?

    Because we wanna keep the cursor when hovering the text, we can replace current usage of current Text with TextLink component like we already did here. Also add onPress to prevent it open url.

    <TextLink 
       onPress={() => {Navigation.navigate(ROUTES.getReportRoute(props.iouReportID));}} 
       style={[styles.chatItemMessage, styles.colorMuted]}>
       {lodashGet(message, 'html', props.translate('iou.payerOwesAmount', {payer: managerName, amount: reportAmount}))}
    </TextLink>

    What alternative solutions did you explore? (Optional)

    N/A

  6. melvin-bot commented on Jun 12, 2023

    @melvin-bot

    Looks like something related to react-navigation may have been mentioned in this issue discussion.

    As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

    Feel free to drop a note in #expensify-open-source with any questions.

  7. stephanieelliott commented on Jun 14, 2023

    @stephanieelliott
    Contributor

    Hey @kavimuru are the repro steps really just Open any chat? I am not able to reproduce this on iOS nor Android

  8. bernhardoj commented on Jun 15, 2023

    @bernhardoj
    Contributor

    @stephanieelliott yes. You will see the warning box at the bottom when you open a chat (dev only I guess)
    image

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 15, 2023
  10. changed the title [-]Dev: Android/iOS - Invalid prop console error[/-] [+][$1000] Dev: Android/iOS - Invalid prop console error[/+] on Jun 15, 2023
  11. 53 remaining items

  12. joekaufmanexpensify commented on Jul 3, 2023

    @joekaufmanexpensify
    Contributor

    Not overdue. Pending being able to pay rajat here.

  13. joekaufmanexpensify commented on Jul 5, 2023

    @joekaufmanexpensify
    Contributor

    Payment to rajat still on hold. Bumped in Slack.

  14. parasharrajat commented on Jul 5, 2023

    @parasharrajat
    Member

    @joekaufmanexpensify It will be better to make this weekly.

  15. joekaufmanexpensify commented on Jul 10, 2023

    @joekaufmanexpensify
    Contributor

    Still on hold

  16. joekaufmanexpensify commented on Jul 17, 2023

    @joekaufmanexpensify
    Contributor
  17. joekaufmanexpensify commented on Jul 24, 2023

    @joekaufmanexpensify
    Contributor

    Checking in on whether we are all set to pay these.

  18. joekaufmanexpensify commented on Jul 31, 2023

    @joekaufmanexpensify
    Contributor

    Bumped in Slack.

  19. parasharrajat commented on Aug 1, 2023

    @parasharrajat
    Member

    Payment requested. Ref: #20589 (comment)


    Thanks for waiting @joekaufmanexpensify.

  20. joekaufmanexpensify commented on Aug 2, 2023

    @joekaufmanexpensify
    Contributor

    Great, thanks! Copying the payment message down so it's clear for the individual who pays. This qualifies for speed bonus, so we need to issue the following payments here:

    • @dukenv0307 - $1,500 (PR +speed bonus). Paid via upwork.
    • @parasharrajat - $1,500 (C+ review + speed bonus). Pending payment via NewDot.
    • @bernhardoj - $250 (reporting bonus). Paid via uppork.
  21. joekaufmanexpensify commented on Aug 2, 2023

    @joekaufmanexpensify
    Contributor

    Closing for now, since all that's left is NewDot payment (which has been requested)!

  22. JmillsExpensify commented on Aug 3, 2023

    @JmillsExpensify
    Contributor

    Reviewed details for @parasharrajat. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions