You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.25-4 Reproducible in staging?: Dev Reproducible in production?: Dev If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Please re-state the problem that we are trying to solve in this issue.
Console error appears (invalid props.style key cursor) in native
What is the root cause of that problem?
Some page use styles.cursorPointer which is always cursor: 'pointer' styles in all platforms. And it is invalid when we pass this style to Text component in native. So warning appears in console.
Please re-state the problem that we are trying to solve in this issue.
Dev: Android/iOS - Invalid prop console error
What is the root cause of that problem?
We're using styles.cursorPointer for the Text inside ReportPreview.
What changes do you think we should make in order to solve the problem?
Because we wanna keep the cursor when hovering the text, we can replace current usage of current Text with TextLink component like we already did here. Also add onPress to prevent it open url.
Looks like something related to react-navigation may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.
Great, thanks! Copying the payment message down so it's clear for the individual who pays. This qualifies for speed bonus, so we need to issue the following payments here:
@dukenv0307 - $1,500 (PR +speed bonus). Paid via upwork.
Activity
melvin-bot commentedon Jun 12, 2023
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 12, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)dukenv0307 commentedon Jun 12, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Console error appears (invalid props.style key
cursor) in nativeWhat is the root cause of that problem?
Some page use
styles.cursorPointerwhich is alwayscursor: 'pointer'styles in all platforms. And it is invalid when we pass this style to Text component in native. So warning appears in console.App/src/styles/styles.js
Lines 2679 to 2681 in 035783a
What changes do you think we should make in order to solve the problem?
We should replace all styles
styles.cursorPointerwithcursor.cursorPointerto get the current style for each platform.All places are using
styles.cursorPointerApp/src/components/ReportActionItem/ReportPreview.js
Line 119 in 035783a
App/src/components/ReportActionItem/ReportPreview.js
Line 124 in 035783a
App/src/components/TextInput/BaseTextInput.js
Line 357 in 035783a
App/src/pages/settings/Payments/AddPayPalMePage.js
Line 78 in 035783a
App/src/components/ReportActionItem/MoneyRequestAction.js
Line 156 in 035783a
App/src/components/Pressable/GenericPressable/BaseGenericPressable.js
Line 27 in 035783a
What alternative solutions did you explore? (Optional)
hungvu193 commentedon Jun 12, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Dev: Android/iOS - Invalid prop console error
What is the root cause of that problem?
We're using

styles.cursorPointerfor the Text insideReportPreview.What changes do you think we should make in order to solve the problem?
Because we wanna keep the cursor when hovering the text, we can replace current usage of current Text with
TextLinkcomponent like we already did here. Also add onPress to prevent it open url.What alternative solutions did you explore? (Optional)
N/A
melvin-bot commentedon Jun 12, 2023
Looks like something related to
react-navigationmay have been mentioned in this issue discussion.As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our
DeprecatedCustomActions.jsfiles should not be accepted.Feel free to drop a note in #expensify-open-source with any questions.
stephanieelliott commentedon Jun 14, 2023
Hey @kavimuru are the repro steps really just
Open any chat? I am not able to reproduce this on iOS nor Androidbernhardoj commentedon Jun 15, 2023
@stephanieelliott yes. You will see the warning box at the bottom when you open a chat (dev only I guess)

[-]Dev: Android/iOS - Invalid prop console error[/-][+][$1000] Dev: Android/iOS - Invalid prop console error[/+]53 remaining items
joekaufmanexpensify commentedon Jul 3, 2023
Not overdue. Pending being able to pay rajat here.
joekaufmanexpensify commentedon Jul 5, 2023
Payment to rajat still on hold. Bumped in Slack.
parasharrajat commentedon Jul 5, 2023
@joekaufmanexpensify It will be better to make this weekly.
joekaufmanexpensify commentedon Jul 10, 2023
Still on hold
joekaufmanexpensify commentedon Jul 17, 2023
Bumped in Slack
joekaufmanexpensify commentedon Jul 24, 2023
Checking in on whether we are all set to pay these.
joekaufmanexpensify commentedon Jul 31, 2023
Bumped in Slack.
parasharrajat commentedon Aug 1, 2023
Payment requested. Ref: #20589 (comment)
Thanks for waiting @joekaufmanexpensify.
joekaufmanexpensify commentedon Aug 2, 2023
Great, thanks! Copying the payment message down so it's clear for the individual who pays. This qualifies for speed bonus, so we need to issue the following payments here:
joekaufmanexpensify commentedon Aug 2, 2023
Closing for now, since all that's left is NewDot payment (which has been requested)!
JmillsExpensify commentedon Aug 3, 2023
Reviewed details for @parasharrajat. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.