Skip to content

[HOLD for payment 2023-06-23] [HOLD for payment 2023-06-21] Web - Chat - Cursor on staging link is not pointer #20669

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open any report
  3. Copy current URL and send in report
  4. Hover on link to observe that cursor is not pointer

Expected Result:

App should display pointer cursor on links

Actual Result:

App displays normal cursor on staging expensify links

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.27.2

Reproducible in staging?: Yes

Reproducible in production?: no

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

cursor.on.staging.is.not.pointer.mp4
Recording.3087.mp4

Expensify/Expensify Issue URL:

Issue reported by: @adeel0202

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686648377836269

View all open jobs on GitHub

Activity

  1. OSBotify commented on Jun 13, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Jun 13, 2023

    @melvin-bot

    Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. youssef-lr commented on Jun 13, 2023

    @youssef-lr
    Contributor

    On it.

  4. eh2077 commented on Jun 13, 2023

    @eh2077
    Contributor

    It's possibly related to #19717 as their fix changed styles of link.

  5. youssef-lr commented on Jun 13, 2023

    @youssef-lr
    Contributor

    thanks @eh2077! That's indeed the offending PR, and specifically this line, as soon as I remove styles.cursorDefault from the styles array the link works. However, what's weird is this is only affecting links like this: https://staging.new.expensify.com/{+text here}, why isn't this affecting all links? For example: this works fine https://staging.new.expensify.com/

  6. youssef-lr commented on Jun 13, 2023

    @youssef-lr
    Contributor

    Actually this is the offending PR #19545.

  7. grgia commented on Jun 13, 2023

    @grgia
    Contributor

    @youssef-lr all these PRs seem to be linked to #19717

    I think we should consider reverting

  8. Nikhil-Vats commented on Jun 13, 2023

    @Nikhil-Vats
    Contributor

    This is caused by my PR but reverting it is not the solution because we were adding the pointer cursor not to the link but to its parent which showed the pointer at places around the link -

    Screen.Recording.2023-06-13.at.9.46.29.PM.mov

    The root cause for this issue is that for some reasons links like https://staging.new.expensify.com/random_text_here are rendered in div rather than a which is wrong.

    Screen.Recording.2023-06-13.at.9.48.01.PM.mov

    So, we need to figure out why links are rendered in div and change it to a to fix it the right way.

  9. youssef-lr commented on Jun 13, 2023

    @youssef-lr
    Contributor

    Ahh gothcu. Do you think you might be able to find a fix? We can always revert than implement the new solution in a follow up PR as this is a deploy blocker. If we can't find the fix quickly then we'll have to revert.

  10. parasharrajat commented on Jun 13, 2023

    @parasharrajat
    Member

    I am sure it will take time to find a good solution as that PR was trying to solve two issues together and finding a balanced solution for both is hard. The fastest option will be to revert the root cause PR and rework.

  11. youssef-lr commented on Jun 13, 2023

    @youssef-lr
    Contributor

    Sounds good to me @parasharrajat.

  12. 35 remaining items

  13. adeel0202 commented on Aug 9, 2023

    @adeel0202
    Contributor
  14. melvin-bot commented on Aug 21, 2023

    @melvin-bot

    This issue has not been updated in over 15 days. @youssef-lr eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  15. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 28, 2023
  16. melvin-bot commented on Aug 28, 2023

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  17. sophiepintoraetz commented on Aug 29, 2023

    @sophiepintoraetz
    Contributor

    FYI - @sakluger - all that's needed here is the reporting payment for @adeel0202 ($250)

  18. deleted a comment from melvin-bot on Aug 29, 2023
  19. sakluger commented on Aug 29, 2023

    @sakluger
    Contributor

    Just sent you an offer through upwork @adeel0202!

    https://www.upwork.com/jobs/~0117619b8e4dbdc25f

  20. adeel0202 commented on Aug 29, 2023

    @adeel0202
    Contributor

    Thanks @sakluger. I have accepted the offer.

  21. sakluger commented on Aug 31, 2023

    @sakluger
    Contributor

    All paid @adeel0202! Sorry again for the wait, and thanks for following up with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions