You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-23] [HOLD for payment 2023-06-21] Web - Chat - Cursor on staging link is not pointer #20669
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
thanks @eh2077! That's indeed the offending PR, and specifically this line, as soon as I remove styles.cursorDefault from the styles array the link works. However, what's weird is this is only affecting links like this: https://staging.new.expensify.com/{+text here}, why isn't this affecting all links? For example: this works fine https://staging.new.expensify.com/
This is caused by my PR but reverting it is not the solution because we were adding the pointer cursor not to the link but to its parent which showed the pointer at places around the link -
Screen.Recording.2023-06-13.at.9.46.29.PM.mov
The root cause for this issue is that for some reasons links like https://staging.new.expensify.com/random_text_here are rendered in div rather than a which is wrong.
Screen.Recording.2023-06-13.at.9.48.01.PM.mov
So, we need to figure out why links are rendered in div and change it to a to fix it the right way.
Ahh gothcu. Do you think you might be able to find a fix? We can always revert than implement the new solution in a follow up PR as this is a deploy blocker. If we can't find the fix quickly then we'll have to revert.
I am sure it will take time to find a good solution as that PR was trying to solve two issues together and finding a balanced solution for both is hard. The fastest option will be to revert the root cause PR and rework.
This issue has not been updated in over 15 days. @youssef-lr eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
OSBotify commentedon Jun 13, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jun 13, 2023
Triggered auto assignment to @youssef-lr (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.youssef-lr commentedon Jun 13, 2023
On it.
eh2077 commentedon Jun 13, 2023
It's possibly related to #19717 as their fix changed styles of link.
youssef-lr commentedon Jun 13, 2023
thanks @eh2077! That's indeed the offending PR, and specifically this line, as soon as I remove
styles.cursorDefaultfrom the styles array the link works. However, what's weird is this is only affecting links like this:https://staging.new.expensify.com/{+text here}, why isn't this affecting all links? For example: this works finehttps://staging.new.expensify.com/youssef-lr commentedon Jun 13, 2023
Actually this is the offending PR #19545.
grgia commentedon Jun 13, 2023
@youssef-lr all these PRs seem to be linked to #19717
I think we should consider reverting
Nikhil-Vats commentedon Jun 13, 2023
This is caused by my PR but reverting it is not the solution because we were adding the pointer cursor not to the link but to its parent which showed the pointer at places around the link -
Screen.Recording.2023-06-13.at.9.46.29.PM.mov
The root cause for this issue is that for some reasons links like
https://staging.new.expensify.com/random_text_hereare rendered indivrather thanawhich is wrong.Screen.Recording.2023-06-13.at.9.48.01.PM.mov
So, we need to figure out why links are rendered in
divand change it toato fix it the right way.youssef-lr commentedon Jun 13, 2023
Ahh gothcu. Do you think you might be able to find a fix? We can always revert than implement the new solution in a follow up PR as this is a deploy blocker. If we can't find the fix quickly then we'll have to revert.
parasharrajat commentedon Jun 13, 2023
I am sure it will take time to find a good solution as that PR was trying to solve two issues together and finding a balanced solution for both is hard. The fastest option will be to revert the root cause PR and rework.
youssef-lr commentedon Jun 13, 2023
Sounds good to me @parasharrajat.
35 remaining items
adeel0202 commentedon Aug 9, 2023
@youssef-lr, bump
melvin-bot commentedon Aug 21, 2023
This issue has not been updated in over 15 days. @youssef-lr eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
melvin-bot commentedon Aug 28, 2023
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.sophiepintoraetz commentedon Aug 29, 2023
FYI - @sakluger - all that's needed here is the reporting payment for @adeel0202 ($250)
sakluger commentedon Aug 29, 2023
Just sent you an offer through upwork @adeel0202!
https://www.upwork.com/jobs/~0117619b8e4dbdc25f
adeel0202 commentedon Aug 29, 2023
Thanks @sakluger. I have accepted the offer.
sakluger commentedon Aug 31, 2023
All paid @adeel0202! Sorry again for the wait, and thanks for following up with us.