You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-23] [HOLD for payment 2023-06-21] [$1000] profile pic does not update in tooltip in offline mode #20672
go to any chat and hover on email to see user details in tooltip
Expected Result:
updated profile pic should show
Actual Result:
shows old profile pic
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.27-2 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
Avatar is not updated in tooltip in offline mode
What is the root cause of that problem?
When user upload a new profile picture. It is updated in Onyx with this key ONYXKEYS.PERSONAL_DETAILS to immediately reflect the result. In the chat we are getting the avatar from ONYXKEYS.PERSONAL_DETAILS_LIST which is not updated until it is stored on the server. Therefore, it keeps displaying the old avatar. We are also using the avatar url from ONYXKEYS.PERSONAL_DETAILS wherever it immediately shows the updated avatar.
@slafortune It seems like the checklist is not needed here. As per #20672 (comment) we intentionally did not update PERSONAL_DETAILS key in the original PR. This got fixed in a subsequent PR but we just wanted to fix this temporarily here because it might have impacted user experience.
Thanks @allroundexperts ! I think if the checklist isn't needed for any reason, having an explanation as to why it isn't needed is super helpful to make sure we are getting everything.
Activity
melvin-bot commentedon Jun 13, 2023
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 13, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Jun 13, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jun 13, 2023
Triggered auto assignment to @pecanoro (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.mdneyazahmad commentedon Jun 13, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Avatar is not updated in tooltip in offline mode
What is the root cause of that problem?
When user upload a new profile picture. It is updated in Onyx with this key
ONYXKEYS.PERSONAL_DETAILSto immediately reflect the result. In the chat we are getting the avatar fromONYXKEYS.PERSONAL_DETAILS_LISTwhich is not updated until it is stored on the server. Therefore, it keeps displaying the old avatar. We are also using the avatar url fromONYXKEYS.PERSONAL_DETAILSwherever it immediately shows the updated avatar.App/src/components/UserDetailsTooltip/index.js
Line 14 in 93957f0
What changes do you think we should make in order to solve the problem?
Get url from
ONYXKEYS.PERSONAL_DETAILSwithPersonalDetailsONYXKEYS.PERSONAL_DETAILSAvatarcomponentWhat alternative solutions did you explore? (Optional)
None
commit: eef7da9
64 remaining items
dummy-1111 commentedon Jun 28, 2023
@pecanoro
May I ask you if this is eligible for speed bonus?
#20672 (comment)
pecanoro commentedon Jun 28, 2023
@s-alves10 Yes! It should! Wasn't the case?
dummy-1111 commentedon Jun 28, 2023
I'm afraid not
slafortune commentedon Jun 29, 2023
Yes! It should have - I missed that and can certainly add it! Bonus sent @s-alves10
allroundexperts commentedon Jun 29, 2023
Don't forget me @slafortune!
pecanoro commentedon Jul 3, 2023
@slafortune Friendly bump to handle the remaining payment issues!
slafortune commentedon Jul 5, 2023
You bet @allroundexperts - can you please complete the checklist? Is there a regression test?
allroundexperts commentedon Jul 6, 2023
@slafortune It seems like the checklist is not needed here. As per #20672 (comment) we intentionally did not update
PERSONAL_DETAILSkey in the original PR. This got fixed in a subsequent PR but we just wanted to fix this temporarily here because it might have impacted user experience.slafortune commentedon Jul 6, 2023
Thanks @allroundexperts ! I think if the checklist isn't needed for any reason, having an explanation as to why it isn't needed is super helpful to make sure we are getting everything.