You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-12] [$1000] Web - Chat - Flagged attachment are collapsed when reacted with emojis #20810
It's not a regression. We agreed to restore hidden state back when refresh page. And this already happens in production, while that PR is on staging.
Though I am not able to reproduce this on latest main. Instead another weird bug happens which is not related to that PR:
Flagged attachment completely disappearing. And flagged text message isn't hidden at all.
OK yep this is reproducible - note it only happens with attachments, when you flag a comment using an option that removes the comment from view, and when you reveal the comment when it is hidden and add an emoji
Activity
melvin-bot commentedon Jun 15, 2023
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 15, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)hungvu193 commentedon Jun 15, 2023
Seems regression from #20737
That's exact case that I mentioned, is this expected? @aimane-chnaif
aimane-chnaif commentedon Jun 15, 2023
It's not a regression. We agreed to restore hidden state back when refresh page. And this already happens in production, while that PR is on staging.
Though I am not able to reproduce this on latest main. Instead another weird bug happens which is not related to that PR:
Flagged attachment completely disappearing. And flagged text message isn't hidden at all.
hungvu193 commentedon Jun 15, 2023
Seems this was logged before that pr hit stagging, I couldn't reproduce on latest main as wellI'm able to reproduce it after try to delete cache.
ashimsharma10 commentedon Jun 15, 2023
@hungvu193 are you sure the same issue mentioned above is reproduced?
aimane-chnaif commentedon Jun 15, 2023
I think there were another recent changes related to flag behavior. Maybe backend updates.
After some time, flag cancels.
Screen.Recording.2023-06-15.at.2.34.17.PM.mov
muttmuure commentedon Jun 19, 2023
I've been trying to reproduce this but I'm seeing that the message isn't being hidden at all
muttmuure commentedon Jun 19, 2023
Ah OK it was just taking a while
muttmuure commentedon Jun 19, 2023
OK yep this is reproducible - note it only happens with attachments, when you flag a comment using an option that removes the comment from view, and when you reveal the comment when it is hidden and add an emoji
49 remaining items
mollfpr commentedon Jul 17, 2023
@muttmuure Applied, thank you!
muttmuure commentedon Jul 17, 2023
Offer sent
ashimsharma10 commentedon Jul 17, 2023
@muttmuure This is my upwork https://www.upwork.com/freelancers/~018a92cf13e1e88eed
dummy-1111 commentedon Jul 18, 2023
@muttmuure
I'm contacting you to know when I would get paid for this issue
cc @mollfpr
mollfpr commentedon Jul 20, 2023
Friendly bump @muttmuure
muttmuure commentedon Jul 20, 2023
@ashimsharma10 invited
muttmuure commentedon Jul 20, 2023
@mollfpr paid
muttmuure commentedon Jul 20, 2023
@s-alves10 paid
ashimsharma10 commentedon Jul 21, 2023
@muttmuure Accepted invitation. waiting for payment
muttmuure commentedon Jul 21, 2023
Offer sent
muttmuure commentedon Jul 23, 2023
@ashimsharma10 paid, test rail proposal created.