You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-24] [$1000] IOS - Showing two different avatars for the same Phone Number #20930
changed the title [-]IOS - Showing two different avatars for the same Phone Number[/-][+][$1000] IOS - Showing two different avatars for the same Phone Number[/+]on Jun 19, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
The closest PR I could find is #8375 but this is a 15-month PR, so something else could make the issue that hard to track.
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
I believe that this issue is not something that will came up often, so the regression step should be enough.
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Precondition:
Account (user A) has been chatting with a phone number user (user B)
Open the app
Go to settings
Create or open a workspace
Click on the Invite members button
Click on the search Input to bring it into focus
Enter the phone number of the user B
Verify that only one option with that phone number is displayed
Activity
melvin-bot commentedon Jun 16, 2023
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 16, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Jun 19, 2023
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
[-]IOS - Showing two different avatars for the same Phone Number[/-][+][$1000] IOS - Showing two different avatars for the same Phone Number[/+]melvin-bot commentedon Jun 19, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0164f70b47c75e0691
melvin-bot commentedon Jun 19, 2023
Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.
57 remaining items
melvin-bot commentedon Jul 17, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
yakubbaev commentedon Jul 24, 2023
Is there anything I should do to proceed with payment on this? @mollfpr @Gonals
mollfpr commentedon Jul 24, 2023
The closest PR I could find is #8375 but this is a 15-month PR, so something else could make the issue that hard to track.
I believe that this issue is not something that will came up often, so the regression step should be enough.
Precondition:
Account (user A) has been chatting with a phone number user (user B)
mollfpr commentedon Jul 24, 2023
@yakubbaev Nothing. You just need to wait for @mallenexpensify to end the Upwork contract.
yakubbaev commentedon Jul 26, 2023
@mallenexpensify any updates?
mallenexpensify commentedon Jul 30, 2023
Apologies it took a bit @yakubbaev .
Issue reporter: @daveSeife paid $250 via Upwork
Contributor: @yakubbaev paid $1000 via Upwork
Contributor+: @mollfpr paid $1000 via Upwork
@daveSeife can you please accept the job and reply here once you have?
daveSeife commentedon Jul 30, 2023
@mallenexpensify Accepted the offer. Thank you
mallenexpensify commentedon Aug 1, 2023
@daveSeife paid. comment above updated to reflect.
TestRail update GH created, thanks @mollfpr