Skip to content

[HOLD for payment 2023-07-24] [$1000] IOS - Showing two different avatars for the same Phone Number #20930

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open app
  2. Go to settings
  3. Create work space
  4. Invite members with phone number.
  5. Write the phone number from the auto suggested list

Expected Result:

When writing a phone number that is Same with the suggested phone number below, it should have only listed one phone number with an Avatar

Actual Result:

Shows two Avatars with the same phone number. And also sends invitation for both, with the same phone numbers but different avatars

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.19.7

Reproducible in staging?: n/a

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

video-output-AFD12FB5-DD66-4F6C-A3C2-36C08D794C7A.1.MOV

Expensify/Expensify Issue URL:

Issue reported by:@daveSeife

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686275913577249

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0164f70b47c75e0691
  • Upwork Job ID: 1670937084692242432
  • Last Price Increase: 2023-06-19

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 16, 2023
  2. melvin-bot commented on Jun 16, 2023

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jun 16, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. melvin-bot commented on Jun 19, 2023

    @melvin-bot

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 19, 2023
  6. changed the title [-]IOS - Showing two different avatars for the same Phone Number[/-] [+][$1000] IOS - Showing two different avatars for the same Phone Number[/+] on Jun 19, 2023
  7. melvin-bot commented on Jun 19, 2023

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 19, 2023
  9. melvin-bot commented on Jun 19, 2023

    @melvin-bot

    Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

  10. 57 remaining items

  11. melvin-bot commented on Jul 17, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
    • [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mollfpr] Determine if we should create a regression test for this bug.
    • [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/304784
  12. yakubbaev commented on Jul 24, 2023

    @yakubbaev
    Contributor

    Is there anything I should do to proceed with payment on this? @mollfpr @Gonals

  13. mollfpr commented on Jul 24, 2023

    @mollfpr
    Contributor

    [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
    [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    The closest PR I could find is #8375 but this is a 15-month PR, so something else could make the issue that hard to track.

    [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    I believe that this issue is not something that will came up often, so the regression step should be enough.

    [@mollfpr] Determine if we should create a regression test for this bug.
    [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Precondition:
    Account (user A) has been chatting with a phone number user (user B)

    1. Open the app
    2. Go to settings
    3. Create or open a workspace
    4. Click on the Invite members button
    5. Click on the search Input to bring it into focus
    6. Enter the phone number of the user B
    7. Verify that only one option with that phone number is displayed
    8. 👍 or 👎
  14. mollfpr commented on Jul 24, 2023

    @mollfpr
    Contributor

    @yakubbaev Nothing. You just need to wait for @mallenexpensify to end the Upwork contract.

  15. yakubbaev commented on Jul 26, 2023

    @yakubbaev
    Contributor

    @mallenexpensify any updates?

  16. mallenexpensify commented on Jul 30, 2023

    @mallenexpensify
    Contributor

    Apologies it took a bit @yakubbaev .

    Issue reporter: @daveSeife paid $250 via Upwork
    Contributor: @yakubbaev paid $1000 via Upwork
    Contributor+: @mollfpr paid $1000 via Upwork

    @daveSeife can you please accept the job and reply here once you have?

  17. daveSeife commented on Jul 30, 2023

    @daveSeife

    @mallenexpensify Accepted the offer. Thank you

  18. mallenexpensify commented on Aug 1, 2023

    @mallenexpensify
    Contributor

    @daveSeife paid. comment above updated to reflect.
    TestRail update GH created, thanks @mollfpr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions