You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Tooltip not present on multiple avatar groups #20934
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.29-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Now the personalDetails are changed to have accountID as keys instead of login. Therefore we need to fix this to iterate over the allPersonalDetails object until it finds the login and return the accountID for that account.
changed the title [-]Tooltip not present on multiple avatar groups[/-][+][HOLD for payment 2023-06-28] Tooltip not present on multiple avatar groups[/+]on Jun 21, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-28. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@iwiznia] The PR that introduced the bug has been identified. Link to the PR:
[@iwiznia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@iwiznia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@iwiznia] Determine if we should create a regression test for this bug.
[@iwiznia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2023-06-28] Tooltip not present on multiple avatar groups[/-][+][HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Tooltip not present on multiple avatar groups[/+]on Jun 22, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-29. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@iwiznia] The PR that introduced the bug has been identified. Link to the PR:
[@iwiznia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@iwiznia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@iwiznia] Determine if we should create a regression test for this bug.
[@iwiznia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jun 16, 2023
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 16, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Jun 16, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jun 16, 2023
Triggered auto assignment to @tylerkaraszewski (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.esh-g commentedon Jun 16, 2023
Proposal
Please re-state the problem
Tooltip not present on multiple avatar groups
What is the root cause of the problem?
The root cause is that the
ReportUtils.getAccountIDForLoginfunction is not working properly due to the recentaccountIDmigration.What changes do you think we need to make in order to fix this problem?
App/src/libs/ReportUtils.js
Lines 854 to 856 in 818ca92
Now the
personalDetailsare changed to haveaccountIDas keys instead oflogin. Therefore we need to fix this to iterate over theallPersonalDetailsobject until it finds theloginand return theaccountIDfor that account.This can be accomplished with the following code:
We are using a similar approach here as well:
App/src/libs/OptionsListUtils.js
Line 743 in 818ca92
After fix
Screen.Recording.2023-06-17.at.1.36.53.AM.mov
What alternatives did you explore?
15 remaining items
[-]Tooltip not present on multiple avatar groups[/-][+][HOLD for payment 2023-06-28] Tooltip not present on multiple avatar groups[/+]melvin-bot commentedon Jun 21, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 21, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-28. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jun 21, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2023-06-28] Tooltip not present on multiple avatar groups[/-][+][HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Tooltip not present on multiple avatar groups[/+]melvin-bot commentedon Jun 22, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-29. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jun 22, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
iwiznia commentedon Jun 22, 2023
What? I closed this because it is a dupe Melvin, leave me alone!
luacmartins commentedon Jun 23, 2023
Gonna remove the blocker label so it doesn't show up in a future checklist if this ever gets reopened.