Skip to content

[HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Tooltip not present on multiple avatar groups #20934

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Create a group to two people
  2. In the LNH, hover over the grouped avatars

Expected Result:

Tooltips for the avatars should be displayed

Actual Result:

Tooltips are not displayed

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.29-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.993.mp4
246514035-868054fb-ea79-415b-844f-bf79fa7919be.mov

Expensify/Expensify Issue URL:
Issue reported by: @esh-g
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686944792622739

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 16, 2023
  2. melvin-bot commented on Jun 16, 2023

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jun 16, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Jun 16, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Jun 16, 2023

    @melvin-bot

    Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. esh-g commented on Jun 16, 2023

    @esh-g
    Contributor

    Proposal

    Please re-state the problem

    Tooltip not present on multiple avatar groups

    What is the root cause of the problem?

    The root cause is that the ReportUtils.getAccountIDForLogin function is not working properly due to the recent accountID migration.

    What changes do you think we need to make in order to fix this problem?

    App/src/libs/ReportUtils.js

    Lines 854 to 856 in 818ca92

    function getAccountIDForLogin(login) {
    return lodashGet(allPersonalDetails, [login, 'accountID'], '');
    }

    Now the personalDetails are changed to have accountID as keys instead of login. Therefore we need to fix this to iterate over the allPersonalDetails object until it finds the login and return the accountID for that account.

    This can be accomplished with the following code:

    function getAccountIDForLogin(login) {
        const user = _.find(allPersonalDetails, (personalDetails) => personalDetails.login === login);
        return lodashGet(user, 'accountID');
    }

    We are using a similar approach here as well:

    let currentUserOption = _.find(allPersonalDetailsOptions, (personalDetailsOption) => personalDetailsOption.login === currentUserLogin);

    After fix

    Screen.Recording.2023-06-17.at.1.36.53.AM.mov

    What alternatives did you explore?

  7. 15 remaining items

  8. changed the title [-]Tooltip not present on multiple avatar groups[/-] [+][HOLD for payment 2023-06-28] Tooltip not present on multiple avatar groups[/+] on Jun 21, 2023
  9. melvin-bot commented on Jun 21, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Jun 21, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-06-28. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  11. melvin-bot commented on Jun 21, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@iwiznia] The PR that introduced the bug has been identified. Link to the PR:
    • [@iwiznia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@iwiznia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@iwiznia] Determine if we should create a regression test for this bug.
    • [@iwiznia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. changed the title [-][HOLD for payment 2023-06-28] Tooltip not present on multiple avatar groups[/-] [+][HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Tooltip not present on multiple avatar groups[/+] on Jun 22, 2023
  13. melvin-bot commented on Jun 22, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-06-29. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  14. melvin-bot commented on Jun 22, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@iwiznia] The PR that introduced the bug has been identified. Link to the PR:
    • [@iwiznia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@iwiznia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@iwiznia] Determine if we should create a regression test for this bug.
    • [@iwiznia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. iwiznia commented on Jun 22, 2023

    @iwiznia
    Contributor

    What? I closed this because it is a dupe Melvin, leave me alone!

  16. luacmartins commented on Jun 23, 2023

    @luacmartins
    Contributor

    Gonna remove the blocker label so it doesn't show up in a future checklist if this ever gets reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions