Connect Bank Account - Checkbox is checked after returning to previous stage

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue foung when executing PR #20193

Action Performed:

Open http://staging.new.expensify.com/
Log into a new account
Navigate to Workspace > Bank Account
Click on "Connect manually"
Insert the routing number 011401533 and account number 1111222233331111
Check the ToS checkbox
Click on "Continue"
Click "Back" to return to previous stage
Click on "Continue"
Fill in the Company information
Check the "restricted business" checkbox
Click on "Save & Continue"
Click "Back" to return to previous stage

Expected Result:

At steps 8 and 13 the checkbox is not checked

Actual Result:

At steps 8 and 13 the checkbox is checked

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.29.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6096129_Bug.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause -Internal Team

Slack conversation:

View all open jobs on GitHub

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@jasperhuangg

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

I think you should remove defaultValue and shouldSaveDraft or set them to false

App/src/pages/ReimbursementAccount/CompanyStep.js

Lines 259 to 275 in 83ab016

    
           <CheckboxWithLabel 
        
               inputID="hasNoConnectionToCannabis" 
        
               defaultValue={this.props.getDefaultStateForField('hasNoConnectionToCannabis', false)} 
        
               LabelComponent={() => ( 
        
                   <Text> 
        
                       {`${this.props.translate('companyStep.confirmCompanyIsNot')} `} 
        
                       <TextLink 
        
                           // eslint-disable-next-line max-len 
        
                           href="https://community.expensify.com/discussion/6191/list-of-restricted-businesses" 
        
                       > 
        
                           {`${this.props.translate('companyStep.listOfRestrictedBusinesses')}.`} 
        
                       </TextLink> 
        
                   </Text> 
        
               )} 
        
               style={[styles.mt4]} 
        
               shouldSaveDraft 
        
           />

Hey guys, I hope all is well i reported a similar bug to this a week ago. Here https://expensify.slack.com/archives/C049HHMV9SM/p1686592692164449?thread_ts=1686592692.164449&cid=C049HHMV9SM

This has been fixed here already - #20091. Closing

Navigation Menu

Repository navigation

Connect Bank Account - Checkbox is checked after returning to previous stage #20950

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<CheckboxWithLabel
	inputID="hasNoConnectionToCannabis"
	defaultValue={this.props.getDefaultStateForField('hasNoConnectionToCannabis', false)}
	LabelComponent={() => (
	<Text>
	{`${this.props.translate('companyStep.confirmCompanyIsNot')} `}
	<TextLink
	// eslint-disable-next-line max-len
	href="https://community.expensify.com/discussion/6191/list-of-restricted-businesses"
	>
	{`${this.props.translate('companyStep.listOfRestrictedBusinesses')}.`}
	</TextLink>
	</Text>
	)}
	style={[styles.mt4]}
	shouldSaveDraft
	/>

Connect Bank Account - Checkbox is checked after returning to previous stage #20950

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

OSBotify commented on Jun 16, 2023

melvin-bot commented on Jun 16, 2023

alitoshmatov commented on Jun 17, 2023

SofoniasN commented on Jun 19, 2023

luacmartins commented on Jun 19, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions