Repository navigation
[REPORTING BONUS PAYMENT] [Hold Auth #8141] Web - Search - Two concierge chats and user's own account appears in search #20965
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Login to a new account
- Click on search
Expected Result:
Only one concierge chat should appear
Actual Result:
Two concierge chats and user's own account appears in search
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.29.0
Reproducible in staging?: yes
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686987884987839
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01518684b253e81d9a
- Upwork Job ID: 1673118417921212416
- Last Price Increase: 2023-06-25
Activity
OSBotify commentedon Jun 17, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jun 17, 2023
Triggered auto assignment to @arosiclair (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.arosiclair commentedon Jun 19, 2023
Not able to reproduce this in v1.3.29-1@kbecciv can you try reproducing again?
arosiclair commentedon Jun 19, 2023
Nevermind I'm able to reproduce with a new
@gmail.comaccount.However, I can't reproduce in dev:
arosiclair commentedon Jun 19, 2023
Alright the root cause of this seems to be an API issue. We build the options list using reports and personal details. We filter duplicates here by login. However, the personal details for Concierge has no login for some reason so both the Concierge chat and personal detail are returned. I can confirm we're not returning the login for Concierge in
OpenApp:Other personal details are unaffected and have logins populated.
arosiclair commentedon Jun 19, 2023
Alright the proper fix for this is #20933 which will filter duplicates by
accountIDinstead ofloginluacmartins commentedon Jun 19, 2023
This Auth PR seems to fix the issue. Gonna remove the label and put this issue on hold for the Auth deploy. We should confirm it's fixed on staging once we deploy Auth.
[-]Web - Search - Two concierge chats and user's own account appears in search[/-][+][Hold Auth #8141] Web - Search - Two concierge chats and user's own account appears in search[/+]17 remaining items
melvin-bot commentedon Jun 25, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)jliexpensify commentedon Jun 25, 2023
@fedirjh sorry, no need for C+, just sorting out payment. @Puneet-here - have invited you for the $250 payment.
[-][$1000] [Hold Auth #8141] Web - Search - Two concierge chats and user's own account appears in search[/-][+][REPORTING BONUS PAYMENT] [Hold Auth #8141] Web - Search - Two concierge chats and user's own account appears in search[/+]Puneet-here commentedon Jun 26, 2023
@jliexpensify applied thank you.
jliexpensify commentedon Jun 26, 2023
No worries, once accepted I shall pay - cheers!
jliexpensify commentedon Jun 28, 2023
@Puneet-here - bumping for you to accept so I can pay you :)
Puneet-here commentedon Jun 29, 2023
@jliexpensify, I have accepted the offer
jliexpensify commentedon Jul 1, 2023
Paid and job closed!