Repository navigation
Profile - GMT time is not displayed #2097
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Expected Result:
GMT time is displayed as GMT -3Actual Result:
"GMT" is not displayed, only the time and "-03" is visible.Action Performed:
- Log in as account A
- Set the time zone of the account to America/Sao_Paulo
- Log out of account A
- Log in as another account and check account A's profile.
Attachments/Notes
Found while executing https://github.com//pull/1717Device and OS: Huawei P20 Pro / 10.0
Is the issue reproducible in Prod: Yes
Build version: 1.0.6-1
Activity
[-][Chat] - 1.0.6-0 - Profile - GMT time is not displayed[/-][+]Profile - GMT time is not displayed[/+]kaushiktd commentedon Mar 26, 2021
Hi,
This is Kaushik here and this is my technical explanation for this issue.
MelvinBot commentedon Mar 31, 2021
Triggered auto assignment to @muttmuure (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.MelvinBot commentedon Apr 7, 2021
Triggered auto assignment to @stitesExpensify (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.muttmuure commentedon Apr 7, 2021
I think I missed this because it's in the .cash repo.
@stitesExpensify when you're happy with the review we'll need to create an External issue in E/E https://expensify.slack.com/archives/C01SKUP7QR0/p1617220984062300?thread_ts=1617218921.052600&cid=C01SKUP7QR0
31 remaining items
kaushiktd commentedon May 14, 2021
@stitesExpensify No prob. I managed to do it from Windows system. Did you get a chance to check it out?
stitesExpensify commentedon May 14, 2021
@kaushiktd Yes I did, if you could take a look at my comment and update your PR description to match the template that would be great
isagoico commentedon May 17, 2021
Issue reproducible during today's KI retests
isagoico commentedon May 24, 2021
Issue reproducible during today's KI retests
kaushiktd commentedon May 24, 2021
@isagoico I just run the entire code in my system again and it not showing any issue. Can you please show me a video of it or a path to recreate this issue?
Christinadobrzyn commentedon May 24, 2021
@stitesExpensify can you give an update on where we are with the final PR for this?
stitesExpensify commentedon May 24, 2021
It looks like there are 2 very similar PRs
https://github.com/Expensify/Expensify.cash/pull/2957/files
https://github.com/Expensify/Expensify.cash/pull/2756/files
@kaushiktd can you choose one and close the other one?
Isabella is testing on production. Since your code has not been merged, the issue will continue to be reproducible 👍
kaushiktd commentedon May 25, 2021
https://github.com/Expensify/Expensify.cash/pull/2957/files
This is the only one open now. I have closed another one. @isagoico Can you please check this again?
stitesExpensify commentedon May 25, 2021
Isabella won't be able to check it because no PR has been merged yet 😄
Basically the process is:
stitesExpensify commentedon May 25, 2021
@kaushiktd I made a change request on the new PR. Let me know when it's good to go and i'll look at it right away
Christinadobrzyn commentedon May 27, 2021
@kaushiktd is paid in Upwork, the contract has been completed, and the Upwork post has been closed
Christinadobrzyn commentedon May 27, 2021
Ah, I accidentally paid this PR too early, it should have been paid 7 days after the correct PR was merged. I'm also going to be ooo next week so I assigned Kadie to this issue.
If needed, please reopen so @kaushiktd can fix any issues with the PR.