[HOLD for payment 2023-07-24] [$1000] The new emoji search field focus inconsistent between mweb chrome and web chrome

@priya-zha

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to staging dot on web chrome and go to any chat. Select emoji picker and notice that the search field is focused by default
Follow the same process on mweb chrome and notice that the search field doesn't have focus while opening the emoji picker

Expected Result:

The new emoji search field focus should be consistent between mweb chrome and web chrome

Actual Result:

The new emoji search field focus is inconsistent between mweb chrome and web chrome

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.29-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Record_2023-06-17-00-55-30.mp4

error-2023-06-09_15.38.29.1.mp4

emoji.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686304700678499

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011663a64195fe4bdf
Upwork Job ID: 1671324047938600960
Last Price Increase: 2023-06-28

@anmurali

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emoji search field isn't focused when open emoji picker on mobile web

What is the root cause of that problem?

We prevent focusing on modal show event for mobile devices here

App/src/components/EmojiPicker/EmojiPicker.js

Line 148 in ffd9672

if (!this.emojiSearchInput || this.props.isSmallScreenWidth) {

What changes do you think we should make in order to solve the problem?

Remove the this.props.isSmallScreenWidth checking

        if (!this.emojiSearchInput || this.props.isSmallScreenWidth) {
            return;
        }

Result

20979_android_chrome.mp4

What alternative solutions did you explore? (Optional)

Can reproduce. Assigning an external label.

Job added to Upwork: https://www.upwork.com/jobs/~011663a64195fe4bdf

@anmurali

Current assignee @anmurali is eligible for the External assigner, not assigning anyone new.

@priya-zha

Payments

Reporting bonus $250 @priya-zha - Offer here, pending acceptance
Contributor and Contributor + payment $1,000 @aimane-chnaif - Paid
Contributor and Contributor + payment $1,000 @situchan - Offer here, pending acceptance

@anmurali

@anmurali this is eligible for timeline bonus

contributor assigned on Jul 10, 10am
C+ approved on Jul 12, 11am
PR merged without any changes on Jul 13, 15pm

I will add it, but curious if there is a bug #20979 (comment)

That's correct in theory. But we agreed that after C+ approval and changes were not requested, still apply bonus even though engineer merging time is delayed

@madmax330

@madmax330, @anmurali, @aimane-chnaif, @situchan Huh... This is 4 days overdue. Who can take care of this?

@madmax330

@madmax330, @anmurali, @aimane-chnaif, @situchan Eep! 4 days overdue now. Issues have feelings too...

@aimane-chnaif

@aimane-chnaif so we still need to pay out the bonuses here?

No it is done!

Navigation Menu

Repository navigation

[HOLD for payment 2023-07-24] [$1000] The new emoji search field focus inconsistent between mweb chrome and web chrome #20979

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

62 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-07-24] [$1000] The new emoji search field focus inconsistent between mweb chrome and web chrome #20979

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jun 18, 2023

melvin-bot commented on Jun 18, 2023

Bug0 Triage Checklist (Main S/O)

dummy-1111 commented on Jun 19, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

anmurali commented on Jun 21, 2023

melvin-bot commented on Jun 21, 2023

melvin-bot commented on Jun 21, 2023

62 remaining items

anmurali commented on Aug 15, 2023

aimane-chnaif commented on Aug 15, 2023

anmurali commented on Aug 15, 2023

aimane-chnaif commented on Aug 15, 2023

melvin-bot commented on Aug 21, 2023

melvin-bot commented on Aug 21, 2023

madmax330 commented on Aug 21, 2023

anmurali commented on Aug 24, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions