Skip to content

Default profile avatar is show instead of profile avatar for brief time in reply thread #21032

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Goto any Chat
  2. Send message
  3. Right click of message and click on reply thread
  4. Observe the profile avatar

Expected Result:

There should not be show default avatar

Actual Result:

Default avatar is show for brief time in reply thread

NOTE : Same can be observed in offline thread message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.29-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @niravkakadiya25
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686992005817599

View all open jobs on GitHub

Screen.Recording.2023-06-17.at.2.21.25.PM.mov

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 19, 2023
  2. melvin-bot commented on Jun 19, 2023

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jun 19, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Jun 19, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Jun 19, 2023

    @melvin-bot

    Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. Beamanator commented on Jun 19, 2023

    @Beamanator
    Contributor

    It's possible this is going to be fixed by #21026, which is being CP'd to staging right now: https://github.com/Expensify/App/actions/runs/5312422908

  7. mountiny commented on Jun 19, 2023

    @mountiny
    Contributor

    I cannot reproduce this on main

  8. mountiny commented on Jun 19, 2023

    @mountiny
    Contributor

    Given I cannot reproduce in main, I will demote this to a normal bug, I dont think its a major problem enough to look into what changes in main fixed this. I can still reproduce in the latest -2 staging version however.

    Let me know if you disagree.

  9. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jun 19, 2023
  10. mountiny commented on Jun 19, 2023

    @mountiny
    Contributor

    Keeping it open to confirm this is fixed tomorrow

  11. luacmartins commented on Jun 19, 2023

    @luacmartins
    Contributor

    This seems like a dupe of #20943, which seems to have been fixed. Closing.

  12. self-assigned this
    on Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions