You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-25] [$1000] The search result still shows emoji for wrong texts #21055
On staging web chrome, navigate to a chat and click the emoji on the chat
Type in any emoji name (example search) and after you enter the last character ('h' in my case for search), do not release your fingers and continuous type any other letters. You'll see still the emojis are shown. But now release your fingers and see , it displays 'Not found'
Repeat the above steps on Slack and you'll see after entering the last character of the emoji, if you type any other letters even without releasing your fingers, it will still show 'Not found'
Expected Result:
The search result should show 'Not found' if the text doesn't match with emoji
Actual Result:
The search result still shows emoji for wrong texts
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.29-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
The debounce method makes the emoji picker seem slow(as seen in a video in the next section).
The filter was initially added in this commit with no debounce at all. The debounce was later added in this commit with a value of 500, which was then reduced to 300 and remained unchanged from April 2021.
What changes do you think we should make in order to solve the problem?
The filter method makes no network call and it executes very fast, so I would suggest to remove the debounce at all. If, for some reason, we need to keep the debounce, I would suggest to lower the value to the smallest one possible in order to make the picker as fast as we can.
We also need to keep both index and index.native.js in sync, so we need to make the same change in both files.
I've made 2 videos for comparison:
Picker with 300 debounce:300_debounce.mp4
*NOTE: if you keep typing forever in the previous video, you will still see the emojis forever. It's when you stop typing that you see the "No results found." message eventually.
Picker with no debounce:no_debounce.mp4
I've also played with small values for the debounce, up to 50 I could not reproduce the bug, no matter how fast I was typing. At 100 it's reproducible, but not as easy as it's now. We may discuss if we want to remove it completely, or to just lower it to 50(or other value).
The PR that introduced the bug has been identified. Link to the PR: N/A
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. This is not bug but a bit improvement. No need regression test.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
GItGudRatio commentedon Jun 19, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The No Results Found message is center aligned.
What is the root cause of that problem?
This issue was reported previously reported and fixed here - #17245
However, the refactor in #18221 reintroduced this issue.
What changes do you think we should make in order to solve the problem?
We need to remove the following lines:
App/src/components/EmojiPicker/EmojiPickerMenu/index.js
Line 528 in edf529e
This will ensure that the results show right below the search text. We will need to do the same for the native files as well.
Additionally, we can add the supporting styles as well but that is a matter than can be finalised in the PR.
What alternative solutions did you explore? (Optional)
None
melvin-bot commentedon Jun 19, 2023
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 19, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)DanutGavrus commentedon Jun 19, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The search result still shows emoji for wrong texts.
What is the root cause of that problem?
Right now, in
EmojiPickerMenuwe have this:App/src/components/EmojiPicker/EmojiPickerMenu/index.js
Line 73 in bd0e843
The
debouncemethod makes the emoji picker seem slow(as seen in a video in the next section).The filter was initially added in this commit with no debounce at all. The
debouncewas later added in this commit with a value of500, which was then reduced to300and remained unchanged from April 2021.What changes do you think we should make in order to solve the problem?
The
filtermethod makes no network call and it executes very fast, so I would suggest to remove thedebounceat all. If, for some reason, we need to keep thedebounce, I would suggest to lower the value to the smallest one possible in order to make the picker as fast as we can.We also need to keep both
indexandindex.native.jsin sync, so we need to make the same change in both files.I've made 2 videos for comparison:
Picker with 300 debounce:
300_debounce.mp4
*NOTE: if you keep typing forever in the previous video, you will still see the emojis forever. It's when you stop typing that you see the "No results found." message eventually.
Picker with no debounce:
no_debounce.mp4
I've also played with small values for the debounce, up to 50 I could not reproduce the bug, no matter how fast I was typing. At 100 it's reproducible, but not as easy as it's now. We may discuss if we want to remove it completely, or to just lower it to 50(or other value).
sophiepintoraetz commentedon Jun 22, 2023
Reassigning because Kadie is OOO and this shouldn't have hit her K2 (timezone takes a while to catch up with 0%!)
111 remaining items
kadiealexander commentedon Oct 26, 2023
Payouts due:
Eligible for 50% #urgency bonus? No
Upwork job is here.
aimane-chnaif commentedon Oct 26, 2023
I think original base price applies here. PR was raised before announcement.
aimane-chnaif commentedon Oct 26, 2023
@kadiealexander I already have offer accepted long time ago. #21055 (comment)
kadiealexander commentedon Oct 26, 2023
@aimane-chnaif I cannot access that contract anymore could you please link it here? Could you also please complete the BugZero checklist?
aimane-chnaif commentedon Oct 26, 2023
kadiealexander commentedon Oct 27, 2023
@aimane-chnaif please don't forget to link your offer!
aimane-chnaif commentedon Oct 30, 2023
@kadiealexander I am also not able to find that contract. Sorry for confusion. Can you please send offer again?
kadiealexander commentedon Oct 31, 2023
Sent!
kadiealexander commentedon Nov 1, 2023
@aimane-chnaif bump to accept the Upwork contract.
aimane-chnaif commentedon Nov 1, 2023
@kadiealexander accepted thanks