Skip to content

[HOLD for payment 2023-07-06] Android- Chat- The user is not navigated to the chat screen after opening chat from notification #21120

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Close the NewDot app
  2. Wait for ~1 minute
  3. Send a message from B to A. Push notification should appear
  4. Double-tap the notification. It should navigate the user to the correct chat, and the new message should be available.

Expected Result:

The user is expecting that the app opens and then the user is redirected to the chat screen in one-on-one chat bar

Actual Result:

The user is been sent to the homepage of the app when the app is opened through the chat message received from the notification bar

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.29.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6095699_mobizen_20230616_150002.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team / @Victor-Nyagudi

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0169b8f4b5af31c852
  • Upwork Job ID: 1671205349345284096
  • Last Price Increase: 2023-06-20

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 20, 2023
  2. melvin-bot commented on Jun 20, 2023

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jun 20, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. arosiclair commented on Jun 20, 2023

    @arosiclair
    Contributor

    This regression reached prod but should have been caught in regression tests. Giving Applause the benefit of the doubt, I think this is what happened:

    Maybe they are clicking the notification with the chat already open. Right now, clicking the notification just opens the app and doesn’t navigate. So if they already had the chat open, it’d seem like it worked correctly

  5. self-assigned this
    on Jun 20, 2023
  6. arosiclair commented on Jun 20, 2023

    @arosiclair
    Contributor

    Seems that it works while the app is alive, but not while killed:

    screen-20230620-131107_2.mp4

    I'll look into this

  7. added
    InternalRequires API changes or must be handled by Expensify staff
    on Jun 20, 2023
  8. melvin-bot commented on Jun 20, 2023

    @melvin-bot
  9. melvin-bot commented on Jun 20, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

  10. arosiclair commented on Jun 21, 2023

    @arosiclair
    Contributor

    As suspected this was caused by the navigation reboot. Specifically, we're no longer waiting for the NavigationContainer to be ready. Additionally, we're still making a call to Navigation.setDidTapNotification() which does not exist and causes an error (source).

    There's a few thing we need to do here:

    • Fix the bug
    • Add logging for notification click handling so we can better debug this in the future
    • Update regression test steps to select a different chat before testing notification click through and also to test click through with the app killed
  11. melvin-bot commented on Jun 21, 2023

    @melvin-bot

    Looks like something related to react-navigation may have been mentioned in this issue discussion.

    As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

    Feel free to drop a note in #expensify-open-source with any questions.

  12. arosiclair commented on Jun 21, 2023

    @arosiclair
    Contributor

    Found a fix and posted a PR. Also pinged some knowledgeable navigation folks

  13. 15 remaining items

  14. mollfpr commented on Jul 6, 2023

    @mollfpr
    Contributor

    Sorry, I'm running out of time 🙏

    I'll complete the checklist in the morning.

  15. mollfpr commented on Jul 7, 2023

    @mollfpr
    Contributor

    [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
    [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    Thanks to @arosiclair explain here #21120 (comment)

    [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    The regression steps should be enough.

    [@mollfpr] Determine if we should create a regression test for this bug.
    [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    As suggested by @arosiclair, we should add the new test case here https://expensify.testrail.io/index.php?/cases/view/1971003&group_by=cases:section_id&group_order=asc&display_deleted_cases=0

    Notification click through (Android & iOS only)

    1. Log into NewDot
    2. Navigate to the Concierge chat
    3. Send yourself a message
    4. Verify a notification for the message is received
    5. Click the notification
    6. Verify the app navigates to the chat for the message

    Notification click-through while the app is killed (Android & iOS only)

    1. Navigate back to the Concierge chat
    2. Kill the app by swiping it away in the recent apps view
    3. Send yourself another message
    4. Verify a notification for the message is received
    5. Click the message
    6. Verify the app opens and navigates to the chat for the message
  16. Victor-Nyagudi commented on Jul 8, 2023

    @Victor-Nyagudi
    Contributor

    @mollfpr The payment date for this issue is July 6th, but I haven't received an offer yet for the reporting bonus.

    Cc: @adelekennedy since you're also assigned here in case you're the one I should be asking.

  17. mollfpr commented on Jul 8, 2023

    @mollfpr
    Contributor

    @Victor-Nyagudi BZ team will take care of the payment, which in this issue is @adelekennedy

  18. Victor-Nyagudi commented on Jul 10, 2023

    @Victor-Nyagudi
    Contributor

    Bump @adelekennedy .

    I see @MelvinBot also added the Overdue label.

  19. adelekennedy commented on Jul 10, 2023

    @adelekennedy
    Contributor

    was ooo Friday as I was sick and then the weekend.

    @Victor-Nyagudi $250 reporting
    @mollfpr 1k for PR review

    will you apply here?

  20. Victor-Nyagudi commented on Jul 10, 2023

    @Victor-Nyagudi
    Contributor

    Sorry to hear that, @adelekennedy. Hope you're feeling better now.

    I've applied on Upwork.

  21. mollfpr commented on Jul 11, 2023

    @mollfpr
    Contributor

    Applied, thank you @adelekennedy

  22. mollfpr commented on Jul 15, 2023

    @mollfpr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions