You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-06] Android- Chat- The user is not navigated to the chat screen after opening chat from notification #21120
This regression reached prod but should have been caught in regression tests. Giving Applause the benefit of the doubt, I think this is what happened:
Maybe they are clicking the notification with the chat already open. Right now, clicking the notification just opens the app and doesn’t navigate. So if they already had the chat open, it’d seem like it worked correctly
As suspected this was caused by the navigation reboot. Specifically, we're no longer waiting for the NavigationContainer to be ready. Additionally, we're still making a call to Navigation.setDidTapNotification() which does not exist and causes an error (source).
There's a few thing we need to do here:
Fix the bug
Add logging for notification click handling so we can better debug this in the future
Update regression test steps to select a different chat before testing notification click through and also to test click through with the app killed
Looks like something related to react-navigation may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
The regression steps should be enough.
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Jun 20, 2023
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 20, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)arosiclair commentedon Jun 20, 2023
This regression reached prod but should have been caught in regression tests. Giving Applause the benefit of the doubt, I think this is what happened:
arosiclair commentedon Jun 20, 2023
Seems that it works while the app is alive, but not while killed:
screen-20230620-131107_2.mp4
I'll look into this
melvin-bot commentedon Jun 20, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0169b8f4b5af31c852
melvin-bot commentedon Jun 20, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (
Internal)arosiclair commentedon Jun 21, 2023
As suspected this was caused by the navigation reboot. Specifically, we're no longer waiting for the
NavigationContainerto be ready. Additionally, we're still making a call toNavigation.setDidTapNotification()which does not exist and causes an error (source).There's a few thing we need to do here:
melvin-bot commentedon Jun 21, 2023
Looks like something related to
react-navigationmay have been mentioned in this issue discussion.As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our
DeprecatedCustomActions.jsfiles should not be accepted.Feel free to drop a note in #expensify-open-source with any questions.
arosiclair commentedon Jun 21, 2023
Found a fix and posted a PR. Also pinged some knowledgeable navigation folks
15 remaining items
mollfpr commentedon Jul 6, 2023
Sorry, I'm running out of time 🙏
I'll complete the checklist in the morning.
mollfpr commentedon Jul 7, 2023
Thanks to @arosiclair explain here #21120 (comment)
The regression steps should be enough.
As suggested by @arosiclair, we should add the new test case here https://expensify.testrail.io/index.php?/cases/view/1971003&group_by=cases:section_id&group_order=asc&display_deleted_cases=0
Notification click through (Android & iOS only)
Notification click-through while the app is killed (Android & iOS only)
Victor-Nyagudi commentedon Jul 8, 2023
@mollfpr The payment date for this issue is July 6th, but I haven't received an offer yet for the reporting bonus.
Cc: @adelekennedy since you're also assigned here in case you're the one I should be asking.
mollfpr commentedon Jul 8, 2023
@Victor-Nyagudi BZ team will take care of the payment, which in this issue is @adelekennedy
Victor-Nyagudi commentedon Jul 10, 2023
Bump @adelekennedy .
I see @MelvinBot also added the
Overduelabel.adelekennedy commentedon Jul 10, 2023
was ooo Friday as I was sick and then the weekend.
@Victor-Nyagudi $250 reporting
@mollfpr 1k for PR review
will you apply here?
Victor-Nyagudi commentedon Jul 10, 2023
Sorry to hear that, @adelekennedy. Hope you're feeling better now.
I've applied on Upwork.
mollfpr commentedon Jul 11, 2023
Applied, thank you @adelekennedy
mollfpr commentedon Jul 15, 2023