[HOLD for payment 2023-07-14] [$1000] mWeb- Link is not working for Viewing all receipts/Viewing all bills option

@narzullome

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open app
Go to settings > Workspace >Reimbursements
Click to View All receipts

Expected Result:

Link is working for Viewing all receipts option

Actual Result:

Link is not working for Viewing all receipts option

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.27-6

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

IMG_1130.1.1.MP4

IMG_1131.MP4

RPReplay_Final1687270989.MP4

Expensify/Expensify Issue URL:

Issue reported by: @narzullome

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686726774076549

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c9e23c776186a8a6
Upwork Job ID: 1672142727528816640
Last Price Increase: 2023-06-23

@bfitzexpensify

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

Can't open View all receipts in Safari, both web and mWeb.

What is the root cause of that problem?

Currently, we open the link inside a promise that waits for the API to complete.

App/src/libs/actions/Link.js

Lines 70 to 80 in 0b7455f

    
           API.makeRequestWithSideEffects('OpenOldDotLink', {}, {}) 
        
               .then((response) => { 
        
                   buildOldDotURL(url, response.shortLivedAuthToken).then((oldDotUrl) => { 
        
                       Linking.openURL(oldDotUrl); 
        
                   }); 
        
               }) 
        
               .catch(() => { 
        
                   buildOldDotURL(url).then((oldDotUrl) => { 
        
                       Linking.openURL(oldDotUrl); 
        
                   }); 
        
               });

However, in Safari, we can't open a link inside an async function. Here is a similar past issue #3615 and the solution is this PR #3764 that introduces asyncOpenUrl that implements a workaround for Safari. (actually, from my testing, it can work inside async if there is only a little delay, for example using a setTimeout with 0 delay)

asyncOpenUrl accepts a promise and a URL. The URL will be opened after the promise is done.

App/src/libs/asyncOpenURL/index.website.js

Lines 10 to 29 in 0b7455f

    
           export default function asyncOpenURL(promise, url, shouldSkipCustomSafariLogic) { 
        
               if (!url) { 
        
                   return; 
        
               } 
        
               const isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent); 
        
               if (!isSafari || shouldSkipCustomSafariLogic) { 
        
                   promise.then((params) => { 
        
                       Linking.openURL(typeof url === 'string' ? url : url(params)); 
        
                   }); 
        
               } else { 
        
                   const windowRef = window.open(); 
        
                   promise 
        
                       .then((params) => { 
        
                           windowRef.location = typeof url === 'string' ? url : url(params); 
        
                       }) 
        
                       .catch(() => windowRef.close()); 
        
               } 
        
           }

URL can be either a string or a function. The very first implementation of asyncOpenUrl only accepts the URL as a string, but then it allows a function in this PR.

It previously works until this commit that replaced asyncOpenUrl.

What changes do you think we should make in order to solve the problem?

Use asyncOpenUrl back again. As the URL is available from the promise, we will pass the whole promise and a function for url. It will look like this:

asyncOpenURL(
    API.makeRequestWithSideEffects('OpenOldDotLink', {}, {})
        .then((response) => buildOldDotURL(url, response.shortLivedAuthToken))
        .catch(() => buildOldDotURL(url)),
    (url) => url,
);

Job added to Upwork: https://www.upwork.com/jobs/~01c9e23c776186a8a6

@bfitzexpensify

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

@parasharrajat

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@parasharrajat

@parasharrajat proposal from @bernhardoj ready for review when you get a chance - thanks!

@parasharrajat

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Offers have been sent out

@bfitzexpensify

@bfitzexpensify Accepted thank you

@parasharrajat

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Start using OpenOldDotLink #9943
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/9943/files#r1265600129
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed.
[@parasharrajat] Determine if we should create a regression test for this bug. yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Open Settings > Workspaces > Select any workspace > Reimbursements.
Press View all receipts
Verify you are redirected to the OldDot web

Do you agree 👍 or 👎 ?

@parasharrajat

I like those @parasharrajat. Proposed they be added in https://github.com/Expensify/Expensify/issues/300649. Cool, we're all done here - thanks everyone!

Payment requested 1500.

@bfitzexpensify

@bfitzexpensify Can you please summarize the appropriate individual payments for all parties involved in this issue? This is holding up @eVoloshchak's and @parasharrajat's NewDot payments. More information on this compliance process in Slack.

@bfitzexpensify

Bump @bfitzexpensify. Can you please update the above-requested info?

@narzullome

Sorry, was OOO on Friday.

Payments for each party:

Reporting: $250 for @narzullome, paid via Upwork ✅
Contributor: $1,500 (completion + #urgency bonus) for @bernhardoj, paid via Upwork ✅
C+: $1,500 (completion + #urgency bonus) for @parasharrajat, which will need to be paid via NewDot

@parasharrajat

Reviewed details for @parasharrajat. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.

Navigation Menu

Repository navigation

[HOLD for payment 2023-07-14] [$1000] mWeb- Link is not working for Viewing all receipts/Viewing all bills option #21189

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

22 remaining items

Regression Test Steps

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	API.makeRequestWithSideEffects('OpenOldDotLink', {}, {})
	.then((response) => {
	buildOldDotURL(url, response.shortLivedAuthToken).then((oldDotUrl) => {
	Linking.openURL(oldDotUrl);
	});
	})
	.catch(() => {
	buildOldDotURL(url).then((oldDotUrl) => {
	Linking.openURL(oldDotUrl);
	});
	});

	export default function asyncOpenURL(promise, url, shouldSkipCustomSafariLogic) {
	if (!url) {
	return;
	}

	const isSafari = /^((?!chrome\|android).)*safari/i.test(navigator.userAgent);

	if (!isSafari \|\| shouldSkipCustomSafariLogic) {
	promise.then((params) => {
	Linking.openURL(typeof url === 'string' ? url : url(params));
	});
	} else {
	const windowRef = window.open();
	promise
	.then((params) => {
	windowRef.location = typeof url === 'string' ? url : url(params);
	})
	.catch(() => windowRef.close());
	}
	}

[HOLD for payment 2023-07-14] [$1000] mWeb- Link is not working for Viewing all receipts/Viewing all bills option #21189

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jun 21, 2023

melvin-bot commented on Jun 21, 2023

Bug0 Triage Checklist (Main S/O)

bernhardoj commented on Jun 21, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot commented on Jun 23, 2023

melvin-bot commented on Jun 23, 2023

melvin-bot commented on Jun 23, 2023

bfitzexpensify commented on Jun 26, 2023

22 remaining items

melvin-bot commented on Jul 7, 2023

bfitzexpensify commented on Jul 17, 2023

narzullome commented on Jul 17, 2023

parasharrajat commented on Jul 17, 2023

Regression Test Steps

bfitzexpensify commented on Jul 18, 2023

parasharrajat commented on Jul 24, 2023

JmillsExpensify commented on Jul 27, 2023

parasharrajat commented on Jul 30, 2023

bfitzexpensify commented on Jul 31, 2023

JmillsExpensify commented on Jul 31, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions