You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-12] [$1000] Web - RBR(red dot) for the maximum number of attempts of the resend magic code persists after Successfully adding the Contact method #21220
And when we get an error for validateCodeSent, and we do not clear the error by pressing the cross icon from the RBR, we add the correct magic code. At that time validateCodeSent error does not reset to null, and then we do not show the magic code page. However, the validateCodeSent error value is still there, and we can see the red dot beside the contact method.
What changes do you think we should make in order to solve the problem?
We should set the validateCodeSent error to null when we get the success response for the ValidateSecondaryLogin, so that when we successfully validate the contact method and the magic code works, then no need to show the error for a maximum number of magic code requests.
so here we need to add the errorFields: {validateCodeSent: null} to the successData of the ValidateSecondaryLogin
And when we get an error for validateCodeSent, and we do not clear the error by pressing the cross icon from the RBR, we add the correct magic code. At that time validateCodeSent error does not reset to null, and then we do not show the magic code page. However, the validateCodeSent error value is still there, and we can see the red dot beside the contact method.
What changes do you think we should make in order to solve the problem?
We should set the validateCodeSent error to null when we get the success response for the ValidateSecondaryLogin, so that when we successfully validate the contact method and the magic code works, then no need to show the error for a maximum number of magic code requests.
so here we need to add the errorFields: {validateCodeSent: null} to the successData of the ValidateSecondaryLogin
changed the title [-]Web - RBR(red dot) for the maximum number of attempts of the resend magic code persists after Successfully adding the Contact method[/-][+][$1000] Web - RBR(red dot) for the maximum number of attempts of the resend magic code persists after Successfully adding the Contact method[/+]on Jun 26, 2023
changed the title [-][$1000] Web - RBR(red dot) for the maximum number of attempts of the resend magic code persists after Successfully adding the Contact method[/-][+][HOLD for payment 2023-07-12] [$1000] Web - RBR(red dot) for the maximum number of attempts of the resend magic code persists after Successfully adding the Contact method[/+]on Jul 5, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.36-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
This can be caught while QA, so the regression step should be enough.
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Go to Settings > Profile > Contact method
Press New Contact method > Enter any of your email address
Go to the newly added Contact method and Press Resend magic code 5-6 times until we get the error of the maximum number of attempts
Enter the last magic code from the Email
If the magic code worked and then It will navigate back to the Contact Methods page
Check the Added Contact method and verify there is no red dot(RBR) for the contact method
Activity
melvin-bot commentedon Jun 21, 2023
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 21, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)kbecciv commentedon Jun 21, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
RBR for the maximum number of attempts of the resend magic code persists after Successfully verifying the magic code
What is the root cause of that problem?
Resend magic codeat that, we time call the requestContactMethodValidateCode method from User.js,App/src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.js
Lines 80 to 81 in f15e6dc
if the API return the error then we set the error for validateCodeSent to errorFields in failureData
App/src/libs/actions/User.js
Lines 168 to 170 in a2d074b
What changes do you think we should make in order to solve the problem?
We should set the validateCodeSent error to null when we get the success response for the ValidateSecondaryLogin, so that when we successfully validate the contact method and the magic code works, then no need to show the error for a maximum number of magic code requests.
so here we need to add the
errorFields: {validateCodeSent: null}to the successData of the ValidateSecondaryLoginApp/src/libs/actions/User.js
Lines 426 to 437 in f15e6dc
What alternative solutions did you explore? (Optional)
none
jayeshmangwani commentedon Jun 21, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
RBR for the maximum number of attempts of the resend magic code persists after Successfully verifying the magic code
What is the root cause of that problem?
Resend magic codeat that, we time call the requestContactMethodValidateCode method from User.js,App/src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.js
Lines 80 to 81 in f15e6dc
if the API return the error then we set the error for validateCodeSent to errorFields in failureData
App/src/libs/actions/User.js
Lines 168 to 170 in a2d074b
What changes do you think we should make in order to solve the problem?
We should set the validateCodeSent error to null when we get the success response for the ValidateSecondaryLogin, so that when we successfully validate the contact method and the magic code works, then no need to show the error for a maximum number of magic code requests.
so here we need to add the
errorFields: {validateCodeSent: null}to the successData of the ValidateSecondaryLoginApp/src/libs/actions/User.js
Lines 426 to 437 in f15e6dc
What alternative solutions did you explore? (Optional)
none
[-]Web - RBR(red dot) for the maximum number of attempts of the resend magic code persists after Successfully adding the Contact method[/-][+][$1000] Web - RBR(red dot) for the maximum number of attempts of the resend magic code persists after Successfully adding the Contact method[/+]melvin-bot commentedon Jun 26, 2023
Job added to Upwork: https://www.upwork.com/jobs/~012abf0b985aa6c54b
melvin-bot commentedon Jun 26, 2023
Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Jun 26, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)12 remaining items
[-][$1000] Web - RBR(red dot) for the maximum number of attempts of the resend magic code persists after Successfully adding the Contact method[/-][+][HOLD for payment 2023-07-12] [$1000] Web - RBR(red dot) for the maximum number of attempts of the resend magic code persists after Successfully adding the Contact method[/+]melvin-bot commentedon Jul 5, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 5, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.36-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jul 5, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mollfpr commentedon Jul 12, 2023
#15204
https://github.com/Expensify/App/pull/15204/files#r1261394662
This can be caught while QA, so the regression step should be enough.
mollfpr commentedon Jul 12, 2023
Melvin forgot to calculate this issue 🤔
The assignment Jun 29
PR merged on Jul 1
sonialiap commentedon Jul 13, 2023
@jayeshmangwani offer sent for reporting issue + fix (+bonus) - paid
@mollfpr offer sent for review (+bonus) - paid
mollfpr commentedon Jul 13, 2023
@sonialiap Accepted, thank you!
jayeshmangwani commentedon Jul 13, 2023
@sonialiap offer Accepted, Thank you!
sonialiap commentedon Jul 13, 2023
All paid ✔️