Skip to content

[HOLD for payment 2023-07-06] [$1000] Login - Page freezes when navigating to secondary login verification link #21258

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in to staging.new.expensify.com
  2. Log in to staging.expensify.com with the same account as Step 1
  3. Add a secondary login via Settings > Account details > Secondary logins
  4. Go to verification email and copy the link
  5. Change the URL to staging.new.expensify.com/.....
  6. Navigate to the link

Expected Result:

Page does not freeze

Actual Result:

Page is freezing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.30.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6101771_bandicam_2023-06-22_02-56-38-516.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017f461734f63ec998
  • Upwork Job ID: 1672271611349622784
  • Last Price Increase: 2023-06-23

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 21, 2023
  2. melvin-bot commented on Jun 21, 2023

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jun 21, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. johncschuster commented on Jun 22, 2023

    @johncschuster
    Contributor

    @lanitochka17 is this test meant to be part of the Add Secondary Login flow? I don't see a flow in new.expensify.com to add a Secondary Login, so I'm wondering why this was tested in this way.

  5. lanitochka17 commented on Jun 22, 2023

    @lanitochka17
    Author
  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 23, 2023
  7. changed the title [-]Login - Page freezes when navigating to secondary login verification link[/-] [+][$1000] Login - Page freezes when navigating to secondary login verification link[/+] on Jun 23, 2023
  8. melvin-bot commented on Jun 23, 2023

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 23, 2023
  10. melvin-bot commented on Jun 23, 2023

    @melvin-bot

    Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

  11. melvin-bot commented on Jun 23, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

  12. ddrzaic commented on Jun 23, 2023

    @ddrzaic

    Proposal

    ThreePaneView.js file, line 72
    return ( <View key={route.key} style={[styles.pAbsolute, styles.t0, styles.l0, styles.w100, styles.h100]} > {props.descriptors[route.key].render()} </View> );

    this returns a div which overlays the whole page, and that looks like the page is frozen, but in fact, there is a div which is above the page, and if you delete that div, the page is responsive.

    Solution

    Add ValidateLogin screen to SCREENS constant, and add that case into ThreePaneView.js

  13. 26 remaining items

  14. hoangzinh commented on Jun 28, 2023

    @hoangzinh
    Contributor

    Accepted. Thanks @johncschuster

  15. s77rt commented on Jun 28, 2023

    @s77rt
    Member

    @johncschuster Accepted!

  16. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 29, 2023
  17. changed the title [-][$1000] Login - Page freezes when navigating to secondary login verification link[/-] [+][HOLD for payment 2023-07-06] [$1000] Login - Page freezes when navigating to secondary login verification link[/+] on Jun 29, 2023
  18. melvin-bot commented on Jun 29, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  19. melvin-bot commented on Jun 29, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-07-06. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter - Applause
    • Contributor that fixed the issue - @hoangzinh
    • Contributor+ that helped on the issue and/or PR - @s77rt

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus - Eligible
    • Merged PR more than 9 business days after assignment - 50% penalty
  20. melvin-bot commented on Jun 29, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
    • [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@s77rt] Determine if we should create a regression test for this bug.
    • [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  21. s77rt commented on Jun 30, 2023

    @s77rt
    Member
    • The PR that introduced the bug has been identified: fix: 2FA bug fixes #19260
    • The offending PR has been commented on: fix: 2FA bug fixes #19260 (comment)
    • A discussion in #expensify-bugs has been started: I don't think this is needed based on the discussion in the linked PR above
    • Determine if we should create a regression test for this bug: Yes

    Regression Test Proposal

    1. Logout of NewDot if logged in
    2. In the login screen enter your email
    3. Navigate to email and locate the magic link and the magic code
    4. Enter the magic code manually
    5. Verify you are logged in
    6. Navigate to the magic link - change to staging if needed
    7. Verify the "Here's your magic code" page is displayed
  22. johncschuster commented on Jul 6, 2023

    @johncschuster
    Contributor

    Payments have been issued! I think we're good to close this out! 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions