You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-06] [$1000] Login - Page freezes when navigating to secondary login verification link #21258
@lanitochka17 is this test meant to be part of the Add Secondary Login flow? I don't see a flow in new.expensify.com to add a Secondary Login, so I'm wondering why this was tested in this way.
changed the title [-]Login - Page freezes when navigating to secondary login verification link[/-][+][$1000] Login - Page freezes when navigating to secondary login verification link[/+]on Jun 23, 2023
this returns a div which overlays the whole page, and that looks like the page is frozen, but in fact, there is a div which is above the page, and if you delete that div, the page is responsive.
Solution
Add ValidateLogin screen to SCREENS constant, and add that case into ThreePaneView.js
changed the title [-][$1000] Login - Page freezes when navigating to secondary login verification link[/-][+][HOLD for payment 2023-07-06] [$1000] Login - Page freezes when navigating to secondary login verification link[/+]on Jun 29, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-06. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jun 21, 2023
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 21, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)johncschuster commentedon Jun 22, 2023
@lanitochka17 is this test meant to be part of the
Add Secondary Loginflow? I don't see a flow in new.expensify.com to add a Secondary Login, so I'm wondering why this was tested in this way.lanitochka17 commentedon Jun 22, 2023
@johncschuster According to the steps with Test Rail https://expensify.testrail.io/index.php?/tests/view/3501015
[-]Login - Page freezes when navigating to secondary login verification link[/-][+][$1000] Login - Page freezes when navigating to secondary login verification link[/+]melvin-bot commentedon Jun 23, 2023
Job added to Upwork: https://www.upwork.com/jobs/~017f461734f63ec998
melvin-bot commentedon Jun 23, 2023
Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Jun 23, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)ddrzaic commentedon Jun 23, 2023
Proposal
ThreePaneView.js file, line 72
return ( <View key={route.key} style={[styles.pAbsolute, styles.t0, styles.l0, styles.w100, styles.h100]} > {props.descriptors[route.key].render()} </View> );this returns a div which overlays the whole page, and that looks like the page is frozen, but in fact, there is a div which is above the page, and if you delete that div, the page is responsive.
Solution
Add ValidateLogin screen to SCREENS constant, and add that case into ThreePaneView.js
26 remaining items
hoangzinh commentedon Jun 28, 2023
Accepted. Thanks @johncschuster
s77rt commentedon Jun 28, 2023
@johncschuster Accepted!
[-][$1000] Login - Page freezes when navigating to secondary login verification link[/-][+][HOLD for payment 2023-07-06] [$1000] Login - Page freezes when navigating to secondary login verification link[/+]melvin-bot commentedon Jun 29, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 29, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-06. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jun 29, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
s77rt commentedon Jun 30, 2023
Regression Test Proposal
johncschuster commentedon Jul 6, 2023
Payments have been issued! I think we're good to close this out! 💃