Skip to content

FAB - Missing conversations in recent list #21283

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Preconditions: user has already navigated to NewDot and logged in with an account that has a lot of conversations.

  1. Open http://staging.new.expensify.com/
  2. Log in angela.puella@mail.com
  3. Click on any chat on the LHN that is not the most recent one
  4. Click on the "Global action" button (Big green plus button in LHN)
  5. Click on "New chat" / "New group"

Expected Result:

The search list should be divided by "Recents" and "Contacts".
There should be 5 conversations displayed in "Recents".

Actual Result:

There's only a conversation displayed in "Recents"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.30.5

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6102104_Bug_02_-_Staging_-_2023-06-21_16-59-02.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Jun 21, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Jun 21, 2023

    @melvin-bot

    Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. situchan commented on Jun 22, 2023

    @situchan
    Contributor

    I think this is backend issue. Happening on production as well.
    To reproduce, logout (to clear all stale contacts data) and re-login

  4. WoLewicki commented on Jun 22, 2023

    @WoLewicki
    Contributor

    For me, those recent contacts don't change at all when navigating, and they should show the top 5 most recent opened reports?

  5. situchan commented on Jun 22, 2023

    @situchan
    Contributor

    Here's the root cause
    Backend doesn't return login in personalDetails so it fails this condition:

    // We're only picking personal details that have logins set
    // This is a temporary fix for all the logic that's been breaking because of the new privacy changes
    // See https://github.com/Expensify/Expensify/issues/293465 for more context
    // eslint-disable-next-line no-param-reassign
    personalDetails = _.pick(personalDetails, (detail) => Boolean(detail.login));

    We can fix this by replacing detail.login by detail.accountID but I think this isn't enough fix.

  6. WoLewicki commented on Jun 22, 2023

    @WoLewicki
    Contributor

    Ok, so if it is not connected to navigation changes, then nothing to do here for me 😅

  7. melvin-bot commented on Jun 22, 2023

    @melvin-bot

    Looks like something related to react-navigation may have been mentioned in this issue discussion.

    As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

    Feel free to drop a note in #expensify-open-source with any questions.

  8. situchan commented on Jun 22, 2023

    @situchan
    Contributor

    This was caused by #21159 which deployed to production yesterday, so not a deploy blocker. But still requires urgent fix.

  9. mountiny commented on Jun 22, 2023

    @mountiny
    Contributor

    Thanks for linking, I also dont think this is a deploy blocker, discussing in the slack thread

  10. Skalakid commented on Jun 22, 2023

    @Skalakid
    Contributor

    @situchan @mountiny conversations labeled as Recent are the last opened ones (even before re-login), or conversations where I recently send/got a message?

  11. Skalakid commented on Jun 22, 2023

    @Skalakid
    Contributor

    I'm Michał from Software Mansion and I would like to work on this issue.

  12. 27 remaining items

  13. melvin-bot commented on Aug 21, 2023

    @melvin-bot

    This issue has not been updated in over 15 days. @Skalakid eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  14. melvin-bot commented on Nov 2, 2023

    @melvin-bot

    @Skalakid, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

  15. removed their assignment
    on Nov 6, 2023
  16. Skalakid commented on Nov 6, 2023

    @Skalakid
    Contributor

    @mountiny I completely lost notification about this issue. Like I wrote above I think the problem was on the backend side. Do you know if it was solved?

  17. mountiny commented on Nov 7, 2023

    @mountiny
    Contributor

    Yeah I think this one has not been reproduced for a while, if it would be repro again, we can reopen

  18. lanitochka17 commented on Jan 14, 2025

    @lanitochka17
    Author

    Issue is still reproducible on the latest build 9.0.85-3

    Bug6704478_1735624948954.2024-12-31_13-46-27.mp4

    Image

  19. izarutskaya commented on Jan 15, 2025

    @izarutskaya

    Created new issue for this comment - new GH #55266

  20. mountiny commented on Jan 15, 2025

    @mountiny
    Contributor

    Closing in favour of the fresher issue #55266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions