Skip to content

[HOLD for payment 2023-08-14] [$1000] Add Tooltip for the report actions whose actor is the workspace #21322

Closed

Description

@cristipaval

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to a workspace where you are a non-admin member
  2. Request money from the workspace
  3. Verify that you have the report preview where the actor is the workspace
  4. Hover the workspace name on that report preview

Expected Result:

You should see a tooltip with the workspace avatar and name

Actual Result:

Nothing happens

Workaround:

No workaround

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012a1fc3c444f423b4
  • Upwork Job ID: 1675995747731927040
  • Last Price Increase: 2023-07-10

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 22, 2023
  2. self-assigned this
    on Jun 22, 2023
  3. melvin-bot commented on Jun 22, 2023

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Jun 22, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. cristipaval commented on Jun 22, 2023

    @cristipaval
    ContributorAuthor

    Hey @jliexpensify, this is a follow-up issue after this PR. Don't try to reproduce this before the PR gets merged and deployed.

  6. changed the title [-]Add Tooltip for the report actions whose actor is the workspace[/-] [+][HOLD UNTIL PR] Add Tooltip for the report actions whose actor is the workspace[/+] on Jun 22, 2023
  7. abdulrahuman5196 commented on Jun 23, 2023

    @abdulrahuman5196
    Contributor

    If required i can work on this issue as C+ in future since the original PR and this followup issue was found during the C+ review.

  8. cristipaval commented on Jun 23, 2023

    @cristipaval
    ContributorAuthor

    Yes, makes sense!

  9. jliexpensify commented on Jun 25, 2023

    @jliexpensify
    Contributor

    Looks like the PR got deployed to Staging, so testing now.

  10. changed the title [-][HOLD UNTIL PR] Add Tooltip for the report actions whose actor is the workspace[/-] [+]Add Tooltip for the report actions whose actor is the workspace[/+] on Jun 25, 2023
  11. jliexpensify commented on Jun 25, 2023

    @jliexpensify
    Contributor

    @cristipaval I'm confused by the instructions:

    1. Request money from the workspace

    How do you do this? I found this SO but on Staging v1.3.32-5, I can only request an IOU from an individual.

    Is there a Beta I need to be added to?

    1. Verify that you have the report preview where the actor is the workspace

    What does "where the actor is the workspace" mean?

    Thanks!

  12. cristipaval commented on Jun 26, 2023

    @cristipaval
    ContributorAuthor

    Hey @jliexpensify! The App PR which fixes this issue is already merged and deployed to staging. So you won't be able to reproduce the issue.

    In order to understand the testing steps, it might help you to watch the screen recordings in the PR that fixes the issue, here.

  13. 78 remaining items

  14. changed the title [-][$1000] Add Tooltip for the report actions whose actor is the workspace[/-] [+][HOLD for payment 2023-08-14] [$1000] Add Tooltip for the report actions whose actor is the workspace[/+] on Aug 7, 2023
  15. melvin-bot commented on Aug 7, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Aug 7, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.50-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-08-14. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  17. jliexpensify commented on Aug 8, 2023

    @jliexpensify
    Contributor

    Not overdue!

  18. abdulrahuman5196 commented on Aug 12, 2023

    @abdulrahuman5196
    Contributor

    The PR that introduced the bug has been identified. Link to the PR:
    The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    Not a regression. Followup of this PR #20941 (comment)

    Determine if we should create a regression test for this bug.

    YES

    If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    1. Go to a workspace
    2. Request money from the workspace
    3. Verify that you have the report preview where the actor is the workspace
    4. Hover the workspace name on that report preview
    5. Verify that you can see the tooltip
  19. jliexpensify commented on Aug 14, 2023

    @jliexpensify
    Contributor

    Payment Summary:

    Upworks job.

    Is this correct? I don't think anyone is eligible for a bonus.

  20. jliexpensify commented on Aug 14, 2023

    @jliexpensify
    Contributor

    @Nodebrute I have invited you (i think, there was only one Anusha?) but can you add your full name from upworks to your GH profile? Thanks.

  21. abdulrahuman5196 commented on Aug 14, 2023

    @abdulrahuman5196
    Contributor

    @jliexpensify correct. Accepted the offer.

  22. Nodebrute commented on Aug 14, 2023

    @Nodebrute
    Contributor

    @jliexpensify I have accepted the offer.

  23. jliexpensify commented on Aug 15, 2023

    @jliexpensify
    Contributor

    Everyone paid, job closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions