You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-14] [$1000] Add Tooltip for the report actions whose actor is the workspace #21322
Go to a workspace where you are a non-admin member
Request money from the workspace
Verify that you have the report preview where the actor is the workspace
Hover the workspace name on that report preview
Expected Result:
You should see a tooltip with the workspace avatar and name
Actual Result:
Nothing happens
Workaround:
No workaround
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:
changed the title [-]Add Tooltip for the report actions whose actor is the workspace[/-][+][HOLD UNTIL PR] Add Tooltip for the report actions whose actor is the workspace[/+]on Jun 22, 2023
changed the title [-][HOLD UNTIL PR] Add Tooltip for the report actions whose actor is the workspace[/-][+]Add Tooltip for the report actions whose actor is the workspace[/+]on Jun 25, 2023
changed the title [-][$1000] Add Tooltip for the report actions whose actor is the workspace[/-][+][HOLD for payment 2023-08-14] [$1000] Add Tooltip for the report actions whose actor is the workspace[/+]on Aug 7, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.50-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-14. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Activity
melvin-bot commentedon Jun 22, 2023
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)cristipaval commentedon Jun 22, 2023
Hey @jliexpensify, this is a follow-up issue after this PR. Don't try to reproduce this before the PR gets merged and deployed.
[-]Add Tooltip for the report actions whose actor is the workspace[/-][+][HOLD UNTIL PR] Add Tooltip for the report actions whose actor is the workspace[/+]abdulrahuman5196 commentedon Jun 23, 2023
If required i can work on this issue as C+ in future since the original PR and this followup issue was found during the C+ review.
cristipaval commentedon Jun 23, 2023
Yes, makes sense!
jliexpensify commentedon Jun 25, 2023
Looks like the PR got deployed to Staging, so testing now.
[-][HOLD UNTIL PR] Add Tooltip for the report actions whose actor is the workspace[/-][+]Add Tooltip for the report actions whose actor is the workspace[/+]jliexpensify commentedon Jun 25, 2023
@cristipaval I'm confused by the instructions:
How do you do this? I found this SO but on Staging v1.3.32-5, I can only request an IOU from an individual.
Is there a Beta I need to be added to?
What does "where the actor is the workspace" mean?
Thanks!
cristipaval commentedon Jun 26, 2023
Hey @jliexpensify! The App PR which fixes this issue is already merged and deployed to staging. So you won't be able to reproduce the issue.
In order to understand the testing steps, it might help you to watch the screen recordings in the PR that fixes the issue, here.
78 remaining items
[-][$1000] Add Tooltip for the report actions whose actor is the workspace[/-][+][HOLD for payment 2023-08-14] [$1000] Add Tooltip for the report actions whose actor is the workspace[/+]melvin-bot commentedon Aug 7, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 7, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.50-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-14. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
jliexpensify commentedon Aug 8, 2023
Not overdue!
abdulrahuman5196 commentedon Aug 12, 2023
Not a regression. Followup of this PR #20941 (comment)
YES
jliexpensify commentedon Aug 14, 2023
Payment Summary:
Upworks job.
Is this correct? I don't think anyone is eligible for a bonus.
jliexpensify commentedon Aug 14, 2023
@Nodebrute I have invited you (i think, there was only one Anusha?) but can you add your full name from upworks to your GH profile? Thanks.
abdulrahuman5196 commentedon Aug 14, 2023
@jliexpensify correct. Accepted the offer.
Nodebrute commentedon Aug 14, 2023
@jliexpensify I have accepted the offer.
jliexpensify commentedon Aug 15, 2023
Everyone paid, job closed!