You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-12] [$1000] 2FA - When the "copy code" button is clicked, the download button moves. #21566
Observe that when the "copy code" button is clicked, the download button moves.
Expected Result:
When the "copy code" button is clicked, the "Download" and "copy code" buttons should not move. Instead they should remain fixed and only the internal data should change.
Actual Result:
When the "copy code" button is clicked, the "Download" and "copy code" buttons move.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.30-5 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Please re-state the problem that we are trying to solve in this issue.
When the "copy code" button is clicked, the "Download" and "copy code" buttons should not move. Instead, they should remain fixed and only the internal data should change.
What is the root cause of that problem?
The problem here is that when clicking the copy button the code its content change resulting in the width button changing:
What changes do you think we should make in order to solve the problem?
We can update minWidth of the button equal to the width when the text is copy codes, because the langue 'Spanish' have a length than English. So we will base on the Spanish
changed the title [-] 2FA - When the "copy code" button is clicked, the download button moves.[/-][+][$1000] 2FA - When the "copy code" button is clicked, the download button moves.[/+]on Jun 26, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.36-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jun 26, 2023
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 26, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)namhihi237 commentedon Jun 26, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
When the "copy code" button is clicked, the "Download" and "copy code" buttons should not move. Instead, they should remain fixed and only the internal data should change.
What is the root cause of that problem?
The problem here is that when clicking the copy button the code its content change resulting in the width button changing:
App/src/pages/settings/Security/TwoFactorAuth/CodesPage.js
Line 109 in f867c17
App/src/styles/styles.js
Lines 2216 to 2218 in f867c17
With the button on page VerifyPage the same as above
App/src/pages/settings/Security/TwoFactorAuth/VerifyPage.js
Line 135 in f867c17
What changes do you think we should make in order to solve the problem?
We can update minWidth of the button equal to the width when the text is
copy codes, because the langue 'Spanish' have a length than English. So we will base on the SpanishWith button copy in VerifyPage we can add style:
And add style for the button:
Result:
Screen.Recording.2023-06-26.at.21.30.05.mov
Screen.Recording.2023-06-27.at.00.29.15.mov
What alternative solutions did you explore? (Optional)
Or we can use fix width for button:
Pujan92 commentedon Jun 26, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
2FA copy codes page copy button width gets changed on click
What is the root cause of that problem?
It seems we don't have provided the correct fixed width to the button and the button Section also gets overlapped to the padding area.
What changes do you think we should make in order to solve the problem?
As from the slack discussion fixed-width needs to provide to these buttons and considering the spanish text it requires approx 140px width.
Below changes seems to be required for this.
App/src/pages/settings/Security/TwoFactorAuth/CodesPage.js
Line 81 in 468dd6c
App/src/styles/styles.js
Lines 2168 to 2176 in 468dd6c
Update the padding in the order of
ph6,ph4&ph2.Provide a width 140px to these buttons
App/src/styles/styles.js
Lines 2217 to 2219 in 468dd6c
After giving more width the content doesn't look in the center, to fix that update
justifyContent: 'space-around'fortwoFactorAuthCodesContainer.App/src/styles/styles.js
Line 2197 in 468dd6c
Result
Screen.Recording.2023-06-26.at.11.32.52.PM.mov
For
VerifyPagewe can also update the width to achieve the same(inspired by above proposal)[-] 2FA - When the "copy code" button is clicked, the download button moves.[/-][+][$1000] 2FA - When the "copy code" button is clicked, the download button moves.[/+]melvin-bot commentedon Jun 26, 2023
Job added to Upwork: https://www.upwork.com/jobs/~014f0d2000a41973c1
melvin-bot commentedon Jun 26, 2023
Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Jun 26, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)s77rt commentedon Jun 27, 2023
@namhihi237 Thanks for the proposal. You RCA is correct and the solution looks good to me.
🎀 👀 🎀 C+ reviewed
24 remaining items
melvin-bot commentedon Jul 5, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.36-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jul 5, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
s77rt commentedon Jul 5, 2023
kevinksullivan commentedon Jul 6, 2023
Will pay out after regression period.
namhihi237 commentedon Jul 13, 2023
Hello team any update payment for this.
kevinksullivan commentedon Jul 13, 2023
Paid @s77rt and @namhihi237 . @usmantariq96 sent offer for reporting. Lmk when you accept
s77rt commentedon Jul 13, 2023
@kevinksullivan This is not eligible for the 50% bonus. I have refunded the bonus.
namhihi237 commentedon Jul 13, 2023
@kevinksullivan the same with me. I have refunded.
usmantariq96 commentedon Jul 14, 2023
@kevinksullivan Offer accepted.
kevinksullivan commentedon Jul 17, 2023
Thanks everyone. Paid @usmantariq96