You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-16] [$1000] mWeb - Can't paste magic code on text input #21708
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Chrome
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.30-5 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Based on past experience this kind of delay happens only when CMEs are busy working on priority items or they are not available (OOO). Only if it takes more than two days I would start DM & Ping them on channels, but some discussions happen sooner. Also, we rarely would run into situations like this.
What I felt we have could done differently, is we could have had this conversion before assigning @tienifr here. Because we didn't go with the selected proposal. We wanted something different here and had our doubts about the existing implementation itself.
I would try and speed up things with you in the future, thanks!
The bonuses/penalties we have are meant to inspire everyone to take initiative. The CMEs are here to support you and are just as motivated to close these issues as you are.
Here's some more specific feedback on this ticket that I think would be helpful in avoiding delays...
pick a single proposal instead of recommending two different proposals (this gives the CME more work to do and will likely cause delays)
ask for help in Slack if you can't figure out which proposal is best
anticipate whether the proposal really makes complete sense and summarize anything unclear (not doing this gives the CME more work to do and will cause delays). Are all parts of the proposal template clearly filled out? Or could they be improved?
if the CME has follow up questions then the ball is back in your court. lead the investigation and get them answered with urgency.
if the CME assigns someone then ensure a PR is created with urgency.
if the CME leaves questions on the PR bump the assignee to get them answered.
avoid further delays by not questioning the clear instructions of the CME. ask for clarification if you feel like progress is blocked.
bump your assignee so they do not take so long to update the PR.
There are arguably some factors outside of your control e.g. the proposal was accepted, but more questions needed to be answered. But is that really so different from any conversation on any PR review that could slow something down? By recommending the proposal you are communicating to us to "start the clock".
Anyways, we are here to support you - not slow you down. But IMO you need to be able to show that you made every effort to expedite if you are going to claim that something outside of your control slowed stuff down.
changed the title [-][$1000] mWeb - Can't paste magic code on text input[/-][+][HOLD for payment 2023-08-16] [$1000] mWeb - Can't paste magic code on text input[/+]on Aug 9, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-16. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@Santhosh-Sellaveldoes not require payment (Eligable for Manual Requests)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
[@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
[@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A Should have been caught while testing
[@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
[@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A. Basic case
[@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jun 27, 2023
Triggered auto assignment to @sophiepintoraetz (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 27, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)sophiepintoraetz commentedon Jun 28, 2023
sophiepintoraetz commentedon Jun 28, 2023
Okay, clarified that it's only Chrome browser that this occurs in - able to reproduce now:
RPReplay_Final1687924335.MP4
[-]mWeb - Can't paste magic code on text input[/-][+][$1000] mWeb - Can't paste magic code on text input[/+]melvin-bot commentedon Jun 28, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01cecac183f21046d7
70 remaining items
Santhosh-Sellavel commentedon Aug 3, 2023
Sorry @marcaaron
Based on past experience this kind of delay happens only when CMEs are busy working on priority items or they are not available (OOO). Only if it takes more than two days I would start DM & Ping them on channels, but some discussions happen sooner. Also, we rarely would run into situations like this.
What I felt we have could done differently, is we could have had this conversion before assigning @tienifr here. Because we didn't go with the selected proposal. We wanted something different here and had our doubts about the existing implementation itself.
I would try and speed up things with you in the future, thanks!
marcaaron commentedon Aug 3, 2023
The bonuses/penalties we have are meant to inspire everyone to take initiative. The CMEs are here to support you and are just as motivated to close these issues as you are.
Here's some more specific feedback on this ticket that I think would be helpful in avoiding delays...
There are arguably some factors outside of your control e.g. the proposal was accepted, but more questions needed to be answered. But is that really so different from any conversation on any PR review that could slow something down? By recommending the proposal you are communicating to us to "start the clock".
Anyways, we are here to support you - not slow you down. But IMO you need to be able to show that you made every effort to expedite if you are going to claim that something outside of your control slowed stuff down.
[-][$1000] mWeb - Can't paste magic code on text input[/-][+][HOLD for payment 2023-08-16] [$1000] mWeb - Can't paste magic code on text input[/+]melvin-bot commentedon Aug 9, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 9, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-16. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Aug 9, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
sophiepintoraetz commentedon Aug 16, 2023
Confirming payments (paid out now) based on Marc's feedback here:
Payouts due:
Issue Reporter: $250 @@dan1d
Contributor: $500 @tienifr
Contributor+: $500 @Santhosh-Sellavel
Eligible for 50% #urgency bonus? N
Santhosh-Sellavel commentedon Aug 17, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Santhosh-Sellavel commentedon Aug 30, 2023
Requested on ND
JmillsExpensify commentedon Sep 1, 2023
Reviewed the details for @Santhosh-Sellavel. $500 approved for payment in NewDot based on BZ summary.