Skip to content

[HOLD for payment 2023-08-16] [$1000] mWeb - Can't paste magic code on text input #21708

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Sign in and click next
  2. Copy the code
  3. Try to paste the code

Expected Result:

Use able to paste

Actual Result:

User is not able to paste

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Chrome
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.30-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1687541550.1.MP4
safari.2606.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dan1d
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687541947014449

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cecac183f21046d7
  • Upwork Job ID: 1673903402036682752
  • Last Price Increase: 2023-07-05

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 27, 2023
  2. melvin-bot commented on Jun 27, 2023

    @melvin-bot

    Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jun 27, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. sophiepintoraetz commented on Jun 28, 2023

    @sophiepintoraetz
  5. sophiepintoraetz commented on Jun 28, 2023

    @sophiepintoraetz
    Contributor

    Okay, clarified that it's only Chrome browser that this occurs in - able to reproduce now:

    RPReplay_Final1687924335.MP4
  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on Jun 28, 2023
  7. changed the title [-]mWeb - Can't paste magic code on text input[/-] [+][$1000] mWeb - Can't paste magic code on text input[/+] on Jun 28, 2023
  8. melvin-bot commented on Jun 28, 2023

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 28, 2023
  10. 70 remaining items

  11. Santhosh-Sellavel commented on Aug 3, 2023

    @Santhosh-Sellavel
    Collaborator

    Sorry @marcaaron

    Based on past experience this kind of delay happens only when CMEs are busy working on priority items or they are not available (OOO). Only if it takes more than two days I would start DM & Ping them on channels, but some discussions happen sooner. Also, we rarely would run into situations like this.

    What I felt we have could done differently, is we could have had this conversion before assigning @tienifr here. Because we didn't go with the selected proposal. We wanted something different here and had our doubts about the existing implementation itself.

    I would try and speed up things with you in the future, thanks!

  12. marcaaron commented on Aug 3, 2023

    @marcaaron
    Contributor

    The bonuses/penalties we have are meant to inspire everyone to take initiative. The CMEs are here to support you and are just as motivated to close these issues as you are.

    Here's some more specific feedback on this ticket that I think would be helpful in avoiding delays...

    • pick a single proposal instead of recommending two different proposals (this gives the CME more work to do and will likely cause delays)
    • ask for help in Slack if you can't figure out which proposal is best
    • anticipate whether the proposal really makes complete sense and summarize anything unclear (not doing this gives the CME more work to do and will cause delays). Are all parts of the proposal template clearly filled out? Or could they be improved?
    • if the CME has follow up questions then the ball is back in your court. lead the investigation and get them answered with urgency.
    • if the CME assigns someone then ensure a PR is created with urgency.
    • if the CME leaves questions on the PR bump the assignee to get them answered.
    • avoid further delays by not questioning the clear instructions of the CME. ask for clarification if you feel like progress is blocked.
    • bump your assignee so they do not take so long to update the PR.

    There are arguably some factors outside of your control e.g. the proposal was accepted, but more questions needed to be answered. But is that really so different from any conversation on any PR review that could slow something down? By recommending the proposal you are communicating to us to "start the clock".

    Anyways, we are here to support you - not slow you down. But IMO you need to be able to show that you made every effort to expedite if you are going to claim that something outside of your control slowed stuff down.

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 9, 2023
  14. changed the title [-][$1000] mWeb - Can't paste magic code on text input[/-] [+][HOLD for payment 2023-08-16] [$1000] mWeb - Can't paste magic code on text input[/+] on Aug 9, 2023
  15. melvin-bot commented on Aug 9, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Aug 9, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-08-16. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  17. melvin-bot commented on Aug 9, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
    • [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
    • [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  18. sophiepintoraetz commented on Aug 16, 2023

    @sophiepintoraetz
    Contributor

    Confirming payments (paid out now) based on Marc's feedback here:

    Payouts due:

    Issue Reporter: $250 @@dan1d
    Contributor: $500 @tienifr
    Contributor+: $500 @Santhosh-Sellavel

    Eligible for 50% #urgency bonus? N

  19. Santhosh-Sellavel commented on Aug 17, 2023

    @Santhosh-Sellavel
    Collaborator

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  20. Santhosh-Sellavel commented on Aug 30, 2023

    @Santhosh-Sellavel
    Collaborator

    Requested on ND

  21. JmillsExpensify commented on Sep 1, 2023

    @JmillsExpensify
    Contributor

    Reviewed the details for @Santhosh-Sellavel. $500 approved for payment in NewDot based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions