You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-24] [$1000] Web - Thread report and LHN title still visible after thread parent message being flagged as Intimidation or Bullying #21890
From account B go back to the original report and flag the message as Intimidation or Bullying
Go back to the thread and notice the thread title still being visible in LHN and thread report
Expected Result:
LHN title and thread report title should display "Message Hidden" while the parent message of the thread has MODERATOR_DECISION of PENDING_HIDE or HIDDEN
Actual Result:
LHN title and thread report title are still visible
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.33-4 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Please re-state the problem that we are trying to solve in this issue.
Thread report and LHN title still visible after thread parent message being flagged as Intimidation or Bullying
What is the root cause of that problem?
The text used for the titles of OptionRowLHN is retrieved from ReportUtils.getReportName which isn't handling the case where the parent message has been reported as Intimidation/Bullying or has been hidden.
What changes do you think we should make in order to solve the problem?
We could firstly add a new entry to parentReportAction and for example call it hiddenMessage and give it a value similar to deletedMessage.
We then can then add a check in ReportUtils.getReportName that would return hiddenMessage if the parentReport has MODERATOR_DECISION_PENDING_HIDE or MODERATOR_DECISION_HIDDEN.
changed the title [-]Web - Thread report and LHN title still visible after thread parent message being flagged as Intimidation or Bullying[/-][+][$1000] Web - Thread report and LHN title still visible after thread parent message being flagged as Intimidation or Bullying[/+]on Jun 30, 2023
@sonialiap are you still able to reproduce this now? I just tested on my end, and it seemed to work. Though, I had to click into the thread after reporting the message before the title updated to Hidden message.
Okay, I tested this again, and it's working for me. So going to close this out. @sonialiap LMK if you see this not working again, and happy to look into it more.
Please note that @thesahindia still needs to request payment, but advised we can close this in the interim, and he'll request payment once the issue with his bank account is resolved.
Here's the summary of payments for when we pay this in NewDot:
@AmjedNazzal - $1,750 ($1000 for PR + $500 speed bonus + $250 reporting bonus). Paid via Upwork.
@thesahindia $1,500 ($1000 for C+ review, and $500 speed bonus). Still needs to be paid via NewDot.
Activity
melvin-bot commentedon Jun 29, 2023
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 29, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)kbecciv commentedon Jun 29, 2023
Proposal
AmjedNazzal on GH
Please re-state the problem that we are trying to solve in this issue.
Thread report and LHN title still visible after thread parent message being flagged as Intimidation or Bullying
What is the root cause of that problem?
The text used for the titles of OptionRowLHN is retrieved from ReportUtils.getReportName which isn't handling the case where the parent message has been reported as Intimidation/Bullying or has been hidden.
App/src/libs/SidebarUtils.js
Lines 372 to 374 in 6183609
What changes do you think we should make in order to solve the problem?
We could firstly add a new entry to parentReportAction and for example call it hiddenMessage and give it a value similar to deletedMessage.
We then can then add a check in ReportUtils.getReportName that would return hiddenMessage if the parentReport has MODERATOR_DECISION_PENDING_HIDE or MODERATOR_DECISION_HIDDEN.
Result
Screen.Recording.2023-06-28.at.5.09.28.PM.mov
joekaufmanexpensify commentedon Jun 30, 2023
I can reproduce. We decided to split this off from #21497 (comment) . Seems like expected behavior here is:
[-]Web - Thread report and LHN title still visible after thread parent message being flagged as Intimidation or Bullying[/-][+][$1000] Web - Thread report and LHN title still visible after thread parent message being flagged as Intimidation or Bullying[/+]melvin-bot commentedon Jun 30, 2023
Job added to Upwork: https://www.upwork.com/jobs/~013a0825ff8c5c6ab6
melvin-bot commentedon Jun 30, 2023
Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Jun 30, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)62 remaining items
thesahindia commentedon Jul 26, 2023
I will request the payment in the morning. I had some bank issues so I was busy resolving them.
joekaufmanexpensify commentedon Jul 26, 2023
All good. Thanks!
joekaufmanexpensify commentedon Jul 28, 2023
@thesahindia did you have a chance to request payment here yet?
sonialiap commentedon Jul 28, 2023
I can reproduce the issue still
Screen.Recording.2023-07-28.at.4.42.23.PM.mov
thesahindia commentedon Jul 28, 2023
I couldn't. I am facing issues while adding my bank account. I have asked about it here.
You can just close the issue, I will add it to my list and will request payment once the problem gets resolved (Did the same on other tickets)
thesahindia commentedon Jul 28, 2023
I think it is a regression and not related to the current issue.
joekaufmanexpensify commentedon Jul 31, 2023
i will take a look into this today.
joekaufmanexpensify commentedon Jul 31, 2023
@sonialiap are you still able to reproduce this now? I just tested on my end, and it seemed to work. Though, I had to click into the thread after reporting the message before the title updated to
Hidden message.joekaufmanexpensify commentedon Aug 1, 2023
Still figuring this out
joekaufmanexpensify commentedon Aug 2, 2023
Okay, I tested this again, and it's working for me. So going to close this out. @sonialiap LMK if you see this not working again, and happy to look into it more.
joekaufmanexpensify commentedon Aug 2, 2023
Please note that @thesahindia still needs to request payment, but advised we can close this in the interim, and he'll request payment once the issue with his bank account is resolved.
Here's the summary of payments for when we pay this in NewDot:
JmillsExpensify commentedon Aug 24, 2023
Reviewed the details for @thesahindia. $1,500 approved for payment in NewDot based on the BZ summary above.