Skip to content

[HOLD for payment 2023-07-24] [$1000] Web - Thread report and LHN title still visible after thread parent message being flagged as Intimidation or Bullying #21890

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Send a message from account A to account B
  2. From account B reply to the message in thread
  3. From account B go back to the original report and flag the message as Intimidation or Bullying
  1. Go back to the thread and notice the thread title still being visible in LHN and thread report

Expected Result:

LHN title and thread report title should display "Message Hidden" while the parent message of the thread has MODERATOR_DECISION of PENDING_HIDE or HIDDEN

Actual Result:

LHN title and thread report title are still visible

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.33-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-28.at.5.14.55.PM.1.mov
Recording.959.mp4

Expensify/Expensify Issue URL:
Issue reported by: Amjed Nazzal
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687962396495309

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013a0825ff8c5c6ab6
  • Upwork Job ID: 1674891685053624320
  • Last Price Increase: 2023-07-07

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 29, 2023
  2. melvin-bot commented on Jun 29, 2023

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jun 29, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. kbecciv commented on Jun 29, 2023

    @kbecciv
    Author

    Proposal

    AmjedNazzal on GH

    Please re-state the problem that we are trying to solve in this issue.

    Thread report and LHN title still visible after thread parent message being flagged as Intimidation or Bullying

    What is the root cause of that problem?

    The text used for the titles of OptionRowLHN is retrieved from ReportUtils.getReportName which isn't handling the case where the parent message has been reported as Intimidation/Bullying or has been hidden.

    const reportName = ReportUtils.getReportName(report);
    result.text = reportName;

    What changes do you think we should make in order to solve the problem?

    We could firstly add a new entry to parentReportAction and for example call it hiddenMessage and give it a value similar to deletedMessage.
    We then can then add a check in ReportUtils.getReportName that would return hiddenMessage if the parentReport has MODERATOR_DECISION_PENDING_HIDE or MODERATOR_DECISION_HIDDEN.

    if (
        lodashGet(parentReportAction, 'message[0].moderationDecisions[0].decision') === CONST.MODERATION.MODERATOR_DECISION_PENDING_HIDE ||
        lodashGet(parentReportAction, 'message[0].moderationDecisions[0].decision') === CONST.MODERATION.MODERATOR_DECISION_HIDDEN
    ) {
        return Localize.translateLocal('parentReportAction.hiddenMessage');
    }

    Result

    Screen.Recording.2023-06-28.at.5.09.28.PM.mov
  5. joekaufmanexpensify commented on Jun 30, 2023

    @joekaufmanexpensify
    Contributor

    I can reproduce. We decided to split this off from #21497 (comment) . Seems like expected behavior here is:

    Intimidation/Bullying: The message will show as [Hidden]. You can still access the replies. The thread can be seen in LHN but titled [Hidden]

  6. changed the title [-]Web - Thread report and LHN title still visible after thread parent message being flagged as Intimidation or Bullying[/-] [+][$1000] Web - Thread report and LHN title still visible after thread parent message being flagged as Intimidation or Bullying[/+] on Jun 30, 2023
  7. melvin-bot commented on Jun 30, 2023

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 30, 2023
  9. melvin-bot commented on Jun 30, 2023

    @melvin-bot

    Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

  10. melvin-bot commented on Jun 30, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

  11. 62 remaining items

  12. thesahindia commented on Jul 26, 2023

    @thesahindia
    Member

    I will request the payment in the morning. I had some bank issues so I was busy resolving them.

  13. joekaufmanexpensify commented on Jul 26, 2023

    @joekaufmanexpensify
    Contributor

    All good. Thanks!

  14. joekaufmanexpensify commented on Jul 28, 2023

    @joekaufmanexpensify
    Contributor

    @thesahindia did you have a chance to request payment here yet?

  15. sonialiap commented on Jul 28, 2023

    @sonialiap
    Contributor

    I can reproduce the issue still

    Screen.Recording.2023-07-28.at.4.42.23.PM.mov
  16. thesahindia commented on Jul 28, 2023

    @thesahindia
    Member

    I couldn't. I am facing issues while adding my bank account. I have asked about it here.

    You can just close the issue, I will add it to my list and will request payment once the problem gets resolved (Did the same on other tickets)

  17. thesahindia commented on Jul 28, 2023

    @thesahindia
    Member

    I can reproduce the issue still

    I think it is a regression and not related to the current issue.

  18. joekaufmanexpensify commented on Jul 31, 2023

    @joekaufmanexpensify
    Contributor

    i will take a look into this today.

  19. joekaufmanexpensify commented on Jul 31, 2023

    @joekaufmanexpensify
    Contributor

    @sonialiap are you still able to reproduce this now? I just tested on my end, and it seemed to work. Though, I had to click into the thread after reporting the message before the title updated to Hidden message.

    image
  20. joekaufmanexpensify commented on Aug 1, 2023

    @joekaufmanexpensify
    Contributor

    Still figuring this out

  21. joekaufmanexpensify commented on Aug 2, 2023

    @joekaufmanexpensify
    Contributor

    Okay, I tested this again, and it's working for me. So going to close this out. @sonialiap LMK if you see this not working again, and happy to look into it more.

  22. joekaufmanexpensify commented on Aug 2, 2023

    @joekaufmanexpensify
    Contributor

    Please note that @thesahindia still needs to request payment, but advised we can close this in the interim, and he'll request payment once the issue with his bank account is resolved.

    Here's the summary of payments for when we pay this in NewDot:

    • @AmjedNazzal - $1,750 ($1000 for PR + $500 speed bonus + $250 reporting bonus). Paid via Upwork.
    • @thesahindia $1,500 ($1000 for C+ review, and $500 speed bonus). Still needs to be paid via NewDot.
  23. JmillsExpensify commented on Aug 24, 2023

    @JmillsExpensify
    Contributor

    Reviewed the details for @thesahindia. $1,500 approved for payment in NewDot based on the BZ summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorWaiting for copyUser facing verbiage needs polishing

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions