[HOLD for payment 2023-10-18] [$1000] Visit the Room welcome message edit page by direct link then click save button, it navigates back to the chatReport instead of Room setting page

@hoangzinh

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Pre-step: Go to any room that you have permission to update welcome message => Go to Room welcome message paste => Copy the URL => Paste to any chat report

Click on the link that you just paste
Verify that it open the Room welcome message page
Click save button

Expected Result:

It navigates back to Room setting page

Actual Result:

It navigates back to the chat report page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Desktop.2023.06.30.-.20.55.42.10.mp4

Screen.Recording.2023-06-30.at.19.02.10.mov

Expensify/Expensify Issue URL:
Issue reported by: @hoangzinh
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688126512179099

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e35dd505b57309c2
Upwork Job ID: 1684161543399026688
Last Price Increase: 2023-07-26
Automatic offers:

situchan | Reviewer | 26196235
hoangzinh | Contributor | 26196236
hoangzinh | Reporter | 26196237

@dylanexpensify

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

Visit the Room welcome message edit page by direct link then click save button, it navigates back to the chatReport instead of Room setting page

What is the root cause of that problem?

In the action to save the Room's welcome message, we just call Navigation.goBack

App/src/libs/actions/Report.js

Line 1142 in 0bbf3fc

Navigation.goBack();

When we visit the page by direct link, the previous history page is empty => It will navigate to the chat report by default.

What changes do you think we should make in order to solve the problem?

We should add fallbackRoute of room setting page for Navigation.goBack here

Navigation.goBack(ROUTES.getReportSettingsRoute(reportID));

So it will navigate to the room setting route when there is no active routes

What alternative solutions did you explore? (Optional)

Instead of call Navigation.goBack, we can call Navigation.navigate directly to the room setting route here

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Visit the Room welcome message edit page by direct link then click save button, it navigates back to the chatReport instead of Room setting page

What is the root cause of that problem?

In the action to save the Room's welcome message, we just call Navigation.goBack

App/src/libs/actions/Report.js

Line 1142 in 0bbf3fc

Navigation.goBack();

When we visit the page by direct link, the previous history page is empty => It will navigate to the chat report by default.

What changes do you think we should make in order to solve the problem?

We should add fallbackRoute of room setting page for Navigation.goBack here

Navigation.goBack(ROUTES.getReportSettingsRoute(reportID));

So it will navigate to the room setting route when there is no active routes

What alternative solutions did you explore? (Optional)

Instead of call Navigation.goBack, we can call Navigation.navigate directly to the room setting route here

hmmm, posting to get a check on if this is intentional

Not a bug here

@dylanexpensify

@dylanexpensify, but when we visit Room welcome message edit page direct link, after click save button, it closes the RHN. It think it's an unexpected behavior. It should back to the room setting

@dylanexpensify

Bump @dylanexpensify ^

Payment upcoming!

how we doin here? 🙏

@dylanexpensify

We good here @dylanexpensify ?

@Beamanator

@Beamanator waiting for BZ checklist and payout here.

The PR that introduced the bug has been identified. Link to the PR: This is not normal user flow and always existed from the beginning.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1690915949087489
Determine if we should create a regression test for this bug. In [HOLD for payment 2023-10-02] [$1000] Add a mandatory route param to Navigation.goBack to prevent bugs #24291, we made fallback route necessary for navigation goBack method. I think this will help preventing similar bugs in the future.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. I have same thought as [HOLD for payment 2023-10-02] [$1000] Add a mandatory route param to Navigation.goBack to prevent bugs #24291 (comment)

done!

Navigation Menu

Repository navigation

[HOLD for payment 2023-10-18] [$1000] Visit the Room welcome message edit page by direct link then click save button, it navigates back to the chatReport instead of Room setting page #22041

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

105 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-10-18] [$1000] Visit the Room welcome message edit page by direct link then click save button, it navigates back to the chatReport instead of Room setting page #22041

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jul 2, 2023

melvin-bot commented on Jul 2, 2023

Bug0 Triage Checklist (Main S/O)

kavimuru commented on Jul 2, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jul 2, 2023

hoangzinh commented on Jul 2, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dylanexpensify commented on Jul 4, 2023

dylanexpensify commented on Jul 7, 2023

hoangzinh commented on Jul 7, 2023

hoangzinh commented on Jul 17, 2023

105 remaining items

dylanexpensify commented on Oct 18, 2023

Beamanator commented on Oct 23, 2023

Beamanator commented on Oct 26, 2023

hoangzinh commented on Oct 26, 2023

situchan commented on Oct 26, 2023

dylanexpensify commented on Oct 30, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions