Skip to content

[$1000] Chat - Copy email option is missing chat settings with new user #22192

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #21779

Action Performed:

  1. Open app and login with User A
  2. Click on new chat and enter an email of a User B (new user that doesn't have Expensify account)
  3. Click on header of chat and copy the email of User B

Expected Result:

Copy email option should be available

Actual Result:

Copy email option is missing on Web in chat with new user

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.36.4

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6116111_video_48__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Yes

Slack conversation: Yes

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0198cc663a4ea8fbfd
  • Upwork Job ID: 1677354613124038656
  • Last Price Increase: 2023-07-21

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 4, 2023
  2. melvin-bot commented on Jul 4, 2023

    @melvin-bot

    Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jul 4, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. dummy-1111 commented on Jul 4, 2023

    @dummy-1111
    Contributor

    This should be fixed in the backend. When open report with new email, the backend now returns accountID, avatar, and displayName. This should include login as well.
    image

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 7, 2023
  6. changed the title [-]Chat - Copy email option is missing chat settings with new user[/-] [+][$1000] Chat - Copy email option is missing chat settings with new user[/+] on Jul 7, 2023
  7. melvin-bot commented on Jul 7, 2023

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 7, 2023
  9. melvin-bot commented on Jul 7, 2023

    @melvin-bot

    Current assignee @anmurali is eligible for the External assigner, not assigning anyone new.

  10. melvin-bot commented on Jul 7, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

  11. anmurali commented on Jul 7, 2023

    @anmurali

    Ideally we fix this by adding the Email to the profile even for new users? (We won't have the rest like pronouns etc.)
    Looks like this:
    image

    But we want it to look like this:
    image

  12. 21 remaining items

  13. abdulrahuman5196 commented on Jul 19, 2023

    @abdulrahuman5196
    Contributor

    Reviewing now

  14. abdulrahuman5196 commented on Jul 19, 2023

    @abdulrahuman5196
    Contributor

    @ShogunFire for proposal here #22192 (comment)
    I don't think using displayName will be a right option, since displayname can be something with isn't email.

  15. abdulrahuman5196 commented on Jul 19, 2023

    @abdulrahuman5196
    Contributor

    I think this is due to the recent change of not sending login value as part of userdetails for privacy concerns. So I am not sure on the new expectation of this issue on the profile page. So tagging @luacmartins (Assuming he worked on this, if not kindly tag the person who be able to provide the expectation on this)

  16. luacmartins commented on Jul 19, 2023

    @luacmartins
    Contributor

    Thanks for the ping. I didn't work directly on this feature. @Beamanator can you weigh in here? 🙇

  17. ShogunFire commented on Jul 19, 2023

    @ShogunFire
    Contributor

    There are times where it's impossible to get the email if I understand correctly. In that case I think we should focus on the times where we can get the email/phone number

    What do you think of doing the last sentence of my alternative proposal:

    and maybe also test that displayName is a correct email or sms

  18. Beamanator commented on Jul 20, 2023

    @Beamanator
    Contributor

    The email NOT showing up in this case was by design - if you don't "know" the user, you won't get their login in the returned personal details

    cc @puneetlath as we both worked on this project

    I believe we should :donothing: here

    @lanitochka17 when you created this issue, you mentioned Slack conversation: Yes but you didn't link a slack convo

  19. melvin-bot commented on Jul 21, 2023

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  20. anmurali commented on Jul 24, 2023

    @anmurali

    @Beamanator so do we just need to close this issue then? What are we waiting on?

  21. puneetlath commented on Jul 24, 2023

    @puneetlath
    Contributor

    I agree this isn't a bug and can be closed.

  22. ShogunFire commented on Jul 24, 2023

    @ShogunFire
    Contributor

    I find it weird that userA doesn't know userB login when he has used this login to create the chat...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions