Skip to content

[HOLD for payment 2023-07-20] [$1000] Dev : closing the keyboard shows a warning on dev. #22206

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Run the dev app.
  2. Go to any chat.
  3. Tab composer to open the keyboard.
  4. Hide the keyboard by dragging down.

Expected Result:

No warnings are shown.

Actual Result:

A warning is shown(See the attachment).

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number:
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screenshot 2023-07-02 at 1 47 53 PM

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688406249179949

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0135902153bfc14487
  • Upwork Job ID: 1678296096048033792
  • Last Price Increase: 2023-07-10

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 4, 2023
  2. melvin-bot commented on Jul 4, 2023

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jul 4, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. parasharrajat commented on Jul 4, 2023

    @parasharrajat
    Member

    Cc: @ntdiary You might be interested in solving this.

  5. dylanexpensify commented on Jul 5, 2023

    @dylanexpensify
    Contributor

    posted to slack to get someone with a dev acct to repro this

  6. ntdiary commented on Jul 5, 2023

    @ntdiary
    Contributor

    Cc: @ntdiary You might be interested in solving this.

    Yeah, it's still reproducible, and if needed, I'm glad to raise a proposal and PR. : )

    test.mp4
  7. ntdiary commented on Jul 5, 2023

    @ntdiary
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Closing the keyboard will generate a warning that the enabled property does not exist.

    What is the root cause of that problem?

    + if (enabled && duration && easing) {

    This enabled variable is not defined.

    What changes do you think we should make in order to solve the problem?

    I think what we actually wanted to use is this.props.enabled, we can replace enabled with this.props.enabled

    What alternative solutions did you explore? (Optional)

    N/A

  8. parasharrajat commented on Jul 9, 2023

    @parasharrajat
    Member

    @dylanexpensify It is reproducible on main. We don't need to wait here. Let's get this fixed.

    @ntdiary 's proposal looks good to me.

    🎀 👀 🎀 C+ reviewed

  9. melvin-bot commented on Jul 9, 2023

    @melvin-bot

    Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  10. parasharrajat commented on Jul 9, 2023

    @parasharrajat
    Member

    THis issue might be the root cause of #21540 (comment).

  11. 51 remaining items

  12. 0xmiroslav commented on Aug 10, 2023

    @0xmiroslav
    Contributor

    @dylanexpensify please hold my payment. I just replied email with full details - #22745 (comment)

  13. dylanexpensify commented on Aug 11, 2023

    @dylanexpensify
    Contributor

    got it, moving this to weekly!

  14. dylanexpensify commented on Aug 18, 2023

    @dylanexpensify
    Contributor

    still waiting

  15. 0xmiroslav commented on Aug 18, 2023

    @0xmiroslav
    Contributor

    Not on hold anymore.
    @dylanexpensify can you check last email thread and handle my payment please?

  16. dylanexpensify commented on Aug 25, 2023

    @dylanexpensify
    Contributor

    Yes! TY!

  17. dylanexpensify commented on Aug 25, 2023

    @dylanexpensify
    Contributor

    @0xmiroslav do we just need a new upwork job for Volodymyr to apply to?

  18. 0xmiroslav commented on Aug 25, 2023

    @0xmiroslav
    Contributor

    I think https://www.upwork.com/jobs/~0135902153bfc14487 can be reused if not expired.

  19. dylanexpensify commented on Sep 1, 2023

    @dylanexpensify
    Contributor

    @0xmiroslav mind having them apply here? 🙇‍♂️

  20. dylanexpensify commented on Sep 20, 2023

    @dylanexpensify
    Contributor

    bump on this @0xmiroslav ^ 🙇‍♂️

  21. 0xmiroslav commented on Sep 20, 2023

    @0xmiroslav
    Contributor

    @dylanexpensify applied. thanks

  22. dylanexpensify commented on Sep 20, 2023

    @dylanexpensify
    Contributor

    offer sent @0xmiroslav!

  23. dylanexpensify commented on Sep 20, 2023

    @dylanexpensify
    Contributor

    all done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions