You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-20] [$1000] Dev : closing the keyboard shows a warning on dev. #22206
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: Reproducible in staging?: dev Reproducible in production?: dev If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Activity
melvin-bot commentedon Jul 4, 2023
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 4, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)parasharrajat commentedon Jul 4, 2023
Cc: @ntdiary You might be interested in solving this.
dylanexpensify commentedon Jul 5, 2023
posted to slack to get someone with a dev acct to repro this
ntdiary commentedon Jul 5, 2023
Yeah, it's still reproducible, and if needed, I'm glad to raise a proposal and PR. : )
test.mp4
ntdiary commentedon Jul 5, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Closing the keyboard will generate a warning that the
enabledproperty does not exist.What is the root cause of that problem?
App/patches/react-native+0.71.2-alpha.3.patch
Line 67 in 15e547e
This
enabledvariable is not defined.What changes do you think we should make in order to solve the problem?
I think what we actually wanted to use is
this.props.enabled, we can replaceenabledwiththis.props.enabledWhat alternative solutions did you explore? (Optional)
N/A
parasharrajat commentedon Jul 9, 2023
@dylanexpensify It is reproducible on main. We don't need to wait here. Let's get this fixed.
@ntdiary 's proposal looks good to me.
🎀 👀 🎀 C+ reviewed
melvin-bot commentedon Jul 9, 2023
Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
parasharrajat commentedon Jul 9, 2023
THis issue might be the root cause of #21540 (comment).
51 remaining items
0xmiroslav commentedon Aug 10, 2023
@dylanexpensify please hold my payment. I just replied email with full details - #22745 (comment)
dylanexpensify commentedon Aug 11, 2023
got it, moving this to weekly!
dylanexpensify commentedon Aug 18, 2023
still waiting
0xmiroslav commentedon Aug 18, 2023
Not on hold anymore.
@dylanexpensify can you check last email thread and handle my payment please?
dylanexpensify commentedon Aug 25, 2023
Yes! TY!
dylanexpensify commentedon Aug 25, 2023
@0xmiroslav do we just need a new upwork job for Volodymyr to apply to?
0xmiroslav commentedon Aug 25, 2023
I think https://www.upwork.com/jobs/~0135902153bfc14487 can be reused if not expired.
dylanexpensify commentedon Sep 1, 2023
@0xmiroslav mind having them apply here? 🙇♂️
dylanexpensify commentedon Sep 20, 2023
bump on this @0xmiroslav ^ 🙇♂️
0xmiroslav commentedon Sep 20, 2023
@dylanexpensify applied. thanks
dylanexpensify commentedon Sep 20, 2023
offer sent @0xmiroslav!
dylanexpensify commentedon Sep 20, 2023
all done!