[HOLD for completion checklist] [$1000] Invalid number stays in contacts list

@Nathan-Mulugeta

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Start a new chat with an invalid number, for example +916541237890
Close the error
Click on FAB > New chat

Expected Result:

The invalid number should not appear on the contact list

Actual Result: The invalid number stays in th

e contact list

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.36-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-07-03.21.38.18.mp4

Recording.1156.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688409641152459

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010bc8c0b49aadb102
Upwork Job ID: 1677361800252989440
Last Price Increase: 2023-07-07

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invalid number stays in contacts list

What is the root cause of that problem?

When we open a new report, we update personalDetailsList in optimisticData.

App/src/libs/actions/Report.js

Lines 454 to 458 in e23cd16

    
           onyxData.optimisticData.push({ 
        
               onyxMethod: Onyx.METHOD.MERGE, 
        
               key: ONYXKEYS.PERSONAL_DETAILS_LIST, 
        
               value: optimisticPersonalDetails, 
        
           });

But we don't clear it in failureData. That is why the invalid contact stays in the contacts list

What changes do you think we should make in order to solve the problem?

We should create a failurePersonalDetails that will clear the personalDetails of invalid contact if openReport API returns error

const optimisticPersonalDetails = {};
const failurePersonalDetails = {};
_.map(participantLoginList, (login, index) => {
    const accountID = newReportObject.participantAccountIDs[index];
    optimisticPersonalDetails[accountID] = allPersonalDetails[accountID] || {
        login,
        accountID,
        avatar: UserUtils.getDefaultAvatarURL(accountID),
        displayName: login,
    };

    failurePersonalDetails[accountID] = allPersonalDetails[accountID] || null;
});
onyxData.optimisticData.push({
    onyxMethod: Onyx.METHOD.MERGE,
    key: ONYXKEYS.PERSONAL_DETAILS_LIST,
    value: optimisticPersonalDetails,
});

onyxData.failureData.push({
    onyxMethod: Onyx.METHOD.MERGE,
    key: ONYXKEYS.PERSONAL_DETAILS_LIST,
    value: failurePersonalDetails,
})

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.04-07-2023.16.19.37.webm

@twisterdotcom

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@omarirfan68

📣 @omarirfan68! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

Contributor details
Your Expensify account email: omarirfanmuhammad68@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/omarirfan

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

now how can i submit the proposal

Just follow the format like this.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.41-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Remove invalid user from contact list #22612

If no regressions arise, payment will be issued on 2023-07-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@narefyev91

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
[@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@narefyev91] Determine if we should create a regression test for this bug.
[@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Hiya folks. I'm OOO today, but just today. If you absolutely need payment today, please reach out in the open source slack channel. Otherwise, I'll do these tomorrow. Thanks!

@Nathan-Mulugeta

External issue reporter: @Nathan-Mulugeta has a $250 payment offer here: https://www.upwork.com/nx/wm/pre-hire/c/8577561/offer/25751205
Contributor that fixed the issue: @dukenv0307 paid $1500 here: https://www.upwork.com/ab/feedbacks/c/1328455843768528896/contract/34187160
Contributor+ that helped on the issue and/or PR: @narefyev91 is from Callstack.

@narefyev91 - we need the checklist completing here before this can be closed please: #22209 (comment)

@narefyev91

@narefyev91 please fill the checklist.

The PR that introduced the bug has been identified. Link to the PR - that changed were not coming from any regressions - it's fully new implementation
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - no comments
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion - no discussions
Determine if we should create a regression test for this bug - no needs any regression tests in case issue was not triggered by any regressions

Navigation Menu

Repository navigation

[HOLD for completion checklist] [$1000] Invalid number stays in contacts list #22209

Action Performed:

Expected Result:

Actual Result: The invalid number stays in th

Workaround:

Platforms:

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

Bug0 Triage Checklist (Main S/O)

24 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	onyxData.optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.PERSONAL_DETAILS_LIST,
	value: optimisticPersonalDetails,
	});

[HOLD for completion checklist] [$1000] Invalid number stays in contacts list #22209

Description

Action Performed:

Expected Result:

Actual Result: The invalid number stays in th

Workaround:

Platforms:

Activity

dukenv0307 commented on Jul 4, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

melvin-bot commented on Jul 4, 2023

melvin-bot commented on Jul 4, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Jul 4, 2023

melvin-bot commented on Jul 4, 2023

omarirfan68 commented on Jul 4, 2023

melvin-bot commented on Jul 4, 2023

omarirfan68 commented on Jul 4, 2023

twisterdotcom commented on Jul 4, 2023

24 remaining items

melvin-bot commented on Jul 17, 2023

melvin-bot commented on Jul 17, 2023

melvin-bot commented on Jul 17, 2023

twisterdotcom commented on Jul 24, 2023

twisterdotcom commented on Jul 25, 2023

danieldoglas commented on Jul 31, 2023

narefyev91 commented on Aug 1, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions