Skip to content

[$1000] [HOLD FOR PAYMENT 13-07-23] Web - Repeated copy of contact method URL adds characters in URL triggering its not here page #22263

New issue
New issue
Closed
Closed
[$1000] [HOLD FOR PAYMENT 13-07-23] Web - Repeated copy of contact method URL adds characters in URL triggering its not here page#22263
Assignees
JulesssssNicMendoncathesahindiasituchan
Labels
BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Description

@kbecciv
kbecciv
opened on Jul 5, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Open the app
  2. Open settings
  3. Open profile
  4. Open contact method
  5. Open non default contact method and copy the URL
  6. paste URL in any report and send
  7. Click on URL and observe that it opens correct contact method page, again copy the URL and send in report
  8. Click on URL sent in step 7 to observe that now it provides 'Hmm its not here' page

Expected Result:

App should not add content to URL while visiting to avoid 'Hmm its not here' page error on recopy and revisit

Actual Result:

App adds new content in URL of contact method whenever we visit it again by deep link triggering 'Hmm its not here' on 2nd URL copy and visit

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.36-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

recopy.and.revisit.contact.method.not.here.error.mp4
Recording.3426.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688490569899239

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ae16ee8b22ed14a7
  • Upwork Job ID: 1680122209842212864
  • Last Price Increase: 2023-07-15

Activity

  1. kbecciv
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 5, 2023
  2. melvin-bot
    assigned
    NicMendonca
    on Jul 5, 2023

  3. melvin-bot commented on Jul 5, 2023

    @melvin-bot
    melvin-botBot
    on Jul 5, 2023

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Jul 5, 2023

    @melvin-bot
    melvin-botBot
    on Jul 5, 2023

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

  5. hungvu193 commented on Jul 5, 2023

    @hungvu193
    hungvu193
    on Jul 5, 2023
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Web - Repeated copy of contact method URL adds characters in URL triggering its not here page

    What is the root cause of that problem?

    If we take a look at the link, we can see the email param was decoded 2 times which caused the issue.

    What changes do you think we should make in order to solve the problem?

    We should get rid of using encodeURIComponent in here, it should be:

    getEditContactMethodRoute: (contactMethod) => `${SETTINGS_CONTACT_METHODS}/${contactMethod}/details`,

    What alternative solutions did you explore? (Optional)

    N/A

  6. melvin-bot commented on Jul 6, 2023

    @melvin-bot
    melvin-botBot
    on Jul 6, 2023

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  7. Julesssss commented on Jul 6, 2023

    @Julesssss
    Julesssss
    on Jul 6, 2023
    Contributor

    Already fixed here

  8. Julesssss commented on Jul 6, 2023

    @Julesssss
    Julesssss
    on Jul 6, 2023
    Contributor

    Resolved as of v1.3.37-3

  9. Julesssss
    self-assigned this
    on Jul 6, 2023

  10. Julesssss commented on Jul 6, 2023

    @Julesssss
    Julesssss
    on Jul 6, 2023
    Contributor

    Reporter bonus is valid though. So I'll leave the issue open.

  11. Julesssss
    changed the title [-]Web - Repeated copy of contact method URL adds characters in URL triggering its not here page[/-] [+][HOLD FOR PAYMENT 13-07-23] Web - Repeated copy of contact method URL adds characters in URL triggering its not here page[/+] on Jul 6, 2023
  12. Julesssss
    added
    WeeklyKSv2
    and removed
    DailyKSv2
    on Jul 6, 2023

  13. situchan commented on Jul 6, 2023

    @situchan
    situchan
    on Jul 6, 2023
    Contributor

    @Julesssss can you please assign me to the issue? As I was the author of PR

  14. 28 remaining items

  15. NicMendonca commented on Jul 18, 2023

    @NicMendonca
    NicMendonca
    on Jul 18, 2023
    Contributor

    @situchan @dhanashree-sawant - you've both been paid 🎉

    @thesahindia do you want me to keep this open as a reminder to request payment in NewDot?

  16. NicMendonca commented on Jul 18, 2023

    @NicMendonca
    NicMendonca
    on Jul 18, 2023
    Contributor

    @thesahindia says he's got this on his to-do! closing!

  17. NicMendonca
    closed this as completedon Jul 18, 2023
  18. JmillsExpensify
    reopened this on Sep 22, 2023

  19. JmillsExpensify commented on Sep 22, 2023

    @JmillsExpensify
    JmillsExpensify
    on Sep 22, 2023
    Contributor

    @NicMendonca Do you mind adding a payment summary on this issue so that I can pay @thesahindia?

  20. NicMendonca commented on Sep 22, 2023

    @NicMendonca
    NicMendonca
    on Sep 22, 2023
    Contributor

    cc @JmillsExpensify ^^

  21. thesahindia commented on Sep 22, 2023

    @thesahindia
    thesahindia
    on Sep 22, 2023
    Member

    Looks like I requested $1500. Editing it now!

  22. situchan commented on Sep 22, 2023

    @situchan
    situchan
    on Sep 22, 2023
    Contributor

    $1500 should be correct amount. PR was merged within a day

  23. thesahindia commented on Sep 22, 2023

    @thesahindia
    thesahindia
    on Sep 22, 2023
    Member

    Ahh, thanks @situchan. Changing it again.

  24. melvin-bot
    added
    Overdue
    on Sep 25, 2023

  25. NicMendonca commented on Sep 25, 2023

    @NicMendonca
    NicMendonca
    on Sep 25, 2023
    Contributor

    Sorry, you're right! This was quite a long time ago I forgot!

    image

  26. melvin-bot
    removed
    Overdue
    on Sep 25, 2023

  27. NicMendonca commented on Sep 25, 2023

    @NicMendonca
    NicMendonca
    on Sep 25, 2023
    Contributor

    reporter: @dhanashree-sawant - $250
    Contributor: @situchan - $1,500
    C+: @thesahindia - $1,500

  28. NicMendonca
    closed this as completedon Sep 25, 2023

  29. JmillsExpensify commented on Oct 5, 2023

    @JmillsExpensify
    JmillsExpensify
    on Oct 5, 2023
    Contributor

    $1,500 payment approved for @thesahindia based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions