Repository navigation
Deploy Checklist: New Expensify 2023-07-05 #22282
Description
Release Version: 1.3.37-7
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Send
mostRecentReportActionLastModifiedwithReconnectApp#18807 - Migrate NewChatPage to functional component #20170
- [Fix #16696] Rewrite
BaseTextInputto function component #20186 - Migrate MoneyRequestParticipantsSplitSelector.js to function component #20271
- Migrate SignInPage to function component ... again #20708
- Fix: Remain focus when selecting option #20736
- [navigation-refactor] Use minimal action to navigate inside RHP #21067
- Thread subheaders and parent navigation #21092
- fix: pop all reports after screen resize #21312
- fix: remove arm64 from Excluded Archs for IOS #21316
- Fix continue bank account text is crossed out when initiating Start Over while offline #21372
- Fix shield icon hover effect #21548
- [No QA] [Fix] Remove all Betas access for dev environment #21655
- fix: solve missing avatar workspace logo issue #21657
- Fix:
UpdateFrequentlyUsedEmojisAPI spamming #21772 - refactor: migrate BankAccountManualStep to function component #21778
- Remove personalDetails as part of personalDetails migration #21844
- Fix: Web - Country field does not autofill for certain addresses. #21520 #21853
- fix: disable all-members button on admin channel #21857
- Remove all uses of
actorEmailas part of personalDetails migration #21874 - Fix phone number show twice in tooltip #21893
- Refactor accessibilityRoles to use CONST values #21916
- fix: emoji showing original message for few moments #21933
- Fix can't open View all receipts in safari #21934
- Fix pressing enter in workspace invite page will submit and proceed to invite message page #21935
- Fix: App does not dynamically translate address options #21949
- Focus the composer again after going back from a report not found #21962
- [No QA] fix electron version diff in package-lock.json #21999
- Component refactor: migrate WorkspaceNewRoomPage to function component #22015
- Added formatPhoneNumber on sharecode page #22098
- prevent user with no permission from flag comment #22099
- Fix app refocuses on compose box even when RHN is open if we right click on emoji reaction and click on user #22107
- Display not found page if cannot create task #22157
- Ensure correct task state for fresh session of unassigned user #22171
- [NoQA] Use the variable from hook rather then props #22191
- Show visible tooltip after animation cancel #22249
- Fix: Modal type in close Account confirmation #22251
- Fix - magic input loses focus when clicked on didn't receive magic code #22265
- Revert "Remove all uses of
actorEmailas part of personalDetails migration" #22303 - add missing path in rhp navigation link #22323
- fix crash on whisper thread after remove member #22360
- Do not use the replace in case of RHP as its fixing edge case #22355
- Hide only chat threads that haven't been commented on #22349
Deploy Blockers:
- [HOLD for payment 2023-07-17] [$1000] Web- Eye icon position not aligned and nothing happen on click of eye icon #22183
- [$1000] Flag as offensive option show for their own comment in offline mode #22286
- [HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] [HOLD FOR PAYMENT - 13th July] User is taken to the first step after changing currency when splitting a bill #22289
- [$1000] Web - When hovering over the message in the reply thread, the icon changes its position in the Task Assign section. #22297
- Selecting user doesn't clear input text from search field on Split Bill page #22298
- [HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] [$1000] Task thread gets hidden when clicking on other chats #22300
- [HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] Not able to split money on back button #22302
- [HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] [$1000] Contact detail page shows "Hmm... it's not here" after refresh #22308
- [HOLD for payment 2023-07-17] Bank account - Company name and connected account are shaded and hover shows a "Locked" icon #22340
- [HOLD for payment 2023-07-17] Chat -App crash after remove the member #22351
- [$1000] [HOLD for C+ Checklist] Dev: Room - Settings - Non members appears in list of room in offline mode #22353
- [Awaiting C+ Payment] [HOLD for payment 2023-08-01] [$1000] Dev: Email address is not displayed on task preview when user assigns task to themselves in DM #22373
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Jul 5, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.37-1 🚀
mvtglobally commentedon Jul 6, 2023
#21962 is failing with #21678 . Checking off
Julesssss commentedon Jul 6, 2023
Closed #22302 as a dupe of #22289
Beamanator commentedon Jul 6, 2023
Checking off #21874 since it got reverted in #22303
Julesssss commentedon Jul 6, 2023
#22289 was fixed by this PR, which I am about to cherry-pick
Julesssss commentedon Jul 6, 2023
Checked off #22297 because it is not a blocker and also isn't always reproducible
mvtglobally commentedon Jul 6, 2023
@Julesssss seeing comments about CPs, but checklist is not updating. Can you pls tag me if we need to QA any specific CPs
Regression is at 60% complete. still running through TC and PRs
Julesssss commentedon Jul 6, 2023
Yeah, I think this is going to be a persistent problem in the short-term. I'll update once the build is complete.
And to clarify, are these the manual steps we should be doing to make your job simpler?
Julesssss commentedon Jul 6, 2023
Fix is in progress for #22300
Julesssss commentedon Jul 6, 2023
#22308 was also resolved by the #22323 CP
Julesssss commentedon Jul 6, 2023
Checking off #22340 as it's not worth blocking the release on. A fix PR was just merged, but CPing it feels unnecessary due to the low importance and the delay it adds (preventing me from a hypothetical release this afternoon)
Julesssss commentedon Jul 6, 2023
mvtglobally commentedon Jul 7, 2023
Regression is completed
#20186 is repro old KI while validating #16696. Checking off
#21312 is repro old KI #20370. Checking off
#21857 (comment)
Julesssss commentedon Jul 7, 2023
Checking off two blockers (22351 & 22183), with the introduction of these PRs:
Julesssss commentedon Jul 7, 2023
Checking off another two blockers, as they are not deploy blocker worthy (both occur only on dev environments)
Julesssss commentedon Jul 7, 2023
Checked off #21857 👍
The final CP has been completed and I'm now reviewing the CP'd PRs myself manually (everything at bottom of the PRs list)
Julesssss commentedon Jul 7, 2023
I finished checking off the CP'd fixes and re-ran the developer verififications ✅
Julesssss commentedon Jul 7, 2023